Bug 89911 - Chat window switches to old size after changing tabs
Summary: Chat window switches to old size after changing tabs
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: Chat Window (show other bugs)
Version: 0.9.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-20 22:26 UTC by Malte S. Stretz
Modified: 2004-10-20 03:01 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S. Stretz 2004-09-20 22:26:00 UTC
Version:           0.9.0 (using KDE 3.3.0, Gentoo)
Compiler:          gcc version 3.3.4 20040623 (Gentoo Linux 3.3.4-r1, ssp-3.3.2-2, pie-8.7.6)
OS:                Linux (i686) release 2.6.8-gentoo-r3

I see a very werid behaviour here, only with Kopete chat windows:  If I put two (or more) chat-tabs into one window, the chat window's size jumps bag to the size it had when it was opened.  Sounds weird?  It is!

I can reproduce it with these steps:
1. Open a chat window.
2. Resize that chat window to a recognizable size.
3. Open a second chat window.
4. Resize that window to something different than the other one.
5. In the second chat window, choose the menu "Tabs", "Move Tab To Window" and then the first one.
6. Now click on the tab of the just moved tab/window:  The window itself will jump back to the size the second window had before it was merged with the first.
7. Resize the merged chat window.
8. Select the first tab:  The window will again resize to the size the second one had.

I'm currently using KDE_3_3_BRANCH from a few hours ago.  The behaviour started to appear either shortly before or after 3.3.0 was tagged.
Comment 1 P. Varet 2004-10-17 15:06:08 UTC
I didn't have this problem with 3.3.0. It appeared as of 3.3.1.

An annoying but usable temporary workaround is to:
1) Resize the chat window,
2) Close it,
3) Reopen it. The new size is now the default.

Hope the Kopete devs will have this one fixed soon, it doesn't look very good when demoing KDE to Windows users looking for a switch...
Comment 2 Waldo Bastian 2004-10-19 17:40:11 UTC
A similar problem has been reported to SUSE bugzilla:

If you configure kopete with iChat theme, and a single window for all chats (so 
each chat session is its own tab), the window size isn't preserved when you 
switch tabs.

* How to reproduce: 

  Configure kopete with iChat theme, and one window for all chats.  Get a couple of chats going.  Expand the window size.  Switch tabs, and observe the window go back to its original size.
Comment 3 Andrew Klang 2004-10-19 22:15:24 UTC
Seeing the same issue.  Compiled on a RHEL ES3.0 box using Konstruct.  KDE is version 3.3.1 and Kopete is 0.9.1.  I initially was using iChat theme but switched to xchat theme and the problem persists.  Same symptoms and steps to reproduce as reported above.
Comment 4 Richard Smith 2004-10-20 02:53:29 UTC
CVS commit by lilachaze: 

Apply a different fix to bug #59080 which doesn't cause bug #89911.

Basically, this is a revert of Jason's commit of 28/05/04 which appears to
be bogus; dynamically adding/removing a toolbar is not fundamentally
different to adding/removing toolbar buttons or menu items -- we should not
do it. Plus the existing fix for bug #59080 disabled this behaviour anyway.

CCBUG: 59080
CCBUG: 89911
CCMAIL: matt@matt.rogers.name


  M +0 -1      chatview.cpp   1.171
  M +1 -1      kopetechatwindow.cpp   1.92


--- kdenetwork/kopete/kopete/chatwindow/chatview.cpp  #1.170:1.171
@@ -230,5 +230,4 @@ ChatView::ChatView( Kopete::MessageManag
                 mgr->protocol()->capabilities() );
         connect( editpart, SIGNAL( toggleToolbar(bool)), this, SLOT(slotToggleRtfToolbar(bool)) );
-        connect( this, SIGNAL( windowCreated()), editpart, SLOT(checkToolbarEnabled()) );
 
         m_edit = static_cast<KTextEdit*>( editpart->widget() );

--- kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp  #1.91:1.92
@@ -852,5 +852,5 @@ void KopeteChatWindow::setActiveView( QW
         guiFactory()->addClient(view->msgManager());
         createGUI( view->part() );
-        readOptions();
+        
         if( m_activeView )
                 m_activeView->setActive( false );


Comment 5 Matt Rogers 2004-10-20 03:01:28 UTC
CVS commit by mattr: 

Backport the fixes for 59080 and 89911. Should be in KDE 3.3.2
BUG: 89911
CCBUG: 59080


  M +0 -1      chatview.cpp   1.155.2.2
  M +1 -1      kopetechatwindow.cpp   1.82.2.3


--- kdenetwork/kopete/kopete/chatwindow/chatview.cpp  #1.155.2.1:1.155.2.2
@@ -217,5 +217,4 @@ ChatView::ChatView( KopeteMessageManager
                 mgr->protocol()->richTextCapabilities() );
         connect( editpart, SIGNAL( toggleToolbar(bool)), this, SLOT(slotToggleRtfToolbar(bool)) );
-        connect( this, SIGNAL( windowCreated()), editpart, SLOT(checkToolbarEnabled()) );
 
         m_edit = static_cast<KTextEdit*>( editpart->widget() );

--- kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp  #1.82.2.2:1.82.2.3
@@ -847,5 +847,5 @@ void KopeteChatWindow::setActiveView( QW
         guiFactory()->addClient(view->msgManager());
         createGUI( view->part() );
-        readOptions();
+        
         if( m_activeView )
                 m_activeView->setActive( false );