Bug 89830 - kspell aspell iso codes
Summary: kspell aspell iso codes
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kspell (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Zack Rusin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-19 19:26 UTC by Heiko Evermann
Modified: 2004-11-15 20:38 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Evermann 2004-09-19 19:26:23 UTC
Version:            (using KDE KDE 3.3.0)
Installed from:    Compiled From Sources
Compiler:          GCC 
OS:                Linux

KSpell does not work properly with aspell 0.6. In the KDE spell dialog the combo box for the available languages within aspell is not working properly.

1) KDE just scans /usr/lib/aspell (and other directories where aspell might be installed) and treats every file it finds as a language file. aspell 0.6 has put several character set definition files into /usr/lib/aspell. All these are reported as language "unknown" as KDE is not able to find out, what language it is. This clutters the combo box.
2) KDE tries to look up the 2-letter language code for use in the combo box. This is supposed to map e.g. "de" to "German". Since aspell 0.6 we can also have 3-letter language codes like in "nds" (Low Saxon) and "hsb" (Upper Sorbian) So nds or hsb are reported as "unknown". If kspell is not able to find out a text string (like in some user made spelling files) it should report "unknown (file name)". A sample hsb file can be obtained from aspell.net. A sample nds file for aspell is not yet publicly available.
3) Instead of scanning the directories it would be better to use aspell functions. This can be copied from list-dicts.c from the aspell example files. Aspell will probably be better in finding out which languages are installed and which are not, especially in the case that aspell might change the implementation.

Kind regards,

Heiko Evermann
Comment 1 Zack Rusin 2004-09-19 19:54:41 UTC
On Sunday 19 September 2004 13:26, Heiko Evermann wrote:
> 1) <snip>
> 2) <snip>

Yap 

> 3) Instead of 
> scanning the directories it would be better to use aspell functions.

KSpell doesn't link to the ASpell library and can't really do that.

> This can be copied from list-dicts.c from the aspell example files.
> Aspell will probably be better in finding out which languages are
> installed and which are not, especially in the case that aspell might
> change the implementation.

Like I said, won't happen for KSpell. Assign this bug to whichever 
application you got it from with a "port spell checking from kspell to 
kspell 2" where this is implemented correctly.

Zack

Comment 2 Heiko Evermann 2004-09-20 09:11:28 UTC
In that case it might still be possible to use the command line
"aspell --dump dicts" to get such a list.

Kind regards,

Heiko
Comment 3 Zack Rusin 2004-09-20 09:22:10 UTC
On Monday 20 September 2004 03:11, Heiko Evermann wrote:
>In that case it might still be possible to use the
> command line "aspell --dump dicts" to get such a list.

Sure, there's lots of ways to do it, but I don't have time to be fixing 
bugs in a deprecated library since we have a working replacement.

Zack

Comment 4 Heiko Evermann 2004-11-15 20:38:38 UTC
I have fixed most problems:
1) 3-letter ISO language codes (like Low Saxon or Upper Sorbian) are treated correctly
2) aspell rws dictionary files are handled correctly now. (Before they were reported as unknown)
3) The list is filtered. Only rws and multi files are displayed.
4) aspell dump dicts is still not used. For that it would be better to port to KSpell2, which should be started before KDE 3.4/KDE4
In my opinion this is sufficient for KSpell1.