Version: 1.0.0_devel (using KDE 3.1.4) Installed from: compiled sources Compiler: gcc version 3.3 20030304 (Apple Computer, Inc. build 1495) OS: Darwin (Power Macintosh) release 7.5.0 When you are reading data in "read to end" mode and you hit "pause" and then "play", the data vector is now in "count from end" mode with the number of sample equals to what it was when you hit "pause".
confirmed.
CVS commit by staikos: - filters and fits should be updated when their outputs are updated - Play should do "read to end" not "count from end" CCMAIL: 89718-done@bugs.kde.org M +2 -2 kstdoc.cpp 1.121 M +2 -0 kstfilterdialog_i.cpp 1.15 M +6 -2 kstfitdialog_i.cpp 1.39 --- kdeextragear-2/kst/kst/kstdoc.cpp #1.120:1.121 @@ -613,6 +613,6 @@ void KstDoc::samplesEnd() { for (int i = 0; i < (int)rvl.count(); i++) { V = rvl[i]; - f0 = -1; - n = V->numFrames(); + f0 = V->reqStartFrame(); + n = -1; skip = V->skip(); doSkip = V->doSkip(); --- kdeextragear-2/kst/kst/kstfilterdialog_i.cpp #1.14:1.15 @@ -279,4 +279,5 @@ bool KstFilterDialogI::saveOutputs(KstPl } v->setTagName(nt); + v->setProvider(plugin.data()); } else if (plugin->outputVectors()[(*it)._name]->tagName() != nt) { while (KST::vectorTagNameNotUnique(nt, false)) { @@ -292,4 +293,5 @@ bool KstFilterDialogI::saveOutputs(KstPl } v->setTagName(nt); + v->setProvider(plugin.data()); } } else if ((*it)._type == Plugin::Data::IOValue::FloatType) { --- kdeextragear-2/kst/kst/kstfitdialog_i.cpp #1.38:1.39 @@ -296,10 +296,14 @@ bool KstFitDialogI::saveOutputs(KstPlugi if ((*it)._type == Plugin::Data::IOValue::TableType) { if (!KST::vectorTagNameNotUnique(nt, false)) { - plugin->outputVectors()[(*it)._name]->setTagName(nt); + KstVectorPtr v = plugin->outputVectors()[(*it)._name]; + v->setTagName(nt); + v->setProvider(plugin.data()); } else if (plugin->outputVectors()[(*it)._name]->tagName() != nt) { while (KST::vectorTagNameNotUnique(nt, false)) { nt += "'"; } - plugin->outputVectors()[(*it)._name]->setTagName(nt); + KstVectorPtr v = plugin->outputVectors()[(*it)._name]; + v->setTagName(nt); + v->setProvider(plugin.data()); } } else if ((*it)._type == Plugin::Data::IOValue::FloatType) {
Incorrect fix.
The problem is that pause is a toggle, and the "Play" button is unrelated to it. It works as designed, it's just confusing. How should we make this more clear?
I think that too many people think of play as the opposite of pause (from the VCR analogy). The 'play' button (in the UI) isn't called play, it's called 'read from end' which is not confused with unpause, but it uses a play symbol for the button (which is confused). Kst needs a new icon for 'read to end' that doesn't make people think 'unpause'. I'm not quite sure how it should look. Pause can then remain as it is.
SVN commit 422388 by netterfield: new crystal style datamode icon improved crystal style changefile icon use more analogous forward, reverse, pause, and end icons from sound player. BUG: 89718 M hi32-mime-kst.png M +5 -5 kst.cpp M +39 -39 kstmatrixdialog_i.cpp M pics/kst_changefile.png M pics/kst_datamode.png