Bug 89293 - [PATCH] Embed images in html mails
Summary: [PATCH] Embed images in html mails
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Unmaintained
Component: composer (show other bugs)
Version: 1.7
Platform: Mandrake RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Thomas McGuire
URL:
Keywords:
: 162892 169463 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-09-11 15:49 UTC by Helge Hielscher
Modified: 2009-07-07 23:01 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
embedded images (11.27 KB, patch)
2008-11-23 00:17 UTC, Edwin Schepers
Details
embedded images (20.64 KB, patch)
2008-12-13 22:03 UTC, Edwin Schepers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Hielscher 2004-09-11 15:49:51 UTC
Version:           1.7 (using KDE KDE 3.2.3)
Installed from:    Mandrake RPMs

Now that we have the ability to send HTML-mails I miss the option to include images inside the text of the emails.
Comment 1 Jordi A. Cam 2004-11-25 07:54:40 UTC
*** This bug has been confirmed by popular vote. ***
Comment 2 Thomas Ohms 2006-04-21 15:24:07 UTC
This one is now about 1.5 years old - is there any change in developing?
Comment 3 Karenh 2006-04-22 06:14:21 UTC
I hope developers remain open to the idea and willing to work on it.  I've read that some purists see no need for embedded images, and I fear that this keeps KDE from taking the request seriously.  I wholly disagree, and I resent it when a purist insists that I "don't need" something when I would much rather have it.  Too many times, it would have come in much handier for me and my recipients to have embedded images.  For example, it's invaluable when sending someone instructions along with screenshots.   The embedded screenshot image can closely precede or follow the relevant text.  Can you imagine a webpage where you're given instructions to follow, but then links to the accompanying screenshots are all randomly scattered at the bottom of the page?  Ugh.

Also, when sending photos such as vacation pictures, when there is a need to explain what is in each picture--preferably with a caption *immediately* above or below the picture, so the reader does not lose track of which picture you are talking about.  In any case, in mail with embedded pics, the text and image can be in immediate proximity of one another, saving a lot of confusion.  It's much more cumbersome to read text and then sort through a dozen or so attached images to find the image that the sender is referring to, than it is to read the nice flow of an HTML mail with embedded images.  It's all about readability, when it is really needed in these cases.  
Comment 4 Kilian Hagemann 2006-04-22 12:01:05 UTC
Great to see there's renewed interest in this. Not being able to embed my company logo where I want it to be is the *ONLY* reason I have to use other mail clients for my work.

But then, kmail is far more powerful (ease of multiple accounts, identities, outgoing mail servers etc.) than any other mail client I've seen, so it causes lots of headaches when switching to other clients just because of that :(

Yes - purists don't use html so don't need to embed images, but purists don't use GUI's either. And if those power users don't want html, they don't have to use it. It's the beauty of kmail's powerful configuration options.
Comment 5 Thomas Ohms 2006-06-05 04:38:52 UTC
Has anything happen to this?
Comment 6 Kilian Hagemann 2006-06-05 21:52:16 UTC
Seems like this one's still suffering from html stigma. I'm still using two mail clients, one for my company and the other one for everything else because kmail is more powerful for my very advanced needs. I wish I could embed an image into my email in kmail so that I can stop this madness.

No professional out there who's corporate branding actually means something is gonna use kmail.

Look, please implement it, even if it means turning it off by default or even make it hard to activate, but I really need this feature. I wish I could just code it myself but my C++/KDE/MIME skills leave much to be desired :(
Comment 7 Bartosz Malinowski 2006-06-11 13:32:02 UTC
Unresolved as of Kmail 1.9.1. Please, please add this feature...

Setting an image (or just any colour other than white) as a message text background (like in Evolution) would be also very welcome. 

b.
Comment 8 Bartosz Malinowski 2006-06-14 16:59:24 UTC
Hello, 
Another wanted feature is mentioned here (Bug 128986: Can't Paste HTML-formatted text into Kmail mail editor window) - anyone is kindly invited to vote for this bug.

Greetings,
b.
Comment 9 Edwin Schepers 2006-06-18 21:21:36 UTC
Please stop adding comment that you want/like this feature, vote! When I find the time, I'll try to implement this in KDE4. If anyone else starts implementing, please assign this report.
Comment 10 Benjamin Lee Solosy 2006-10-09 18:02:36 UTC
Keep up the good fight (i.e., voting) for this bug, everybody!  : )
   
I had to petition very hard four years ago just to get HTML e-mail implemented within KMail!  : )
    
See, for example:  lists.kde.org/?l=kde&m=103947241014233&w=3
Comment 11 Daniel Díaz De La Iglesia 2006-12-26 22:46:40 UTC
Hi all.
I have chosen Evolution in the work for this problem of HTML. I go many years being working with Kmail at my house and in the work i have not been able to use it.
Comment 12 Bob 2006-12-28 00:13:01 UTC
Those voting here may also be interested in <a href=http://bugs.kde.org/show_bug.cgi?id=136468>Bug 136468: No way to add inline links to outgoing messages</a>
Comment 13 Thomas McGuire 2008-05-30 16:50:43 UTC
*** Bug 162892 has been marked as a duplicate of this bug. ***
Comment 14 Thomas McGuire 2008-08-20 16:25:03 UTC
*** Bug 169463 has been marked as a duplicate of this bug. ***
Comment 15 comio 2008-09-02 22:09:14 UTC
This feature is mandatory for a business usage... In general the composer should be a little bit more flexible than the actual version.

In my opinion, Evolution is a good example how should be the composer.
Comment 16 Edwin Schepers 2008-11-23 00:17:19 UTC
Created attachment 28754 [details]
embedded images

Hi,
This is my preliminary patch to support embedded images in the composer. It would be nice if some of you could test it as it is now.

Things that do not work yet are :
- opening from drafts
- pasting from the Edit menu ( now, ctrl-v or rmb works)
- insert an embedded image and delete it again.
- consider mEarlyAddAttachments

Regards,
Edwin
Comment 17 Thomas McGuire 2008-11-30 15:22:37 UTC
> This is my preliminary patch to support embedded images in the composer. It
> would be nice if some of you could test it as it is now.

Hi! I didn't have time to look at the patch yet, i hope to get time for this next weekend. Since KDE trunk if feature-frozen at the moment, so it can only committed after the KDE 4.2.0 release anyway.

Thanks for the patch :)
Comment 18 Edwin Schepers 2008-12-13 22:03:15 UTC
Created attachment 29307 [details]
embedded images

Hi,
This patch solves the outstanding issues mentioned before and has no issues left. It would be nice if some of you could test it (signing/encrypting for sure) before I commit. That would be at least after 4.2.0.
Thomas : this one's ready for the review!
Comment 19 L_V 2009-01-12 14:32:28 UTC
Not yet implemented in KDE4.2.

Patching Kmail not so user-friendly.
Would be good to have this patch integrated for KDE4.2 release.
Comment 20 Thomas McGuire 2009-01-12 14:39:52 UTC
> Not yet implemented in KDE4.2.
>
> Patching Kmail not so user-friendly.
> Would be good to have this patch integrated for KDE4.2 release.

No, this patch is too late for 4.2, 4.2 has been feature-frozen for a long time now. The patch will make it into 4.3. It is currently still being worked on, be patient.
Comment 21 Edwin Schepers 2009-01-15 00:05:32 UTC
SVN commit 911149 by eschepers:

Possibility to add embedded images. Images can be added by the add_image button on th HTML toolbar, or image data can be pasted in the composer.
FEATURE: Embedded images in HTML mails
BUG: 89293
CCMAIL: mcguire@kde.org


 M  +1 -1      aboutdata.cpp  
 M  +10 -0     attachmentcollector.cpp  
 M  +56 -0     kmcomposereditor.cpp  
 M  +16 -0     kmcomposereditor.h  
 M  +2 -1      kmcomposerui.rc  
 M  +73 -2     kmcomposewin.cpp  
 M  +9 -0      kmcomposewin.h  
 M  +6 -2      kmmessage.cpp  
 M  +255 -63   messagecomposer.cpp  
 M  +29 -2     messagecomposer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=911149
Comment 22 Christophe Marin 2009-07-07 21:52:59 UTC
*** Bug 191198 has been marked as a duplicate of this bug. ***
Comment 23 Kanwar Plaha 2009-07-07 23:01:27 UTC
This bug adds images to Composer window only. It is not added to Signature template.

Please go to Settings -> Configure Kmail... -> Identities -> Edit Identity "" -> Signature tab -> Enable Signature -> Use HTML. This window/dialog does not allow images to be embedded as part of the signature.

Please reopen bug 191198. Thank you.