Bug 88084 - using QWaitCondition in update thread is bad
Summary: using QWaitCondition in update thread is bad
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: unspecified Linux
: HI normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-26 00:38 UTC by Andrew Walker
Modified: 2004-09-13 20:56 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Walker 2004-08-26 00:38:20 UTC 
Version:           0.99(devel) (using KDE KDE 3.2.1)
OS:                Linux

using QWaitCondition in update thread is bad
it's broken in all but the most recent Qt releases
Comment 1 Andrew Walker 2004-09-03 18:51:59 UTC 
Some more information on this problem would be good.
Note: this problem was originally noted by George, but 
was not submitted as a bug report.
Comment 2 George Staikos 2004-09-13 20:56:28 UTC 
CVS commit by staikos: 

Let's see how unportable this is.  Keep our own fork of QWaitCondition around.
CCMAIL: 88084-done@bugs.kde.org


  A            kstwaitcondition.h   1.1 [QPL QPL (part of Qt)]
  A            kstwaitcondition_unix.cpp   1.1 [QPL QPL (part of Qt)]
  M +1 -0      Makefile.am   1.143
  M +3 -2      updatethread.h   1.5


--- kdeextragear-2/kst/kst/Makefile.am  #1.142:1.143
@@ -44,4 +44,5 @@
         kstiface.skel \
         kstiface_impl.cpp \
+        kstwaitcondition_unix.cpp \
         kstdatadialog.ui \
         draggablelistbox.cpp \

--- kdeextragear-2/kst/kst/updatethread.h  #1.4:1.5
@@ -21,5 +21,6 @@
 #include <qmutex.h>
 #include <qthread.h>
-#include <qwaitcondition.h>
+
+#include "kstwaitcondition.h"
 
 class KstDoc;
@@ -42,5 +43,5 @@ class UpdateThread : public QThread {
   private:
     bool _paused, _done;
-    QWaitCondition _waitCondition;
+    KstWaitCondition _waitCondition;
     QMutex _statusMutex;
     KstDoc *_doc;