Bug 88053 - Konqueror opens frames in seperate windows on www.helo.hanze.nl
Summary: Konqueror opens frames in seperate windows on www.helo.hanze.nl
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-25 19:35 UTC by starbase218
Modified: 2004-09-19 13:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
xsession-errors log with http://demo.mbank.com.pl/index2.html (95.12 KB, text/plain)
2004-09-08 14:19 UTC, Marek Lotke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description starbase218 2004-08-25 19:35:02 UTC
Version:            (using KDE KDE 3.3.0)
Installed from:    Unlisted Binary Package
OS:                Linux

www.helo.hanze.nl is a website with frames. When visiting this site with Konqueror, it loads normally at first, but then opens another 3 windows, each containing one of the frames.
Comment 1 starbase218 2004-08-25 20:43:29 UTC
O, I should probably mention that I've change the file association for text/html: I've moved Konqueror to the top of the list, so that it's the default app for this filetype.

When I move KWrite to the top again, Konqueror gives three open/save dialogs (again, one for each frame) instead of opening additional windows.
Comment 2 Braden MacDonald 2004-08-26 06:25:29 UTC
hmm... I don't notice this behavior in just loading the page (kde 3.3.0), but when I click on any of the links at the top, I do get an extra window opening with the navigation links in it (this should be loading in the left frame). This doesn't seem to be konqueror's fault, though; the site uses the following javaScript:
  window.open('left.asp?menuID=' + menuID, 'left');

Internet Explorer and Mozilla both seem to interpret this to mean "open this URL in the frame 'left'", but I think the standard way should be to open a new window named 'left', as konqueror does. I think the authors should use:
  parent.left.location='left.asp?menuID=' + menuID;

It should be noted that the home page specifically says the site is designed for IE and not mozilla/konqueror/etc.

_______________
If I'm on the completely wrong track above, you could make sure that you have 'Show file in embedded viewer' selected for the text/html MIME type.
Comment 3 starbase218 2004-08-30 12:36:13 UTC
I talked to some people on #kde-nl, and they also didn't experience the problem. However, I just installed SUSE 9.1 (instead of Arch Linux, which was my previous distro) and after upgrading to KDE 3.3, I had the same problem again.

When I click on one of the links at the top of the page, I get the same behaviour: Konqueror opens three windows which all contain a frame of the new page, and the original page doens't change.

Although the site says it's designed for IE, Konqueror in KDE 3.2 (and also 3.1 IIRC) gave no problems at all.
Comment 4 Marek Lotke 2004-09-03 22:47:45 UTC
I have another example of konqueror opening new windows. Navigating through left side of demo.mbank.com.pl always opens new window. It used to work well on kde 3.2. 
I run gentoo built using gcc 3.4.1.
I don't care for the demo but it happens on real bank site too ;)
Comment 5 Marek Lotke 2004-09-08 14:17:38 UTC
Attached xsession-errors log created during openning page  http://demo.mbank.com.pl/index2.html (kdelibs, kdebase compiled with debug)
How can I help solve this bug?
Comment 6 Marek Lotke 2004-09-08 14:19:08 UTC
Created attachment 7452 [details]
xsession-errors log with http://demo.mbank.com.pl/index2.html
Comment 7 Marek Lotke 2004-09-13 11:42:28 UTC
I compiled kdelibs and kdebase from 040910 development tarballs. Looks like it is fixed now! Any chance to find out which patch did it? I could forward it then to gentoo developers. Thanks!
Comment 8 Marek Lotke 2004-09-17 11:17:12 UTC
I've been browsing webcvs. Applied this patch
http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdebase/konqueror/konq_mainwindow.cc.diff?r1=1.1342.2.4&r2=1.1342.2.5
on kdebase-3.3.0 and it works!
Description of the patch:
Backport
" Regression fix for  KParts::BrowserHostExtension::findFrameParent, find the
  callingPart from the signal's sender instead of using 0.
  Fixes window.open(newurl, "frame") to open in 'frame' and not in new window."
fix
Thanks!
Comment 9 starbase218 2004-09-19 13:19:57 UTC
Great, thnx. I don't have time to test it here yet, but I'll close the BR for now. If the bug still persists on my system after applying the patch, I'll re-open it.

Tnx again :).