Bug 87875 - unqualified hosts no longer allowed in proxy configuration
Summary: unqualified hosts no longer allowed in proxy configuration
Status: RESOLVED FIXED
Alias: None
Product: kcontrol
Classification: Miscellaneous
Component: kcmproxy (show other bugs)
Version: 3.3
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 89175 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-23 22:17 UTC by crozierm
Modified: 2004-09-15 03:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
fix typo (1016 bytes, patch)
2004-08-25 02:06 UTC, Dawit Alemayehu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description crozierm 2004-08-23 22:17:58 UTC
Version:           3.3 (using KDE KDE 3.3.0)
Installed from:    Debian testing/unstable Packages
OS:                Linux

In previously versions of konqueror, hosts not fully qualified with a domain could be added to the "do not proxy for" list.  As of version 3.3, when I attempt to add just the hostname, rather than hostname.domain.com, I get a error dialog with the following message:

The address you have entered is not valid

Interestingly, there are two unqualified hostnames that are accepted: "host" and "hostname".
Comment 1 crozierm 2004-08-23 22:18:53 UTC
P.S.  I can manually add the unqualified hostnames in kioslaverc, which works properly.
Comment 2 Dawit Alemayehu 2004-08-25 02:06:02 UTC
Created attachment 7263 [details]
fix typo

Hello,

This is partially a bug and partially a feature. In 3.3 the proxy config dialog
performs URL validation by passing your input is through the URI filters.
Unfortunately a bug in the uri filters code hid the problem you mentioned above
which is caused by a typo. Unqualified hostnames are valid so long as they are
within your own domain, i.e. the resolver can resolve them. For example, if
your fully qualified hostname is "konq.foo.bar", then entering konq should be
fine since it can be correctly resolved by KDE's IO subsystem. Anyways, the
attached should fix the typo. If you are unable to apply the patch, then the
fix will be in the 3.3.1 release.

Thanks for the report.
Comment 3 Dawit Alemayehu 2004-08-25 02:11:10 UTC
CVS commit by adawit: 

- Backport typo fix.

CCMAIL: 87875-done@bugs.kde.org


  M +2 -2      kmanualproxydlg.cpp   1.27.2.1


--- kdebase/kcontrol/kio/kmanualproxydlg.cpp  #1.27:1.27.2.1
@@ -2,5 +2,5 @@
    kmanualproxydlg.cpp - Proxy configuration dialog
 
-   Copyright (C) 2001,02,03 - Dawit Alemayehu <adawit@kde.org>
+   Copyright (C) 2001-2004 Dawit Alemayehu <adawit@kde.org>
 
    This library is free software; you can redistribute it and/or
@@ -412,5 +412,5 @@ bool KManualProxyDlg::isValidURL( const 
     
     QStringList filters;
-    filters << "kshorturifilter" << "localdomainfilter";
+    filters << "kshorturifilter" << "localdomainurifilter";
     
     // If the typed URL is malformed, and the filters cannot filter it


Comment 4 Dawit Alemayehu 2004-09-15 03:54:55 UTC
*** Bug 89175 has been marked as a duplicate of this bug. ***