Bug 87490 - Translated named colors break the color selection (kcolorchooser)
Summary: Translated named colors break the color selection (kcolorchooser)
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kdeui (show other bugs)
Version: 3.3
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-19 10:44 UTC by gerard
Modified: 2011-07-26 12:37 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gerard 2004-08-19 10:44:02 UTC
Version:           inconnu (using KDE 3.3.0, compiled sources)
Compiler:          gcc version 3.3.2 (Mandrake Linux 10.0 3.3.2-6mdk)
OS:                Linux (i686) release 2.6.3-7mdk-i686-up-4GB

Many many problems in kcoolorchooser
1° there is no bugreport button
2° when using bugreport system, this program does not appear in the list
3° the help button leads to nothing
4° There is a question mark for "What's this" help, but no help exists anywhere
5° (the worst) the translation mechanism of the named colors broke the ability to choose a color. When you choose a translated color, it is black.
6° the list of the translatable colors in incomplete

All of these are important, but 5 and 6 are the most.

Thanks

Gerard
Comment 1 Nicolas Goutte 2004-08-20 10:31:37 UTC
Point 5 is done (not in KDE 3.3.)

Point 6 can only be done by using the rgb.txt of X.org. However putting it in kdelibs potentially creates a conflict with the licenses allowed in kdelibs. (I have not checked and I do not know exactly the X.org license (neither the old XFree one, where the file comes from.))

Have a nice day!
Comment 2 gerard 2004-08-20 11:59:08 UTC
Thanks for fixing point 5
********
NEW
Point 7: the window is not resizable. Should more comfortable to display a long list of colors, and more consistent with other KDE windows. (wish)
********
About point 6, I don't understand some things.
The actual pot file contains 223 colors
Kcolorchooser contains about 400
rgb.tx contains about 705

I cannot explain why rgb.txt has more entries than Kcolorchooser. I Thought Kcolorchooser took dynamically its list in rgb.txt

In rgb.txt, many colors are duplicated (YellowGreen / yellow green). Is one enough ? Which one ? any ?

Should we add some entries in the pot file until 400 or until 705 ? In any case, it would be easier to use a script to do it.

Not sure rgb.txt should be in kdelibs.

The problem is the same with timezones : we simply add manually the new entries in pot file.
Comment 3 Nicolas Goutte 2004-08-20 13:17:30 UTC
On Friday 20 August 2004 11:59, gerard@delafond.org wrote:
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug, or are watching someone who is.
>
> http://bugs.kde.org/show_bug.cgi?id=87490
>
>
>
>
> ------- Additional Comments From gerard delafond org  2004-08-20 11:59
> ------- Thanks for fixing point 5
> ********
> NEW
> Point 7: the window is not resizable. Should more comfortable to display a
> long list of colors, and more consistent with other KDE windows. (wish)
> ********
> About point 6, I don't understand some things.
> The actual pot file contains 223 colors
> Kcolorchooser contains about 400
> rgb.tx contains about 705
>
> I cannot explain why rgb.txt has more entries than Kcolorchooser. I Thought
> Kcolorchooser took dynamically its list in rgb.txt
>
> In rgb.txt, many colors are duplicated (YellowGreen / yellow green). Is one
> enough ? Which one ? any ?

Colours with spaces are skipped. Colours containing "grey" or "gray" are 
skipped too.

>
> Should we add some entries in the pot file until 400 or until 705 ? In any
> case, it would be easier to use a script to do it.
>
> Not sure rgb.txt should be in kdelibs.
>

> The problem is the same with timezones : we simply add manually the new
> entries in pot file.

No, it is not the same problem. Currently the colors are created from rgb.txt, 
however from the version on Scripty's computer, which has seen is not the 
version of X.org (or the corresponding version of XFree.)

Have a nice day!

Comment 4 Nicolas Goutte 2004-08-25 21:37:58 UTC
KColorChooser is not in kdelibs (or I would have moved the bug myself.)

As the problems in kdelibs, they are the minority in this bug.

Have a nice day!

On Tuesday 24 August 2004 21:44, Stephan Binner wrote:
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug, or are watching someone who is.
>
> http://bugs.kde.org/show_bug.cgi?id=87490
> binner kde org changed:
>
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- AssignedTo|bastian kde org             |coolo kde org
>             Product|kde                         |kdelibs

Comment 5 Nicolas Goutte 2005-01-17 11:45:06 UTC
CVS commit by goutte: 

Use the x.org's rgb.txt as base for the translations
CCBUG:87490


  M +5 -6      Makefile.am   1.4
  M +1 -3      README   1.2
  R            colors.cpp   1.1


--- kdelibs/kdeui/colors/Makefile.am  #1.3:1.4
@@ -1,11 +1,10 @@
-colors:
-        : > $(srcdir)/colors.cpp
+
+messages:
+        : > colors.cpp
         list=`grep '^[0-9]' /usr/X11R6/lib/X11/rgb.txt  | tr '  ' ' ' | sed -e "s#^[0-9]* [0-9]* [0-9]* *##" | grep -v " " | grep -v gray | grep -v grey | LC_ALL=C sort -u` ;\
         for i in $$list; do \
-                echo "i18n(\"color\", \"$$i\");" | sed -e "s#!# #g" >> $(srcdir)/colors.cpp ;\
+                echo "i18n(\"color\", \"$$i\");" | sed -e "s#!# #g" >> colors.cpp ;\
         done
-
-messages:
         $(XGETTEXT) colors.cpp -o $(podir)/kdelibs_colors.pot
+        -rm -f colors.cpp
 
-.PHONY: colors

--- kdelibs/kdeui/colors/README  #1.1:1.2
@@ -1,4 +1,2 @@
-I put colors.cpp here, so that I can have a Makefile.am and ergo
-an own pot file for that subdir. But it's not supposed to be compiled
-at all
+The rgb.txt comes from x.org (xc/programs/rgb/rgb.txt)
 


Comment 6 Nicolas Goutte 2005-01-17 11:58:00 UTC
On Saturday 15 January 2005 21:58, Nicolas Goutte wrote:
> On Saturday 15 January 2005 15:21, G
Comment 7 lexual 2010-01-23 10:51:33 UTC
Is this still relevant to recent KDE version?
If not please close the bug.

Thanks,

Lex.
Comment 8 gerard 2010-01-24 19:56:55 UTC
Well... Not really many bugfixes on this program.

Translated named colors work now, but still no help, no resizable window...

I have no problem with spaces nor with grey names.

Thanks
Comment 9 Burkhard Lück 2011-06-18 14:58:35 UTC
see also for possible duplicates of some issues reported here:

https://bugs.kde.org/show_bug.cgi?id=275976

https://bugs.kde.org/show_bug.cgi?id=275977
Comment 10 Maciej Pilichowski 2011-06-18 16:03:12 UTC
Could someone fix the mess with this report -- one report = one issue. Here it is not the case, so it is best to close it as INVALID, or focus only one ONE issue which is I believe point 6, which is fixed (correct?) thus this report can be closed as FIXED.
Comment 11 Burkhard Lück 2011-06-20 21:57:50 UTC
To summarize the handling of this report:
1° there is no bugreport button
Confirmed in 4.7.0, dup of https://bugs.kde.org/show_bug.cgi?id=275977
2° when using bugreport system, this program does not appear in the list
Confirmed in 4.7.0, https://bugs.kde.org/show_bug.cgi?id=250467, closed with resolved/invalid
3° the help button leads to nothing
No Help button in 4.7.0
4° There is a question mark for "What's this" help, but no help exists anywhere
Confirmed in 4.7.0
5° (the worst) the translation mechanism of the named colors broke the ability to choose a color. When you choose a translated color, it is black.
Fixed
6° the list of the translatable colors in incomplete
Fixed
7° the window is not resizable.
Confirmed in 4.7.0, dup of https://bugs.kde.org/show_bug.cgi?id=275976
Comment 12 Christoph Feck 2011-07-26 12:37:49 UTC
The bug as it is reported is fixed by comment #5.