Bug 87332 - Updating statusbar while changing tag
Summary: Updating statusbar while changing tag
Status: RESOLVED FIXED
Alias: None
Product: juk
Classification: Applications
Component: general (show other bugs)
Version: 2.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-17 03:45 UTC by Hasso Tepper
Modified: 2004-10-02 08:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hasso Tepper 2004-08-17 03:45:48 UTC
Version:           2.1 (using KDE 3.3.0, compiled sources)
Compiler:          gcc version 3.3.4 (Debian 1:3.3.4-7)
OS:                Linux (i686) release 2.6.7-ipv6conntrack

When changing and saving tag (artist or track name) of currently playing song info in statusbar isn't updated. It would be nice, because in case of long names it might be the only instant visible feedback for user.
Comment 1 Michael Pyne 2004-10-02 07:59:03 UTC
CVS commit by mpyne: 

Fix bug 87332 (Statusbar doesn't update when changing tags of playing item).

Will backport to 3.3

CCMAIL:87332@bugs.kde.org


  M +2 -0      juk.cpp   1.226
  M +1 -1      statuslabel.h   1.19


--- kdemultimedia/juk/statuslabel.h  #1.18:1.19
@@ -34,5 +34,4 @@ public:
     virtual ~StatusLabel();
     virtual void updateCurrent();
-    virtual void updateData();
 
 public slots:
@@ -43,4 +42,5 @@ public slots:
     void setItemTotalTime(int time) { m_itemTotalTime = time; }
     void setItemCurrentTime(int time) { m_itemCurrentTime = time; updateTime(); }
+    virtual void updateData();
 
 signals:

--- kdemultimedia/juk/juk.cpp  #1.225:1.226
@@ -100,4 +100,6 @@ void JuK::setupLayout()
 
     m_statusLabel = new StatusLabel(m_splitter->playlist(), statusBar());
+    connect(CollectionList::instance(), SIGNAL(signalCollectionChanged()),
+            m_statusLabel, SLOT(updateData()));
     statusBar()->addWidget(m_statusLabel, 1);
     PlayerManager::instance()->setStatusLabel(m_statusLabel);


Comment 2 Michael Pyne 2004-10-02 08:02:39 UTC
CVS commit by mpyne: 

Fix bug 87332 (Statusbar doesn't update after changing tags of the playing item) in KDE 3.3.

CCMAIL:87332-done@bugs.kde.org


  M +2 -0      juk.cpp   1.214.2.4
  M +1 -1      statuslabel.h   1.18.2.1


--- kdemultimedia/juk/juk.cpp  #1.214.2.3:1.214.2.4
@@ -95,4 +95,6 @@ void JuK::setupLayout()
 
     m_statusLabel = new StatusLabel(m_splitter->playlist(), statusBar());
+    connect(CollectionList::instance(), SIGNAL(signalCollectionChanged()),
+            m_statusLabel, SLOT(updateData()));
     statusBar()->addWidget(m_statusLabel, 1);
     PlayerManager::instance()->setStatusLabel(m_statusLabel);

--- kdemultimedia/juk/statuslabel.h  #1.18:1.18.2.1
@@ -34,5 +34,4 @@ public:
     virtual ~StatusLabel();
     virtual void updateCurrent();
-    virtual void updateData();
 
 public slots:
@@ -43,4 +42,5 @@ public slots:
     void setItemTotalTime(int time) { m_itemTotalTime = time; }
     void setItemCurrentTime(int time) { m_itemCurrentTime = time; updateTime(); }
+    virtual void updateData();
 
 signals: