Bug 87056 - black 1 pixel border on the upper and left side of Flash plugin
Summary: black 1 pixel border on the upper and left side of Flash plugin
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: nspluginviewer (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: George Staikos
URL:
Keywords:
: 89540 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-12 19:50 UTC by Thomas Zell
Modified: 2004-09-19 17:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Screenshot displaying the bug (204.83 KB, image/png)
2004-08-24 19:13 UTC, Toni Suokas 		Details
Patch to fix the bug (647 bytes, patch)
2004-09-19 02:34 UTC, felixhaedicke 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zell 2004-08-12 19:50:20 UTC 
Version:            (using KDE KDE 3.3.0)
Installed from:    SuSE RPMs
OS:                Linux

In all cases I have checked so far, a black 1 pixel border appears on the upper and left side of a Flash movie embedded in a web page.

I use the KDE 3.3 RC RPM packages provided by SuSE. The libflashplayer.so version is "Shockwave Flash 6.0 r79".
Comment 1 Toni Suokas 2004-08-24 19:12:40 UTC 
I confirm this. Same behaviour with Flash 7.0.25 and KDE 3.3.0. This bug introduced itself in the KDE 3.3.0 RC2, beta2 did not have this problem.

The black borders are exactly the same that Mozilla browsers had for a _long_ time when compiled against GTK2. Firefox 0.9.3 doesn't have this problem, so they have finally fixed it somewhere along the line. I'm guessing their bugzilla can provide more insight into the cause of the problem.
Comment 2 Toni Suokas 2004-08-24 19:13:47 UTC 
Created attachment 7253 [details]
Screenshot displaying the bug
Comment 3 felixhaedicke 2004-09-19 02:34:46 UTC 
Created attachment 7574 [details]
Patch to fix the bug

Attached a patch which fixes the bug for me.

I looked at the Mozilla patch (Mozilla had the same bug) which can be found
here:
http://bugzilla.mozilla.org/show_bug.cgi?id=207036

The patch just gave me hints how to hack the kde code. So I am not a
programmer. I don't know why it workes now.
Comment 4 George Staikos 2004-09-19 12:47:50 UTC 
CVS commit by staikos: 

We already had this property, but maybe it needed to be set earlier.  Does 
this help?

CCMAIL: 87056@bugs.kde.org


  M +2 -2      nsplugin.cpp   1.112


--- kdebase/nsplugins/viewer/nsplugin.cpp  #1.111:1.112
@@ -531,7 +531,8 @@ NSPluginInstance::NSPluginInstance(NPP p
    // create drawing area
    Arg args[7];
-   Cardinal nargs=0;
+   Cardinal nargs = 0;
    XtSetArg(args[nargs], XtNwidth, width); nargs++;
    XtSetArg(args[nargs], XtNheight, height); nargs++;
+   XtSetArg(args[nargs], XtNborderWidth, 0); nargs++;
 
    String n, c;
@@ -552,5 +553,4 @@ NSPluginInstance::NSPluginInstance(NPP p
    XtSetArg(args[nargs], XtNdepth, QPaintDevice::x11AppDepth()); nargs++;
    XtSetArg(args[nargs], XtNcolormap, QPaintDevice::x11AppColormap()); nargs++;
-   XtSetArg(args[nargs], XtNborderWidth, 0); nargs++;
    XtSetValues(_form, args, nargs);
    XSync(qt_xdisplay(), false);
Comment 5 felixhaedicke 2004-09-19 15:24:09 UTC 
Yes, this fixes the bug.
Comment 6 Maksim Orlovich 2004-09-19 16:43:24 UTC 
*** Bug 89540 has been marked as a duplicate of this bug. ***
Comment 7 George Staikos 2004-09-19 17:31:16 UTC 
*** Bug has been marked as fixed ***.