Bug 86892 - tag editor forgets comments
Summary: tag editor forgets comments
Status: RESOLVED FIXED
Alias: None
Product: juk
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-10 10:06 UTC by Michael Daum
Modified: 2004-08-23 05:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Daum 2004-08-10 10:06:22 UTC
Version:           2.0.2 (using KDE 3.2.3,  (3.1))
Compiler:          gcc version 3.3.4 (Debian 1:3.3.4-7)
OS:                Linux (i686) release 2.6.6

Hi,

when switching the desktop in the middle of a comment editing
(without saving it before switching the desktop) and comming
back to the juk tag editor shows an empty comment text field.

	Micha.
Comment 1 Scott Wheeler 2004-08-10 10:41:33 UTC
This is fixed in TagLib 1.2.

*** This bug has been marked as a duplicate of 82898 ***
Comment 2 Michael Daum 2004-08-10 11:05:02 UTC
Hi Scott,

actually I am using libtag1-1.2-1 from debian/unstable and the problem
is still there. Why should that be related to tablib? I did not commit
the comment text to the mp3 file. I simply switched to another desktop.
Comming back to juk it refreshes its X11 appearance with an _empty_
comment text. This is gui related, don't you think so?

	Micha.
Comment 3 Scott Wheeler 2004-08-10 11:12:28 UTC
D'oh, sorry.  That's what I get for processing bugs right after waking up.  ;-)

I can reproduce this as well.
Comment 4 Michael Pyne 2004-08-23 05:11:06 UTC
CVS commit by mpyne: 

Fix bug 86892, where the tag editor loses changes you make whenever you hide the tag editor
widget.

CCMAIL:86892@bugs.kde.org


  M +5 -2      tageditor.cpp   1.69


--- kdemultimedia/juk/tageditor.cpp  #1.68:1.69
@@ -176,4 +176,6 @@ void TagEditor::slotSetItems(const Playl
     if(isVisible())
         slotRefresh();
+    else
+        m_collectionChanged = true;
 }
 
@@ -760,8 +762,9 @@ void TagEditor::addItem(const QString &t
 void TagEditor::showEvent(QShowEvent *e)
 {
-    if(m_collectionChanged)
+    if(m_collectionChanged) {
         updateCollection();
-
     slotRefresh();
+    }
+
     QWidget::showEvent(e);
 }


Comment 5 Michael Pyne 2004-08-23 05:17:33 UTC
CVS commit by mpyne: 

Backport fix for 86892 (tag editor forgets comments) to KDE 3.3.

CCMAIL:86892-done@bugs.kde.org


  M +5 -2      tageditor.cpp   1.68.2.1


--- kdemultimedia/juk/tageditor.cpp  #1.68:1.68.2.1
@@ -176,4 +176,6 @@ void TagEditor::slotSetItems(const Playl
     if(isVisible())
         slotRefresh();
+    else
+        m_collectionChanged = true;
 }
 
@@ -760,8 +762,9 @@ void TagEditor::addItem(const QString &t
 void TagEditor::showEvent(QShowEvent *e)
 {
-    if(m_collectionChanged)
+    if(m_collectionChanged) {
         updateCollection();
-
     slotRefresh();
+    }
+
     QWidget::showEvent(e);
 }