Version: (using KDE KDE 3.2.3) Installed from: Gentoo Packages The defined icon size for "Small Icons" (16 pixels) are too small for displays with DPI or 100 or higher... It should be possible to configure the icon size as we can do with others, in kcm. Right now the only way is to hand-edit kdeglobals. Also, icons in the mens are scaled and become blurred. I'm using 22px icons, the applications should come with, at least, 16, 22 and 32px icons. Looking at the default CrystalSVG I see that only few does (share/icons/crystalsvg/22x22/apps = 23 icons, share/icons/crystalsvg/22x22/apps = 297 icons). Also related to icon size, when you want to alter an icon for an application, the push button that display the current icon is displaying just partial data, (I'm using 128px icons in the desktop).
Created attachment 6915 [details] Menu with 22px icons Look at the icons under "All aplications", they're bad. They're scaled and blurred. Now Look at the icons under "Actions", they're ok since there's support for them in the iconset. KDE should recommend applications to have icons with 16, 22 and 32 pixels, at least.
Created attachment 6916 [details] Pushbutton displays large icons wrong This show that the push button is displaying large icons wrong
Created attachment 7056 [details] Correct wrong icon size in KPropertiesDialog This will make icons scale to button size. It's a one line patch. I tested with desktop icons from 32px up to 128px and they look good. Could you please apply?
Ok, 3.3 released, could someone commit the patch?
CVS commit by waba: Always show a 48 pixel icon in the propertiesdialog, regardless of the actual size used for desktop icons. (BR86257) CCMAIL: 86257-done@bugs.kde.org M +2 -1 kpropertiesdialog.cpp 1.314.2.3 --- kdelibs/kio/kfile/kpropertiesdialog.cpp #1.314.2.2:1.314.2.3 @@ -790,4 +790,5 @@ KFilePropsPlugin::KFilePropsPlugin( KPro int bsize = 66 + 2 * iconButton->style().pixelMetric(QStyle::PM_ButtonMargin); iconButton->setFixedSize(bsize, bsize); + iconButton->setIconSize(48); iconButton->setStrictIconSize(false); // This works for everything except Device icons on unmounted devices @@ -815,5 +816,5 @@ KFilePropsPlugin::KFilePropsPlugin( KPro int bsize = 66 + 2 * iconLabel->style().pixelMetric(QStyle::PM_ButtonMargin); iconLabel->setFixedSize(bsize, bsize); - iconLabel->setPixmap( DesktopIcon( iconStr ) ); + iconLabel->setPixmap( KGlobal::iconLoader()->loadIcon( iconStr, KIcon::Desktop, 48) ); iconArea = iconLabel; }
Waldo, Fixing it to 48 is not a good solution. Even more if you're using the numeric value instead of a variable/define... it may cause more problems in future. Why not use my patch, which use the bsize, that is, the button size?
The button size is fixed anyway, so that doesn't make any real difference. I didn't use bsize because it keeps very little margin which looks rather ugly.
If the problem is the margin, you can put a margin your self, in pixels or percentage. If the problem is to keep at a know size (32,48,64,...) round bsize to the smaller know value. But I still think it may bring problems in future as DPI grows, the dialog changes and this problem may appear again. Anyway, it's fixed now, thanks! Gustavo
Waldo, bad news... If you have "double-sized pixels" enabled it will overflow the button! Could you fix it?
No, I can't. I think this whole "double-sized pixels" thing is a broken concept. If the user needs large icons he should be able to specify a larger icon size and then the icon loader can do whatever magic it has to do to get them at that size.
Sure. So let's wait for it to be removed.
Reading the comments above, it seems that, even with code commits, wider concept changes need to be investigated for it to be fully satisfied, which cannot be done in the KDE 3.x framework. Such concepts should be considered in the design of KDE 4 though.