Bug 85629 - warning: Valgrind's pthread_cond_destroy is incomplete
Summary: warning: Valgrind's pthread_cond_destroy is incomplete
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 2.1.2
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-21 16:34 UTC by Peter Seiderer
Modified: 2005-01-19 01:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Patch 1 (2.21 KB, patch)
2004-07-21 16:36 UTC, Peter Seiderer 		Details
Patch 2 (6.03 KB, patch)
2004-07-21 16:37 UTC, Peter Seiderer 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Seiderer 2004-07-21 16:34:08 UTC 
Hello,
 
calling pthhread_cond_destroy under valgrind-2.1.2-CVS gives
 
==3119== warning: Valgrind"s pthread_cond_destroy is incomplete
==3119==          (it doesn"t check if the cond is waited on)
==3119==          your program may misbehave as a result
 
 
The attached patch implements this missing check by counting
the number of threads waiting on the specified condition (using
"vg_pthread_cond_t.__vg_c_waiting").
 
The patch works for me (and the two short testprogramms in the second
attachement), hope I did not miss something...
 
Peter
Comment 1 Peter Seiderer 2004-07-21 16:36:49 UTC 
Created attachment 6760 [details]
Patch 1
Comment 2 Peter Seiderer 2004-07-21 16:37:27 UTC 
Created attachment 6761 [details]
Patch 2
Comment 3 Jeremy Fitzhardinge 2005-01-19 01:05:37 UTC 
CVS HEAD valgrind now uses system libpthread, so this bug is moot.