Version: (using KDE Devel) Compiler: gcc 3.3.1 OS: Linux KOffice and kdelibs have both named coulours but their name are different. Also kdelibs's ones have the I18N context "color" while KOffice's have none. It would reduce the translators work if the nearly-matching names were unified and that the context "color" was added. (Both has to be done in KOffice.) The named colours in KOffice are in koffice/lib/kofficeui/tkcoloractions.cpp the ones of kdelibs are defined for KDE in kdelibs/kdeui/colors/colors.cpp Have a nice day!
Created attachment 7400 [details] bug88567.diff tried to unify the nearly-matching names, also added context "color" for all i18n calls just like in kdelibs/kdeui/colors/colors.cpp.
Better remove the JJ: of this bug.
Sorting the colours by the English names is not much useful. The colours are shown as a palette and the names are only tooltips (see in KPresenter.) So what counts for the user first is the colours themselves, not their names (and when translated, the English sorting order is wrong too.) Have a nice day! On Friday 03 September 2004 15:07, Martin Atukunda wrote: (...) >Created an attachment (id=7400) > --> (http://bugs.kde.org/attachment.cgi?id=7400&action=view) > bug88567.diff > > tried to unify the nearly-matching names, also added context "color" for > all i18n calls just like in kdelibs/kdeui/colors/colors.cpp.
That email should have been forwarded to bug #85567, as it contains some important information. The whole thread is archived at: http://lists.kde.org/?t=109111327600001&r=1&w=2 Have a nice day! ---------- Forwarded Message ---------- Subject: Re: Bug 85567 : color names. Need guidance Date: Thursday 29 July 2004 22:26 From: Nicolas Goutte <nicolasg@snafu.de> To: For developer's discussion about KOffice <koffice-devel@mail.kde.org> On Thursday 29 July 2004 20:24, p.stirnweiss_koffice@bluewin.ch wrote: > >-- Message original -- > > From: Nicolas Goutte <nicolasg@snafu.de> > > >To: For developer's discussion about KOffice <koffice-devel@mail.kde.org> > >Date: Thu, 29 Jul 2004 20:02:57 +0200 > >Subject: Re: Bug 85567 : color names. Need guidance > >Reply-To: For developer's discussion about KOffice > > <koffice-devel@mail.kde.org> > > > >On Thursday 29 July 2004 16:58, p.stirnweiss_koffice@bluewin.ch wrote: > >> Hello, > >> > >> I would like to look at this one also, but I do not understand > >> everything: > >> > >> " > >> The named colours in KOffice are in > >> koffice/lib/kofficeui/tkcoloractions.cpp > >> > >> the ones of kdelibs are defined for KDE in > >> kdelibs/kdeui/colors/colors.cpp > >> > >> " (...) > >As for the general question about this bug, I do not know. I am wondering > >if > >it does not need deeper changes or perhaps even a sort of support from > >kdelibs. > > Indeed, if KWord is already using KDE's color dialog, it makes more sense > to use it all over the place. Maintenance of it would be done at KDE's > level (where there is more manpower apparently), and this would be a dream > for the i18n people. Also it would be more consistent look and feel. Well, looking at the code of the color chooser, I am not sure if it has so much manpower, as it still uses functions that are considered potential security risks (like sscanf), which should not be used in KDE anymore. But yes, for the translators it has many advantages. > >In any case, I have realized in the meantime that the name of the colours > >have > >a different syntax, so I do not really know what do with it now. (But may > >be > >you would have an idea.) > > What do you mean by different syntax? The colors in kdelibs are those of rgb.txt ( /usr/X11R6/lib/X11/rgb.txt , the file is different for each X-server type and version, so only a part are really translated.) The colors selected for translation in rgb.txt are those like "DeepBlue1", names without spaces, unlike "Deep Blue 1". But KOffice's colors uses names with spaces. So a question could be: if one removes the space in the KOffice names, does that give one of the translated names in kdelibs. If not, is this color at least in a more recent version of rgb.txt: http://freedesktop.org/cgi-bin/viewcvs.cgi/xc/programs/rgb/rgb.txt?root=xorg (again only the names without space count.) And depending on the answer of the kind of such questions, we could decide the best way to use in KOffice. (Not sure if it "Junior" level anymore.) The last problem is that kdelibs does not define any named gray color, as indeed gray1 or gray100 is not really intuitive as name. That is more or less the base of the problem. At code level it is surely a "Junior" level. But at deciding how to procede perhaps not anymore. > Pierre Have a nice day! > >> Thanks, > >> > >> Pierre > > > >Have a nice day! > > > >> _______________________________________________ > >> koffice-devel mailing list > >> koffice-devel@mail.kde.org > >> https://mail.kde.org/mailman/listinfo/koffice-devel > > > >_______________________________________________ > >koffice-devel mailing list > >koffice-devel@mail.kde.org > >https://mail.kde.org/mailman/listinfo/koffice-devel > > _______________________________________________ > koffice-devel mailing list > koffice-devel@mail.kde.org > https://mail.kde.org/mailman/listinfo/koffice-devel _______________________________________________ koffice-devel mailing list koffice-devel@mail.kde.org https://mail.kde.org/mailman/listinfo/koffice-devel -------------------------------------------------------
CVS commit by goutte: Changing the KOffice colour names to be more like the named colours of kdelibs ("color" context, based on x.org's rgb.txt, composed colors with upper case letters without space) Note: there are still differences compared to x.org's rgb.txt named colours, as the KOffice colours are still always starting with an upper case letter and also some colours do not seem to be in rgb.txt. This remains a TODO. CCMAIL:kde-i18n-doc@kde.org CCBUG:85567 M +148 -147 tkcoloractions.cpp 1.32
CVS commit by goutte: Change also the colours of KoToolButton to be like named colours of kdelibs CCBUG:85567 But the question is: why was this file not compiled? CCMAIL:koffice-devel@kde.org M +3 -1 Makefile.am 1.78 M +145 -145 kotoolbutton.cc 1.11
What's the status of this bug? Did the commits 3 years back fix it?
All this code has disappeared from KOffice altogether -- let's close the bug.