Bug 85354 - Modifications to plot without plot dialog do not cause prompt for save on kst close
Summary: Modifications to plot without plot dialog do not cause prompt for save on kst...
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.x
Platform: RedHat Enterprise Linux Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-17 00:02 UTC by Rick Chern
Modified: 2004-07-24 18:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Chern 2004-07-17 00:02:20 UTC
Version:           0.99-devel (using KDE KDE 3.2.1)
Installed from:    RedHat RPMs
Compiler:          gcc (GCC) 3.3.2 20031022 (Red Hat Linux 3.3.2-1) 
OS:                Linux

After modifying a plot without opening the plot dialog, no prompting for save occurs when kst is closed.

How to reproduce:
- start kst
- load a kst file containing a plot
- without opening the plot dialog, do any of the following
    - zoom/scroll with keyboard/mouse
    - remove curves with context menu
    - create a custom label
- select File->Close, File->Quit, or click X on the kst window. 

The kst document is closed without warning.

Expected Behaviour:
The prompt for save dialog should appear, at least for actions other than zoom/scroll.
Comment 1 George Staikos 2004-07-24 18:36:42 UTC
CVS commit by staikos: 

setModified on a few more cases.  We will just have to fix these one at a time
as we come across them.  The fix is easy:
KstApp::inst()->document()->setModified();

also some minor cleanup (remove obsolete optimization)
CCMAIL: 85354-done@bugs.kde.org


  M +2 -2      datawizard.ui.h   1.64
  M +1 -0      kst.cpp   1.195
  M +12 -10    kst2dplot.cpp   1.176
  M +1 -1      kst2dplot.h   1.73
  M +4 -5      kstlabeldialog_i.cpp   1.14