Bug 85351 - Log window appears without "Show log" checkbox checked
Summary: Log window appears without "Show log" checkbox checked
Status: RESOLVED WORKSFORME
Alias: None
Product: kppp
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Harri Porten
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-16 23:25 UTC by Adam
Modified: 2023-01-05 05:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Log window appears without "Show log" checkbox checked [patch] (1.34 KB, patch)
2004-08-01 22:33 UTC, Ivan Vasilyev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam 2004-07-16 23:25:45 UTC
Version:            (using KDE KDE 3.2.91)
Installed from:    Gentoo Packages
Compiler:          gcc 3.2.3 and 3.4.1 
OS:                Linux

How to reproduce:

Launch kppp
Make sure that the "Show log" checkbox is not checked
Click connect
While dialing a small two button dialog appears that says Log and Cancel.
Click the "Log" button
Close the Log window
When kppp disconnects and brings up the main dialog again the "Show log" checkbox will not be checked.
Click connect the log window will appear.
If you close kppp and relaunch it the "Show log" checkbox will be checked
Comment 1 Ivan Vasilyev 2004-08-01 22:31:56 UTC
Such behaviour is exhibited because kppp keeps track of hiding debug window with Log button only. So when you close it with Close button, state in kppprc goes out of sync with what you see. Perhaps the following patch would help. It should be applied inside kppp directory and it changes debug.cpp and debug.h.
Comment 2 Ivan Vasilyev 2004-08-01 22:33:26 UTC
Created attachment 6962 [details]
Log window appears without "Show log" checkbox checked [patch]
Comment 3 Ivan Vasilyev 2004-08-02 09:42:31 UTC
Comment on attachment 6962 [details]
Log window appears without "Show log" checkbox checked [patch]

Index: debug.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kppp/debug.cpp,v
retrieving revision 1.19
diff -u -r1.19 debug.cpp
--- debug.cpp	25 Jun 2003 07:08:43 -0000	1.19
+++ debug.cpp	2 Aug 2004 07:32:40 -0000
@@ -132,6 +132,8 @@
     show();

   bool showlog = isVisible();
+  assert(p_kppp);
+  p_kppp->log->setChecked(showlog);
   gpppdata.set_show_log_window(showlog);
 }

Index: debug.h
===================================================================
RCS file: /home/kde/kdenetwork/kppp/debug.h,v
retrieving revision 1.11
diff -u -r1.11 debug.h
--- debug.h	7 Mar 2003 22:06:51 -0000	1.11
+++ debug.h	2 Aug 2004 07:32:43 -0000
@@ -29,7 +29,7 @@
 #include <qlabel.h>
 #include <qmultilineedit.h>
 #include <qpushbutton.h>
-
+#include <qcheckbox.h>

 class myMultiEdit : public QMultiLineEdit {
 public:
Comment 4 Ivan Vasilyev 2004-08-02 09:43:46 UTC
Comment on attachment 6962 [details]
Log window appears without "Show log" checkbox checked [patch]

Index: debug.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kppp/debug.cpp,v
retrieving revision 1.19
diff -u -r1.19 debug.cpp
--- debug.cpp	25 Jun 2003 07:08:43 -0000	1.19
+++ debug.cpp	2 Aug 2004 07:32:40 -0000
@@ -132,6 +132,8 @@
     show();

   bool showlog = isVisible();
+  assert(p_kppp);
+  p_kppp->log->setChecked(showlog);
   gpppdata.set_show_log_window(showlog);
 }

Index: debug.h
===================================================================
RCS file: /home/kde/kdenetwork/kppp/debug.h,v
retrieving revision 1.11
diff -u -r1.11 debug.h
--- debug.h	7 Mar 2003 22:06:51 -0000	1.11
+++ debug.h	2 Aug 2004 07:32:43 -0000
@@ -29,7 +29,7 @@
 #include <qlabel.h>
 #include <qmultilineedit.h>
 #include <qpushbutton.h>
-
+#include <qcheckbox.h>

 class myMultiEdit : public QMultiLineEdit {
 public:
Comment 5 Ivan Vasilyev 2004-08-02 09:57:27 UTC
Sorry, my first patch is obsolete. I didn't find any way to remove or replace it.
We only need to keep log checkbox in sync with its state in gpppdata. Looks like it's not necessary to track closing of log window with Close button, because user may just want to close it because he needs to cancel the connection, but not to disable log window at all.
Comment 6 Andrew Crouthamel 2018-11-02 04:20:27 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Andrew Crouthamel 2018-11-16 02:38:26 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 8 Justin Zobel 2022-12-06 00:56:59 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 9 Bug Janitor Service 2022-12-21 05:17:03 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Bug Janitor Service 2023-01-05 05:26:13 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!