Bug 85179 - Cannot change package name of class
Summary: Cannot change package name of class
Status: RESOLVED WORKSFORME
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 1.2.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-14 15:01 UTC by Florian Hackenberger
Modified: 2004-07-22 22:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Hackenberger 2004-07-14 15:01:24 UTC
Version:           1.2.1 (using KDE 3.2.1, Gentoo)
Compiler:          gcc version 3.2.3 20030422 (Gentoo Linux 1.4 3.2.3-r1, propolice)
OS:                Linux (i686) release 2.6.4-gentoo-r1

It is not possible to change the package name of a class. The file was created with Umbrello 1.1.1 and opened in Umbrello 1.2.1. I am neither able to cut the class and paste it into the package in the panel on the left, nor am I able to assign a package name to the class (because the edit field is disabled). Maybe this is just a user error, but even if it is, someone should think about how to improve the user-interface to be able to find the right option (the one which activates the package field).

Contact me if you have any questions or need the UML file for testing.

Regards,
	Florian
Comment 1 Oliver Kellogg 2004-07-22 19:58:20 UTC
> I am neither able to cut the class and paste it into the package in the panel on the left,

This should work now, could you try again with current cvs?

> nor am I able to assign a package name to the class (because the edit field is disabled).

This was done on purpose.
If the user types in a package name, what should the behaviour be?
1. If the package name already exists, then put the class into the package found?
2. If the package does not yet exist, then implicitly create a new package, and then
  put the class into the newly created package?

While (1) sounds like a good idea, there are some implementation problems with (2).
What if the user makes a typo? Then a new package with a wrong name will exist?
Comment 2 Esben Mose Hansen 2004-07-22 20:43:55 UTC
> nor am I able to assign a package name to the class (because the edit field is disabled). 
 
Dropdown box? Or simply refuse renaming to a non-existing package?
Comment 3 Florian Hackenberger 2004-07-22 20:44:56 UTC
> This should work now, could you try again with current cvs? 
I have tried it with the CVS HEAD revision and it is now working without any issues. Thank you for the quick fix!

> This was done on purpose. 
>  If the user types in a package name, what should the behaviour be? 
I see, but what about displaying the package name in the edit field, even if it is disabled. So the user would notice that package names are working, but that he has to find other means to move the class to another package (e.g. copy and paste).

Regards,
	Florian
Comment 4 Oliver Kellogg 2004-07-22 22:13:53 UTC
>  what about displaying the package name in the edit field, even if it is disabled.

Huh? That's already happening for me.
If the package name is not displaying properly for you then please give a
description of what you did so that we can reproduce the problem.