Version: (using KDE KDE 3.2.2) Installed from: Gentoo Packages The Holidays for Japan are shifted by + 1 day. For example "Umi no Hi" (Ocean's Day) should be on Monday 19th 2004, but shows up on Tuesday 20th 2004.
Am Montag, 12. Juli 2004 10:07 schrieb Clemens Schwaighofer: > The Holidays for Japan are shifted by + 1 day. Are all holidays shifted one day, or only some? > For example "Umi no Hi" (Ocean's Day) should be on Monday 19th 2004, but > shows up on Tuesday 20th 2004. Hmm, in the holiday_ja file (here it is /usr/share/apps/korganizer/holiday_ja) ocean's day is entered to occur on Juli 20 every year. Is 2004 a special year, or is there any special rule for ocean's day? Also, the equinox days are entered only up to 1996... Reinhold
well most of them are not on the correct date. I think it was entered for just some time. The Oceans Day is on 19th (acording to my wall calendar here). I will investiage this thing further and make a diff to the current calendar file.
On Monday, 12. July 2004 12:55, Clemens Schwaighofer wrote: > The Oceans Day is on 19th (acording to my wall calendar here). Hmm, okay, I googled a bit, and things are quite inconsistent: This webpage says oceans day is on July 20: http://ilc2.doshisha.ac.jp/users/kkitao/class/meta/f/anzai/Jculture.htm While this webpage says it's on the third monday of july (which would be the 19th this year): http://info.pref.fukui.jp/kokusai/tagengo/html_e/konnatoki/2seikatu/e_fuzoku/c_1.html The same goes for children's day, sports day, and several other holidays, that should appear on the n-th weekday of month Y according to the second URL. If this is really the case, the holiday_ja file should be changed to the correct holidays, which are of the form small "Oceans' Day" weekend on third monday in July (Note that weekend in that line doesn't mean it appears on a weekend, but that it should be treated like a weekend, but that setting is not used by korganizer) Reinhold
Well I think the second link is more correct as all my japanese calendars here show the the "Umi no Hi" day on the third Monday of July. Though my girlfriend insists that it is 19th of July and not always Monday. One more thing. Is there a documentation for how to create the holiday file? So I can start fixing the japanese holidays by my self.
On Monday, 12. July 2004 16:20, Clemens Schwaighofer wrote: > ------- Well I think the second link is more correct as all my japanese > calendars here show the the "Umi no Hi" day on the third Monday of July. I think so, too. I found several sites with either of the two possibilities, but the ones with third monday of july looked much more professional or official. > Though my girlfriend insists that it is 19th of July and not always Monday. Yeah, she's (always) right! But let's still change the holiday file to third monday of July ;-) > One more thing. Is there a documentation for how to create the holiday > file? No, but the holiday files are simple text files with easy-to-understand entries: [type] "Entry name" [type] on DATE_SPECIFICATION where the [type] entries can be any of small, weekend, black, red, green, etc. or completely left out. KOrganizer ignores these type settings anyway. DATE_SPECIFICATION is a more or less human readable description of the date. E.g.: 3/15 (mean March 15) first sunday in may12.10.03 length 6 19.4.01 12.10.03 length 6 (6 days starting Oct 12, 2003) sunday before december 25 minus 21 easter plus 49 days thursday after april 18 9/23/1996 november 2 easter plus 49 days length 2 days last sunday in march Cheers, Reinhold
Well I tried to change it to "... on third monday in July" but he doesn't highlight the third day of July. One more thing. One 100% correct fact is, that if a national holiday hits a Sunday, the day after (Monday) is a public holiday. Is _that_ doable in korganizer holiday files? And to be 100% sure which is correct, I'll investigate that at office tomorrow. They 100% know when what holiday is and how it is calculated.
On Monday, 12. July 2004 17:01, Clemens Schwaighofer wrote: > ------- Well I tried to change it to "... on third monday in July" but he > doesn't highlight the third day of July. Hmm, weird, that syntax is used a lot in other holiday files ... Here small "Whatever" on third monday in july highlights July 19, 2004. Ah, capitalization it is. You can't write "July", bug must use "july" > One more thing. One 100% correct fact is, that if a national holiday hits a > Sunday, the day after (Monday) is a public holiday. Is _that_ doable in > korganizer holiday files? Nope, that's not possible. We would need too rewrite the holiday plugin for that (it needs a rewrite anyway, but we just don't have the time). Reinhold -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFA8qwWTqjEwhXvPN0RAuhdAJsF3WnCAiQUXJdRhlU6EqHAKdpoJACgivU4 NzPTkClZ8oKM5jLjDE9E3E8= =1RNE -----END PGP SIGNATURE-----
okay, if I make it all small it works. Thanks for all your help. I will change all the days and post it here later.
Japanese translators, can you please check the japanese holidays file of korganizer for the correct recurrences of holidays? Thanks, Reinhold
Created attachment 8292 [details] Updated file for holiday_ja. I think that holiday_ja file is too old and incorrect on http://webcvs.kde.org/cgi-bin/cvsweb.cgi/kdepim/korganizer /plugins/holidays/holidays/holiday_ja?only_with_tag=KDE_3_3_BRANCH I attached the updated file.
CVS commit by kainhofe: New Japanese Holidays file by Toyokiro Asukai BUG: 84987 M +77 -36 holiday_ja 1.2