Version: (using KDE Devel) Installed from: Compiled sources Compiler: gcc (GCC) 3.3.3 20040412 (Gentoo Linux 3.3.3-r6, ssp-3.3.2-2, pie-8.7.6) OS: Linux in any chatwindow, if you remove the format toolbar and/or the status toolbar close the window and reopen the toolbars are back.
this is happening in current cvs. with this patch , should fix it : http://pwp.netcabo.pt/yagami/chatview.patch
On July 5, 2004 09:42 am, Iori Yagami wrote: > with this patch , should fix it : That patch is no good because then, if you hid the RTF toolbar a protocol that did not support it ( which it does automatically), it would not be there for others. The fix is a much larger one. I have known what needs to be done for a long time, I just don't know how to do it proeperly. 1. All logic for showing / hiding the RTF toolbar should be inside the RTF widget itself, not the chat window, since it is what decodes what the protocols support 2. Whether the toolbar is shown or hidden should be remembered on a per-protocol basis. (2) is easy, (1) is more difficuilt since KMainWindow does this all by itself, with the configureToolbars() KAction and applyMainWindowSettings()
Em Segunda, 5 de Julho de 2004 13:50, o Jason Keirstead escreveu: > That patch is no good because then, if you hid the RTF toolbar a protocol > that did not support it ( which it does automatically), it would not be > there for others. your the kopete developer ... i am just a by stander ... but in my opinion , this patch is correct , and what it should only do is disable the toolbar if it cant do rtf. the problem is that kopete doesnt save each window properties ( toolbars and menus , size , etc for each and only that window ). that is the problem that is missing , not the toolbar automaticly detecting if should be on or off. IT SHOULD JUST SAY WHEN OFF , NOT WHEN ON
As for the RTF toolbar, the state doesn't need to be saved. Since it can disable the toolbar if the protocol doesn't support RTF, can the toolbar not just be excluded in that case? As for the other toolbars, why not just save the state from the chat window? The other toolbars should be consistent throughout the application, regardless of which protocol is used for a certain window.
It needs to "say" both. If this is the first time you are installing Kopete, and you are using SMS or Jabber or some other protocol that supports no RTF, then the toolbar should *not* appear. It should not even be selectable. It should not appear until you choose a protocol that does have RTF, like MSN. This way, you as the user know that MSN can do RTF. If you as the user subsequently decide "I dont want this thing" and hide it, it should never automatically show for MSN again. However, if you pick IRC it should show again, otherwise you may not know it was available. But if you hide it then it should never automatically show itself again. On the other hand, if you elect to lave it showing, it should show wheneve ryou use IRC, because obviously you like to use RTF on IRC, but not MSN. In summary: The toolbar should auto-detect protocol capabilities on first use. After that, it should be remembering its state on a per-protocol basis.
Em Segunda, 5 de Julho de 2004 14:04, o Jason Keirstead escreveu: > This way, you as the user know that MSN can do RTF. i dont need a stupid waste space toolbar to know a protocol can do RTF. if i want to know , i only have to look at the menu options on that window. the toolbar should only be there when i ask it !! when i want to change some color or something. no more , no less ...
That is why when you hide it it never shows again... I don't see what the big deal is. You hide it, it never appears again unless you show it. The only difference between this and every other toolbar in KDE is that it would be per-protocol so that you could have the toolbar showing for MSN where formatting is important, and not for IRC where space is important.
Em Segunda, 5 de Julho de 2004 14:26, o Jason Keirstead escreveu: > That is why when you hide it it never shows again... yeah , but this isnt the current behaviour ... the current behaviour sucks sucks and ... well ... sucks ... it would even better than , if per protocol would be per window ( being window classefied by (my account|contact account) or in irc (irc network| nick)
I never said the current behaviour is right, quite the contrary. See above as to what needs to change.
Em Segunda, 5 de Julho de 2004 15:11, o Jason Keirstead escreveu: > I never said the current behaviour is right, quite the contrary. See above > as to what needs to change. and i say that until you get it changed , my patch makes a better behaviour than the one that is now.
You shouldn't have to hide the toolbar for every protocol, that would be rather confusing. I'd prefer a global option.
Why would it be confusing? What is better, to have to select "hide toolbar" 3 or 4 times for the whole installed lifetime of kopete ( fo rthose who don't want toolbar), or to have to select "hide toolbar" whenever you switch to IRC, then "Show toolbar" whenever you switch to MSN, for those who only want it for one? For the first class of users, it is a once time annoyance. For the second class, it is a constant annoyance.
Em Segunda, 5 de Julho de 2004 15:52, o Jason Keirstead escreveu: > What is better, to have to select "hide toolbar" 3 or 4 times for the whole > installed lifetime of kopete ( fo rthose who don't want toolbar), or to > have to select "hide toolbar" whenever you switch to IRC, then "Show > toolbar" whenever you switch to MSN, for those who only want it for one? why not making a default state property ( like default disabled ) and then it would be saved on each contact's window property ... its better to make it "window" based , than protocol based!
I dont see why. THis is going to result in both class A and class B enabling / disabling the toolbar much more often. For example you'd have to show the toolbar with every MSN contact you messaged.
Em Segunda, 5 de Julho de 2004 17:02, o Jason Keirstead escreveu: > I dont see why. THis is going to result in both class A and class B > enabling / disabling the toolbar much more often. For example you'd have to > show the toolbar with every MSN contact you messaged. what ? using per window properties : point a ) if protocol cant do rtf ... it doesnt show the toolbar point b ) if i want the toolbar to appear generally , i set it to appear in default point c ) if i dont want it to appear generally , i set it to not appear in default , and then , i may use the toolbar in just one or two contacts that i want saving "per window" properties is the best way to do it. not only do you remove this bug ... but also another bugs and wishes ( boy , does window sizes come to mind , or kinda when you dont care about pics , but there is someone that you want to see the image ( when you have more jabber or irc contacts , and only one or two msn contacts that support pics ))
How does a per protocol shown/hidden rtf toolbar work when there are tabbed chats, some of which do rtf and some don't? Is it possible to keep the current behaviour (visible but disabled) if a tab which doesn't support rtf is currently at the front?
*** This bug has been marked as a duplicate of 59080 ***