Bug 83191 - Error trying to compile a simple designer base Kde app
Summary: Error trying to compile a simple designer base Kde app
Status: RESOLVED FIXED
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: appwizard (show other bugs)
Version: 1.0.0
Platform: RedHat Enterprise Linux Linux
: HI normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-11 01:37 UTC by Raul Moratalla
Modified: 2009-01-22 23:38 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raul Moratalla 2004-06-11 01:37:09 UTC
Version:           Snapshot 04-06-09 (using KDE KDE 3.2.3)
Installed from:    RedHat RPMs
OS:                Linux

I generate with the wizard a "Simple designer based kde application". If I compile it I get an error due to an problem in main.cpp:
I have a line such this:

KAboutData::License_$LICENSE$, "(C) %{YEAR} Raul Moratalla", 0, 0,

It should be:
KAboutData::License_GPL, "(C) 2004 Raul Moratalla", 0, 0,
Comment 1 Sascha Cunz 2004-06-13 16:23:37 UTC
I have kind of fixed this already. Sadly, i lost most of that box to a filesystem crash. So it will be a day or two until i can commit it.

For other devs: It is not done by quitely changeing the $LICENSE$ to %{LICENSE} in the template. There are licenses that have no counterpart in the enum in KAboutData.
Comment 2 Brad Hards 2004-06-14 05:08:57 UTC
This also happens with the kpartapp template.
Comment 3 Raul Moratalla 2004-06-20 23:49:59 UTC
I have downloaded a new snapshot and the problem with KAboutData::License_$LICENSE$ was solved but it still remains: (C) %{YEAR}
Comment 4 Sascha Cunz 2004-06-25 00:46:43 UTC
CVS commit by cunz: 

At least fix the remaining $LICENSE$ texts in templates
I yet did not have the time to redo the stuff which should translate "GPL+Qt-Exception" into "GPL", so i cannot close this yet.

Does this need to get into Beta1? I personally think that being not able to compile a KDE Application out of the box is a grave-bug for the KDE IDE.
CCMAIL: 83191@bugs.kde.org
CCMAIL: kdevelop-devel@kdevelop.org


  M +1 -1      kpartapp/main.cpp   1.5
  M +1 -1      kxt/main.cpp   1.5


--- kdevelop/languages/cpp/app_templates/kpartapp/main.cpp  #1.4:1.5
@@ -20,5 +20,5 @@ int main(int argc, char **argv)
 {
     KAboutData about("%{APPNAMELC}", I18N_NOOP("%{APPNAME}"), version, description,
-                     KAboutData::License_$LICENSE$, "(C) %{YEAR} %{AUTHOR}", 0, 0, "%{EMAIL}");
+                     KAboutData::License_%{LICENSE}, "(C) %{YEAR} %{AUTHOR}", 0, 0, "%{EMAIL}");
     about.addAuthor( "%{AUTHOR}", 0, "%{EMAIL}" );
     KCmdLineArgs::init(argc, argv, &about);

--- kdevelop/languages/cpp/app_templates/kxt/main.cpp  #1.4:1.5
@@ -20,5 +20,5 @@ int main(int argc, char **argv)
 {
     KAboutData about("%{APPNAMELC}", I18N_NOOP("%{APPNAME}"), version, description,
-                     KAboutData::License_$LICENSE$, "(C) %{YEAR} %{AUTHOR}", 0, 0, "%{EMAIL}");
+                     KAboutData::License_%{LICENSE}, "(C) %{YEAR} %{AUTHOR}", 0, 0, "%{EMAIL}");
     about.addAuthor( "%{AUTHOR}", 0, "%{EMAIL}" );
     KCmdLineArgs::init(argc, argv, &about);


Comment 5 Amilcar do Carmo Lucas 2004-11-30 22:08:10 UTC
This is mostly fixed in both KDE_3_3_BRANCH and HEAD.
The remaining issues are:
- the stuff which should translate "GPL+Qt-Exception" into "GPL"
- there are licenses that have no counterpart in the enum in KAboutData
Comment 6 Jens Dagerbo 2005-01-07 20:19:41 UTC
CVS commit by dagerbo: 

Bug galore!

BUG: 90070
BUG: 76800
BUG: 83191
BUG: 88229
BUG: 89149


  M +29 -5     appwizarddlg.cpp   1.112
  M +3 -3      kdevlicense.cpp   1.3