Version: v1.3.2 (using KDE KDE 3.2.2) Installed from: RedHat RPMs OS: Linux Konsole --help shows the Qt command-line options -fg (foreground color) and -bg (background color) as viable konsole options. I've seen the other bug reports requesting that these options be made available (which would be very helpful) with responses that they will not be added, seeing as the -schema option has been made available. I would like to see the references to -fg and -bg removed from the --help screens and the standard "Unknown option" message appear if these options are used. I spent 6 hours (!) trying to figure out what I was doing wrong trying to get these options to work! Turns out it wasn't me.
Created attachment 6052 [details] Error message for --fore/background options. Rather simple. Perhaps the error message might need changing... I'll have to look at how parsedArgs("qt") works. Not sure if it is possible to remove the --fore/background from the help-qt menu.
The patch in comment #1 should likely just be a stop-gap measure. It is better than nothing, but unlikely the best way to do it.
Created attachment 6053 [details] patch to dis-allow --back/foreground options. Move the if checks after calling parseArgs("qt"); uses usage instead of printf. It would still be better to remove the --back/foreground from the qt options.
-bg / -fg doesn't seem to be doing anything at all in any KDE application, It could basically be removed from --help-qt, but for backwards compatibility the option should not give an error.
I tried removing all qt/kde options from the command line. konsole only uses 3 qt options. However, I had to patch kcmdlinesargs.cpp in order to get it to work. I'm waiting on feedback for that patch on http://bugs.kde.org/show_bug.cgi?id=82195. I have another patch for konsole which cleans up the help/cmdlines if 82195 get applied.
Created attachment 6160 [details] Give warning upon --fore/background This give a warning if --fore/background are given on the command-line.
CVS commit by hindenburg: BUG: 81834. Add warnings about Qt options that are ignored. M +10 -0 main.cpp 1.283 --- kdebase/konsole/konsole/main.cpp #1.282:1.283 @@ -228,4 +228,14 @@ extern "C" int KDE_EXPORT kdemain(int ar TEWidget::setStandalone( true ); + // The following Qt options have no effect; warn users. + if( qtargs->isSet("background") ) + kdWarning() << "The Qt option -bg, --background has no effect." << endl; + if( qtargs->isSet("foreground") ) + kdWarning() << "The Qt option -fg, --foreground has no effect." << endl; + if( qtargs->isSet("button") ) + kdWarning() << "The Qt option -btn, --button has no effect." << endl; + if( qtargs->isSet("font") ) + kdWarning() << "The Qt option -fn, --font has no effect." << endl; + #ifdef COMPOSITE char *display = 0;
I don't get the impression that these options work in *any* KDE application. Cheers, Waldo On Thursday 27 January 2005 06:48, Kurt V.Hindenburg wrote: > ------- You are receiving this mail because: ------- > You are the assignee for the bug, or are watching the assignee. > > http://bugs.kde.org/show_bug.cgi?id=81834 > kurt.hindenburg kdemail net changed: > > What |Removed |Added > --------------------------------------------------------------------------- >- Status|UNCONFIRMED |RESOLVED > Resolution| |FIXED > > > > ------- Additional Comments From kurt.hindenburg kdemail net 2005-01-27 > 06:48 ------- CVS commit by hindenburg: > > BUG: 81834. Add warnings about Qt options that are ignored. > > > M +10 -0 main.cpp 1.283 > > > --- kdebase/konsole/konsole/main.cpp #1.282:1.283 > @ -228,4 +228,14 @ extern "C" int KDE_EXPORT kdemain(int ar > TEWidget::setStandalone( true ); > > + // The following Qt options have no effect; warn users. > + if( qtargs->isSet("background") ) > + kdWarning() << "The Qt option -bg, --background has no effect." << > endl; + if( qtargs->isSet("foreground") ) > + kdWarning() << "The Qt option -fg, --foreground has no effect." << > endl; + if( qtargs->isSet("button") ) > + kdWarning() << "The Qt option -btn, --button has no effect." << > endl; + if( qtargs->isSet("font") ) > + kdWarning() << "The Qt option -fn, --font has no effect." << endl; > + > #ifdef COMPOSITE > char *display = 0; > _______________________________________________ > konsole-devel mailing list > konsole-devel@kde.org > https://mail.kde.org/mailman/listinfo/konsole-devel