Bug 80880 - filename suggestion when moving/copying does not work properly
Summary: filename suggestion when moving/copying does not work properly
Status: RESOLVED FIXED
Alias: None
Product: kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-04 07:55 UTC by Maier Gerfried
Modified: 2004-05-07 13:07 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maier Gerfried 2004-05-04 07:55:53 UTC
Version:            (using KDE KDE 3.2.1)
Installed from:    Compiled From Sources
Compiler:          gcc 3.2.2 
OS:          Linux

How to reproduce:

mkdir test1
mkdir test2
for i in 1 2 3 4 5 6 7; do touch test1/$i; done
touch test2/3

Open two konqueror windows - one of test1 and one of test2. Grab all the files in test1 and drag them to test2. When the context menu appears, select "move here" (didn't try if the same problem occurs when selecting 'copy here')

After this file '1' and '2' are moved.
A dialog-box appears:
"A similar file named '3' already exists. Source file is 'test1/3' ..."

When selecting "Suggest New Name", '3_1' is suggested and by pressing "rename" the file 3 is moved to 3_1.
The next file in the list is '4'.

Here this dialog appears again - and this is the bug.
It says: "A similar file named '3_1' already exists. Source file is 'test1/4' ...

(I expected the move-process to finish without any further question)

If you need any further information - please feel free to mail me.
Comment 1 David Faure 2004-05-07 13:07:33 UTC
CVS commit by faure: 

Fix for regression introduced by the (pre-3.2) support for renaming when moving (before copy+del):
m_dest was getting modified and this affected subsequent source URLs too.
Fixed by storing the global dest into d->m_globalDest/d->m_globalDestinationState.
Will backport.
CCMAIL: 80880-done@bugs.kde.org


  M +41 -13    job.cpp   1.385
  M +8 -2      jobclasses.h   1.138