Bug 80619 - not able to set proxy port other than 8080
Summary: not able to set proxy port other than 8080
Status: RESOLVED FIXED
Alias: None
Product: kcontrol
Classification: Miscellaneous
Component: kcmproxy (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-29 14:54 UTC by former user
Modified: 2004-05-07 09:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description former user 2004-04-29 14:54:58 UTC
Version:           Unbekannt (using KDE 3.2.2,  (testing/unstable))
Compiler:          gcc version 3.3.3 (Debian 20040401)
OS:          Linux (i686) release 2.4.25-1-386

It is not possible to set a proxy port other than 8080 and get this saved and used. After reopening the Settings it is back to 8080.
Comment 1 Dawit Alemayehu 2004-05-01 01:09:23 UTC
No matter what I do, I just cannot duplicate this at all. Can you please look 
at the proxy config file: $KDEHOME/share/config/kioslaverc and see what the 
ports are set to ? Also please rename or remove that file and try to set the 
ports again. If the problem persists, please send me the proxy config file in 
personal mail. Thanks...


On Friday 30 April 2004 14:56, Stephan Binner wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=80619
> binner kde org changed:
>
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- Component|general                     |kcmproxy
>             Product|konqueror                   |kcontrol
>             Summary|not able to set proxy port  |not able to set proxy port
>
>                    |other than 8080             |other than 8080
>
> _______________________________________________
> Konq-bugs mailing list
> Konq-bugs@mail.kde.org
> https://mail.kde.org/mailman/listinfo/konq-bugs

Comment 2 former user 2004-05-06 16:43:01 UTC
OK, installed 3.2 myself and couldn't reproduce, so I revisited the machine where I witnessed this behavior.
Indeed the proxy address part was set as in http:/192.168.0.1 (only one /). That way the port entry would always default back to 8080.

Maybe the proxy setup could still be a little less fragile though.
The form doesn't seem to mention that a http:// prefix is needed at all, it could just default to http/https protocol if not given explicitly.

Thanks for your help!
(damn bad eyesight ;-)


Comment 3 Dawit Alemayehu 2004-05-07 05:19:19 UTC
http:// prefix is not needed. It does default to http:// if you do not specify the protocol yourself. Try it. You must have made a typo and entered "http:/192.168.0.1" instead. In fact, I can duplicate your bug if I do that.
Will be fixed shortly...
Comment 4 Dawit Alemayehu 2004-05-07 09:05:44 UTC
CVS commit by adawit: 

- Make the proxy setup a little bit fragile. Fixes BR# 80619.

CCMAIL: 80619-done@bugs.kde.org


  M +6 -3      kmanualproxydlg.cpp   1.23.2.2


--- kdebase/kcontrol/kio/kmanualproxydlg.cpp  #1.23.2.1:1.23.2.2
@@ -271,5 +271,6 @@ bool KManualProxyDlg::validate()
     KURL url = dlg->leHttp->text();
 
-    if (url.isValid() || KURIFilter::self()->filterURI (url, filters))
+    if ( (url.isValid() || KURIFilter::self()->filterURI (url, filters)) &&
+         url.hasHost() )
     {
         dlg->leHttp->setText (url.url());
@@ -287,5 +288,6 @@ bool KManualProxyDlg::validate()
         url = dlg->leHttps->text();
 
-        if (url.isValid() || KURIFilter::self()->filterURI (url, filters))
+        if ( (url.isValid() || KURIFilter::self()->filterURI (url, filters)) &&
+             url.hasHost() )
         {
             dlg->leHttps->setText (url.url());
@@ -301,5 +303,6 @@ bool KManualProxyDlg::validate()
         url = dlg->leFtp->text();
 
-        if (url.isValid() || KURIFilter::self()->filterURI (url, filters))
+        if ( (url.isValid() || KURIFilter::self()->filterURI (url, filters)) &&
+             url.hasHost() )
         {
             dlg->leFtp->setText (url.url());