Bug 80541 - Sorting mails by attachment
Summary: Sorting mails by attachment
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-28 11:00 UTC by Fulvio Bertino
Modified: 2007-09-14 12:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fulvio Bertino 2004-04-28 11:00:42 UTC
Version:            (using KDE KDE 3.2.1)
Installed from:    Gentoo Packages
Compiler:          gcc version 3.3.3 20040217 (Gentoo Linux 3.3.3, propolice-3.3-7) 
OS:          Linux

A good feature that in my opinion is missed on kmail is the possibility of seeing whether the attachment is present or not in a mail, without having to open it.
I frequently need to search for a mail with attachment, but having thousands mails  open each and every one is really time consuming.
What I'd like to have is what other mail clients already have: an attach column to be able to sort the mail containing attachments and immediately visualize that information without having to open the listed mail.
Comment 1 gazel 2004-05-02 20:38:21 UTC
Vous aimez jouer avec le feu ... en ce qui me concerne il y a
longtemps   que je ne touche plus aux "trombones"  je les efface
imm
Comment 2 Till Adam 2004-07-31 15:47:16 UTC
CVS commit by tilladam: 

Add "has attachment" to the list of stati to search for in the quick
search dropdown, but not in the normal search/filter dialog where it is
special cased.

CCMAIL: 84409-done@bugs.kde.org
CCMAIL: 80541-done@bugs.kde.org


  M +2 -0      kmsearchpattern.cpp   1.70
  M +3 -1      kmsearchpattern.h   1.26
  M +3 -3      rulewidgethandlermanager.cpp   1.11


--- kdepim/kmail/kmsearchpattern.cpp  #1.69:1.70
@@ -614,4 +614,6 @@ KMMsgStatus KMSearchRuleStatus::statusFr
   if ( ! aStatusString.compare("ham") )
      status = KMMsgStatusHam;
+  if ( ! aStatusString.compare("has an attachment") )
+     status = KMMsgStatusHasAttach;
 
   return status;

--- kdepim/kmail/kmsearchpattern.h  #1.25:1.26
@@ -229,8 +229,10 @@ namespace KMail {
     I18N_NOOP( "spam" ),
     I18N_NOOP( "ham" ),
-    I18N_NOOP( "todo" )
+    I18N_NOOP( "todo" ),
+    I18N_NOOP( "has an attachment")
   };
   static const int StatusValueCount =
     sizeof( StatusValues ) / sizeof( *StatusValues );
+  static const int StatusValueCountWithoutHidden = StatusValueCount - 1;
 }
 

--- kdepim/kmail/rulewidgethandlermanager.cpp  #1.10:1.11
@@ -1058,5 +1058,5 @@ namespace {
     QComboBox *statusCombo = new QComboBox( valueStack,
                                             "statusRuleValueCombo" );
-    for ( int i = 0; i < KMail::StatusValueCount; ++i ) {
+    for ( int i = 0; i < KMail::StatusValueCountWithoutHidden; ++i ) {
       statusCombo->insertItem( i18n( KMail::StatusValues[i] ) );
     }
@@ -1218,5 +1218,5 @@ namespace {
     const QString value = rule->contents();
     int valueIndex = 0;
-    for ( ; valueIndex < KMail::StatusValueCount; ++valueIndex )
+    for ( ; valueIndex < KMail::StatusValueCountWithoutHidden; ++valueIndex )
       if ( value == QString::fromLatin1(
                KMail::StatusValues[valueIndex] ) )
@@ -1227,5 +1227,5 @@ namespace {
     if ( statusCombo ) {
       statusCombo->blockSignals( true );
-      if ( valueIndex < KMail::StatusValueCount )
+      if ( valueIndex < KMail::StatusValueCountWithoutHidden )
         statusCombo->setCurrentItem( valueIndex );
       else {