Bug 79443 - Konqueror performance-option "Minimize memory-usage: Always" doesn't work.
Summary: Konqueror performance-option "Minimize memory-usage: Always" doesn't work.
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-11 22:56 UTC by Sindre Aamås
Modified: 2004-04-17 18:37 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sindre Aamås 2004-04-11 22:56:33 UTC
Version:            (using KDE KDE 3.2.1)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc-3.3.3 
OS:          Linux

In the performance section of konquerors configuration options, you can chose 3 behaviours for minimizing memory usage. Those being "Never", "For file browsing only" and "Always". These are supposed to adjust whether konqueror starts a new process or just creates a new windows of a currently running one to improve speed and preserve memory when launching konqueror. The "Never"-option works as it is supposed to, resulting in every launch of konqueror creating a new process. The "For file browsing only"-option also works, reusing the same konqueror-process for filemanagement rather than starting a new one upon launching konqueror. However the "Always" option has the same behaviour as the "Never" option, starting new processes on every launc, rather than always launching a window of an already running konqueror-process (should there be one).

This should be fixed as it really improves performance on slower computers, and it kind of sucks if users think they've chosen the fastest option, while they've actually got the slowest one. Right now I use a script issuing a dcop-call to open a new konqueror window (if a konqueror-process is found) to archieve similar behaviour.
Comment 1 Lubos Lunak 2004-04-17 18:37:33 UTC
CVS commit by lunakl: 

When set to always reuse, return false from startNewKonqueror().
CCMAIL: 79443-done@bugs.kde.org


  M +1 -1      kfmclient.cc   1.113


--- kdebase/konqueror/client/kfmclient.cc  #1.112:1.113
@@ -206,5 +206,5 @@ static bool startNewKonqueror( QString u
         allowed_parts = cfg.readListEntry( "SafeParts" );
     if( allowed_parts.count() == 1 && allowed_parts.first() == QString::fromLatin1( "ALL" ))
-        return true; // all parts allowed
+        return false; // all parts allowed
     if( mimetype.isEmpty())
         mimetype = KMimeType::findByURL( KURL( url ) )->name();