Bug 78428 - Wish: Juk should support changing fonts and encodings
Summary: Wish: Juk should support changing fonts and encodings
Status: ASSIGNED
Alias: None
Product: juk
Classification: Applications
Component: general (show other bugs)
Version: 2.0
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-25 08:56 UTC by Sonyu Chen
Modified: 2011-06-17 00:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
utf8.cpp (1.25 KB, text/x-c++src)
2004-04-04 20:05 UTC, Scott Wheeler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sonyu Chen 2004-03-25 08:56:00 UTC
Version:           2.0 (using KDE 3.2 BRANCH >= 20040204, Mandrake Linux Cooker i586 - Cooker)
Compiler:          gcc version 3.3.2 (Mandrake Linux 10.0 3.3.2-6mdk)
OS:          Linux (i686) release 2.6.3-4mdk

My mp3 files have tags composed of encodings big5(zh_TW.big5) and UTF-8. When adding them into the juK collection list, they becomes unreadable.  Well, I've read the similar bug reports for juK, and am aware of how id3v1 is restricted.  But I think, before it is solved, can juK have a option, to customize fonts and encodings, by pretending that, the string is composed of some specific encoding? It would be very nice for non-English users. 

Thank you!
Comment 1 Scott Wheeler 2004-04-04 16:51:52 UTC
CVS commit by wheeler: 

Add the ability to override the default ID3v1 string handling in TagLib by
adding a ID3v1::StringHandler class that has render and parse methods.

By default this still makes the (correct) assumption that ID3v1 tags contain
ISO-8859-1 data, but this makes it easy for applications to override this to
allow user specified codecs.

CCMAIL:78428@bugs.kde.org
CCMAIL:77710@bugs.kde.org
CCMAIL:amarok-devel@lists.sourceforge.net
CCMAIL:Shlomi Loubaton <loubaton.shlomi@012.net.il>
CCMAIL:Nir Misgav <misgav@ee.bgu.ac.il>


  M +34 -10    id3v1tag.cpp   1.23
  M +47 -0     id3v1tag.h   1.14



Comment 2 Scott Wheeler 2004-04-04 20:05:49 UTC
Ok, and now I'm attaching a small Qt-based program that shows how to override 
the default string encoding.  This one just uses utf8, but I think it's clear 
how one would proceed based on this...

I would also recommend by default (i.e. when ISO-8859-1 is selected) not using 
an external string handler at all since they extra lookups will likely slow 
things down...

- -Scott

On Sunday 04 April 2004 16:42, Scott Wheeler wrote:
> CVS commit by wheeler: 
> 
> Add the ability to override the default ID3v1 string handling in TagLib by
> adding a ID3v1::StringHandler class that has render and parse methods.
> 
> By default this still makes the (correct) assumption that ID3v1 tags contain
> ISO-8859-1 data, but this makes it easy for applications to override this to
> allow user specified codecs.
> 
> CCMAIL:78428@bugs.kde.org
> CCMAIL:77710@bugs.kde.org
> CCMAIL:amarok-devel@lists.sourceforge.net
> CCMAIL:Shlomi Loubaton <loubaton.shlomi@012.net.il>
> CCMAIL:Nir Misgav <misgav@ee.bgu.ac.il>
> 
> 
>   M +34 -10    id3v1tag.cpp   1.23
>   M +47 -0     id3v1tag.h   1.14
> 
> 
> 
> 



Created an attachment (id=5529)
utf8.cpp
Comment 3 Scott Wheeler 2004-06-27 23:00:49 UTC
I'm just confirming the locale part of things -- for the moment I don't intend to make the font configurable.