Bug 77440 - External editor not configurable, again (v2.1.1)
Summary: External editor not configurable, again (v2.1.1)
Status: CONFIRMED
Alias: None
Product: cervisia
Classification: Applications
Component: general (show other bugs)
Version: 2.1.1
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Christian Loose
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-13 03:24 UTC by Benj Carson
Modified: 2021-03-09 05:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benj Carson 2004-03-13 03:24:37 UTC
Version:           2.1.1 (using KDE 3.2.1,  (testing/unstable))
Compiler:          gcc version 3.3.3 (Debian)
OS:          Linux (i686) release 2.6.2-mm1

Prior to upgrading to KDE 3.2 I was able to change the Cervisia's external editor.  (I believe this is why the previous bugs mentioning this error are marked as closed--they are all dated circa 2002.)  However, this feature has been removed in the latest version.  As mentioned by Willems Luc in bug 40667, this introduces many difficulties in editing files: 

"I'm also using de KDE3.2 version and I'm missing this configuration VERY HARD.
The "editor" selection is removed in favor of only using the krun class to start-up an application that can handle the mime-type of the file.
This may work nice for images, but what about shell scripts.
If i select edit with a shell script , it will not open an editor and
let me edit the file, but instead run the script :-(
Also, other text files like perl scripts have there mime-type link to kwrite which i don't like. i would like to use kate.
It's not handy to search all possible mime-type and change them to kate.
Why is the KDE component chooser setting not respected (it's set to kate)"

I couldn't agree more...  As another example, I have several PHP Smarty templates in CVS and if I try and edit them, Cervisia/krun determines that they are HTML files and opens a browser instead of my editor.  I am not particularly inclined to make a system-wide change to have HTML files open in Emacs instead of my browser, so I believe that support for external editors should be included again.  Without it, the 'edit' option is next to useless.
Comment 1 Christian Loose 2004-03-17 21:19:47 UTC
CVS commit by cloose: 

Don't execute shell scripts or .desktop files when the user used 
the edit file function. 

CCMAIL: 77440@bugs.kde.org


  M +5 -0      ChangeLog   1.113
  M +2 -1      cervisiapart.cpp   1.133


--- kdesdk/cervisia/cervisiapart.cpp  #1.132:1.133
@@ -748,5 +748,6 @@ void CervisiaPart::openFiles(const QStri
         KURL u;
         u.setPath(dir.absFilePath(*it));
-        (void) new KRun(u, 0, true, false);
+        KRun* run = new KRun(u, 0, true, false);
+        run->setRunExecutables(false);
     }
 }

--- kdesdk/cervisia/ChangeLog  #1.112:1.113
@@ -1,2 +1,7 @@
+2004-03-17  Christian Loose  <christian.loose@hamburg.de>
+
+        * Don't execute shell scripts or .desktop files when the user used
+          the edit file function.
+
 2004-03-02  Andr
Comment 2 Christian Loose 2004-04-23 23:26:15 UTC
link to relevant discussion: http://lists.kde.org/?l=kde-core-devel&m=108273615412430&w=2
Comment 3 Justin Zobel 2021-03-09 05:30:50 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.