Bug 77402 - KGet "List all Links" window from Konqueror is labelled "Konqueror", which is confusing
Summary: KGet "List all Links" window from Konqueror is labelled "Konqueror", which is...
Status: RESOLVED FIXED
Alias: None
Product: kget
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: KGet authors
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-12 16:20 UTC by Bill Kendrick
Modified: 2005-03-04 12:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Kendrick 2004-03-12 16:20:55 UTC
Version:           v0.8.3 (using KDE 3.2.0,  (3.0))
Compiler:          gcc version 2.95.4 20011002 (Debian prerelease)
OS:          Linux (i686) release 2.4.18-bf2.4

When clicking the KGet button on the Konqueror toolbar and selecting "List all Links", the window that appears is titled, simply, "Konqueror."  That's pretty confusing. :^)  At the least, it should be labelled "KGet" or "List all Links."  Best, though, would be "All links on: [page title or URL] - KGet". :^)  Thanks!!!
Comment 1 Pino Toscano 2005-03-04 12:33:35 UTC
CVS commit by pino: 

Implementing wishlist #77402 (wishlist): KGet "List all Links" window from Konqueror is labelled "Konqueror", which is confusing
Moreover, I close it, sice I can't backport it to the branch, because it adds at least one new string.

BUG: 77402


  M +6 -0      kget_linkview.cpp   1.4
  M +2 -1      kget_linkview.h   1.2
  M +2 -0      kget_plug_in.cpp   1.17


--- kdenetwork/kget/kget_plug_in/kget_linkview.cpp  #1.3:1.4
@@ -34,4 +34,6 @@ KGetLinkView::KGetLinkView( QWidget *par
     : KMainWindow( parent, name )
 {
+    setPlainCaption( i18n( "KGet" ) );
+
     KActionCollection *coll = actionCollection();
 
@@ -100,4 +102,8 @@ void KGetLinkView::slotStartLeech()
 }
 
+void KGetLinkView::setPageURL( const QString& url )
+{
+    setPlainCaption( i18n( "Links in: %1 - KGet" ).arg( url ) );
+}
 
 #include "kget_linkview.moc"

--- kdenetwork/kget/kget_plug_in/kget_linkview.h  #1.1:1.2
@@ -34,4 +34,5 @@ public:
 
     void setLinks( QPtrList<LinkItem>& links );
+    void setPageURL( const QString& url );
 
 signals:

--- kdenetwork/kget/kget_plug_in/kget_plug_in.cpp  #1.16:1.17
@@ -153,4 +153,6 @@ void KGet_plug_in::slotShowLinks()
 
     KGetLinkView *view = new KGetLinkView();
+    QString url = doc.URL().string();
+    view->setPageURL( url );
     connect( view, SIGNAL( leechURLs( const KURL::List& ) ),
              SLOT( startDownload( const KURL::List& ) ));