Bug 77086 - Gadu offline contacts with desc are shown as away
Summary: Gadu offline contacts with desc are shown as away
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: Gadu-Gadu Plugin (other bugs)
Version First Reported In: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-09 15:54 UTC by Roman Kalukiewicz
Modified: 2006-03-02 15:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kalukiewicz 2004-03-09 15:54:16 UTC
Version:            (using KDE KDE 3.2.1)
Installed from:    Debian testing/unstable Packages

All Offline contacts from gadu-gadu are shown as Gadu Offline, but at the same time as Kopete's Away (with away icon).

I think that Gadu offline should be offline for Kopete (strange?) :)

Maybe it has its own reasons, but I think that in 
kdenetwork/kopete/protocols/gadu/gaduprotocol.cpp lines 52, 53

gaduStatusOfflineDescr_( KopeteOnlineStatus::Away, GG_STATUS_NOT_AVAIL_DESCR, this, GG_STATUS_NOT_AVAIL_DESCR,
"gg_offline_d", i18n( "Go A&way" ), i18n( "Offline" ) ),

should be changed to

gaduStatusOfflineDescr_( KopeteOnlineStatus::Offline, GG_STATUS_NOT_AVAIL_DESCR, this, GG_STATUS_NOT_AVAIL_DESCR,
"gg_offline_d", i18n( "Go O&ffline" ), i18n( "Offline" ) ),

I'm waiting for your opinion. :)
Comment 1 Grzegorz Jaskiewicz 2004-03-09 16:19:24 UTC
Browse the list, and you'll find out why.
But I can tell you now, I want offline contacts _with_ description set to be 
seen on the list, because I find that description somehow important even if 
someone is offline (like 'just pop-out for to pub', 'I'm about to kill me 
self'). 
This code is correct, I can say, by design, since kopete doesn't give me an 
option to decide whether I want this paticular status to be shown on the list 
when 'show offline' is ticked off , or not. That's why icon is offline, but 
with color, and with little 'i'.
This bug report is invalid therefor, and I will 'fix' it as soon as kopete 
will alow me to set property of status. For now, I need to depend on that 
little trick.

Comment 2 Roman Kalukiewicz 2004-03-09 16:42:55 UTC
OK - it is a reason.

So the best solution is to add an option to show all persons with description to Kopete.

But now when I select an option not to show offline contacts I can see those offline contacts. I think that it is a bug, because ALL users expect that they don't see any offline contact while they select not to see them.

Second thing is that Kopete displays Away icon and Away description with is a lie.

My option would be to show offline with description as offline, but before those without description. Then offline IS offline, and it's easy to check if someone have something to say about his offline status.

I think that there should be usefull "weight" parameter to KopeteOnlineStatus constructor.
Comment 3 Grzegorz Jaskiewicz 2004-03-09 23:14:59 UTC
> But now when I select an option not to show offline contacts I can see
> those offline contacts. I think that it is a bug, because ALL users expect
> that they don't see any offline contact while they select not to see them.
Dude, gadu is not the only plugin up there. There will be no such option, 
forget about it. Most plugins (jabber, AIM, ICQ, ...) can have so called now 
awayMessage, but those functions are not implemented at all or not properly.

> Second thing is that Kopete displays Away icon and Away description with is
> a lie.
This is not AWAY icon, look at it properly. Because I cannot see away icon 
there, don't suggest with that snip of code.

> My option would be to show offline with description as offline, but before
> those without description. Then offline IS offline, and it's easy to check
> if someone have something to say about his offline status.
But I decided to leave those with description even when user decided to remove 
offline contacts. Description can be important. 

> I think that there should be usefull "weight" parameter to
> KopeteOnlineStatus constructor.
there is weight already, usefull would be property to say whether we want or 
not to see contacts with awayMessage.

I'll close this bug as invalid. I had this discussion at least once in past, 
and I won't change that. You can patch your own copy if you dislike it for 
now.

Comment 4 Grzegorz Jaskiewicz 2004-03-09 23:23:34 UTC
Maybe even work for some will be better, anyway this ain't a bug for me. Please don't comment on this bug anymore.
Comment 5 Sebastian Turzański 2004-12-13 13:08:00 UTC
we'll im my opinion it offline should be offline in kopete - but Grzegorz's "my playground - my toys" point of view will have us have offline contacts even with "display only online"  button checked. 
this is not a bug - it's just uncomfortable and it makes me have kopete for ym, aim and icq and kadu for gg
Comment 6 Piotr Jaroszyński 2005-11-15 22:39:10 UTC
There isn't any other IM app which shows offline contacts as away. And i think it is a bug because the icon is wrong, should be offline with description not away - I CAN see it very well. And the sorting is not logic - should be online/away | offline with desc | offline not online/away/offline with desc | offline.
Comment 7 Roman Kalukiewicz 2005-11-16 09:23:42 UTC
You can always vote for wish 88381 I created. It should satisfy Grzegorz's and my point of view.
Comment 8 Grzegorz Jaskiewicz 2005-11-16 19:30:01 UTC
well, the thing is. I have over 80 contacts on me list. while 70% of em is mostly offline, some 20% of those offline have some kind of desc. I want to see it. Please bug kopete core developers to add that kinda feature, as most all other protocols do support descs with offline status as well.
My point is based on usability, not some dry rules.
Comment 9 madman 2006-01-13 18:02:20 UTC
Currently (kopete included in kde 3.5.0) shows those offline contacts even when 'Show Offline Users' is disabled, which means that the program does not do what the user wishes. I definately do NOT want to see offline contacts, doesn't matter if they set a description or not.
Comment 10 Grzegorz Jaskiewicz 2006-01-14 10:19:45 UTC
please read the bugs archive, before reporting something AGAIN... and  
AGAIN.....
Comment 11 Grzegorz Jaskiewicz 2006-01-14 10:28:58 UTC
read the thread again... :(
gadu has no separate option for that. Patches are welcomed. You see, I like to see contacts that are offline but have some sort of desc. Because there's over 100 contacts on my contacts list. And I have no desire to sieve them all with me eye.
Comment 12 Sebastian Turzański 2006-01-14 12:31:04 UTC
but Your are the only one wanting it - and it doesn't match kopete's button description and convention
Comment 13 Grzegorz Jaskiewicz 2006-01-14 13:42:40 UTC
coincidentally I am the only one writing it also.

--  
GJ

"If we knew what we were doing, it wouldn't be called Research, would  
it?" - AE
Comment 14 madman 2006-01-21 12:07:49 UTC
So seems the only reasonable option is to use jabber transport for gadu gadu contacts, since the plugin developer wishes to NOT fix the obvious bug in his plugin. What is the use of such plugin, if user settings (do NOT show offline) does not work? Offline contacts are shown regardless of this setting.
Comment 15 Sebastian Turzański 2006-01-21 12:30:43 UTC
thats='s what i started to do recently - and all my familit using kopete as well 
PS. good job in loosing users
Comment 16 Grzegorz Jaskiewicz 2006-01-21 15:05:05 UTC
add option for that matter. Atm I am unable to work on KDE, because my laptop is being repaired till 8th of Febuary.
So please send a patch, and stop whining and threating me. Let's face it, jabber transports are limited in functionality. All of my users are either commited to use kopete, or kadu haters. All others constist of whiners, in two categories: "when kopete will have all kadu has, I'll switch", "I rather use transport because I don't like X in kopete-gadu".
Comment 17 Grzegorz Jaskiewicz 2006-01-21 15:30:50 UTC
beause I can't do it now, and test it, Duncan is going to "fix" it for you bloody whiners. It is going to be reverted to config option as soon as I get my development env back.
Comment 18 Duncan Mac-Vicar Prett 2006-01-21 16:20:33 UTC
SVN commit 500909 by dmacvicar:


Fix semantics. Offline users should not be shown when show offline users
is off. To have this kind of special offline+message status, we would
need to make the semantics at Kopete level.

BUG:77086



 M  +1 -1      gaduprotocol.cpp  


--- branches/work/kopete/dev-0.12/kopete/protocols/gadu/gaduprotocol.cpp #500908:500909
@@ -57,7 +57,7 @@
 				"gg_ignored", i18n( "Blocked" ) ),
 			gaduStatusOffline_( Kopete::OnlineStatus::Offline, GG_STATUS_NOT_AVAIL, this, GG_STATUS_NOT_AVAIL,
 				"gg_offline", i18n( "Offline" ) , i18n( "O&ffline" ) , Kopete::OnlineStatusManager::Offline ),
-			gaduStatusOfflineDescr_( Kopete::OnlineStatus::Away, GG_STATUS_NOT_AVAIL_DESCR, this, GG_STATUS_NOT_AVAIL_DESCR,
+			gaduStatusOfflineDescr_( Kopete::OnlineStatus::Offline, GG_STATUS_NOT_AVAIL_DESCR, this, GG_STATUS_NOT_AVAIL_DESCR,
 				QStringList::split( '|', "contact_away_overlay|gg_description_overlay" ), i18n( "Offline" ), i18n( "A&way" ) , Kopete::OnlineStatusManager::Offline ),
 			gaduStatusBusy_(Kopete::OnlineStatus::Away, GG_STATUS_BUSY, this, GG_STATUS_BUSY,
 				"contact_away_overlay", i18n( "Busy" ) , i18n( "B&usy" ) , Kopete::OnlineStatusManager::Busy ),
Comment 19 Piotr Jaroszyński 2006-02-02 16:23:11 UTC
Should be default...
Comment 20 pressenter 2006-03-02 14:07:57 UTC
I am using Kopete 0.11 on my Gentoo with kde 3.5 and i see that the problem hasn't been yet solved. The contacts that are away with description are displayed exactly the same as conntacts that are offline with description. The funniest thing is (because i thought that it was only a bug) that during reemerging of Kopete 0.11, the icons of persons that were offline have been correct shownig a Gadu-Gadu sun with the two "zz", which are shown normally when the contact is offline, but only when the emerge completed, everything returned to its previous state. Why is that?? And most important when will this problem be fixed ??
Comment 21 Grzegorz Jaskiewicz 2006-03-02 14:44:11 UTC
problem IS fixed in 0.12 version.

--  

Grzegorz Jaskiewicz

"Better to remain silent and be thought a fool than to speak out and  
remove all doubt." - A. Lincoln
Comment 22 pressenter 2006-03-02 15:04:29 UTC
That's great, but how can i have kopete 0.12 without the problem of compiling it from source?? It is not available in portage. As i have written i'm using kde 3.5. To have it on my gentoo i had to use masked packages, with which came Kopete 0.11. I've tried to compile 0.12 from source, but i'm not such a advanced linux user and when the compilation was aborted because of errors i could not fix it. This below is the exact error i get. I know that i'm missing something in my kde, but like i said, I'm not so advanced... yet.

"checking for kde-config... not found
configure: error: The important program kde-config was not found!
Please check whether you installed KDE correctly."