Bug 76683 - custom ksplash themes dont show when directory and theme name are different
Summary: custom ksplash themes dont show when directory and theme name are different
Status: RESOLVED FIXED
Alias: None
Product: ksplash
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Ravikiran Rajagopal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-03 19:50 UTC by Shane Shields
Modified: 2004-03-10 01:20 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shane Shields 2004-03-03 19:50:24 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.2.2 
OS:          Linux

when designing custom ksplash themes they dont show when logging on. Only the default theme shows. This is because the directory name and theme name in the theme.rc are different. For original discription of this bug see the kde-devel mailing list under ksplash heads up. Or included is this excerpt

> I don't know if it is a "feature" or not but when a custom ksplash theme is
> made and the name in the theme.rc does not match the directory name it is
> under. The theme is seen and can be chosen, when test is selected the theme
> is displayed but on login is not shown. This caused a lot of confusion for
> me (not hard :). Perhaps a warning or addition to the ksplash handbook in
> the section about creating themes JAT.
Comment 1 Ravikiran Rajagopal 2004-03-10 01:20:37 UTC
CVS commit by ravi: 

Emphasize in the documentation that the directory name and the theme name should be identical. Fix change in naming scheme introduced by Coolo before 3.2 but after doc freeze.

CCMAIL: 76683-done@bugs.kde.org


  M +20 -12    index.docbook   1.11


--- kdebase/doc/ksplashml/index.docbook  #1.10:1.11
@@ -1,5 +1,5 @@
 <?xml version="1.0" ?>
 <!DOCTYPE book PUBLIC "-//KDE//DTD DocBook XML V4.2-Based Variant V1.1//EN" "dtd/kdex.dtd" [
-  <!ENTITY kappname "ksplash">
+  <!ENTITY ksplash "KSplash">
   <!ENTITY package "kdebase">
   <!ENTITY % addindex "IGNORE">
@@ -34,5 +34,5 @@
 </copyright>
 <copyright>
-<year>2003</year>
+<year>2003-04</year>
 <holder>Ravikiran Rajagopal</holder>
 </copyright>
@@ -141,4 +141,12 @@
 by assigning key-value pairs as in the example file above.</para>
 
+<para>It is important that the name of the directory under which the 
+theme files are stored (<filename 
+class="directory">~/.kde/apps/ksplash/Themes/MyCoolTheme</filename> in 
+our case) and the identifier (<literal>[KSplash Theme: MyCoolTheme]
+</literal> in our case) of the theme in the <filename>Theme.rc</filename> 
+file are identical. Otherwise, &ksplash; will not recognize the theme.
+</para>
+
 </sect2>
 
@@ -589,6 +597,6 @@
 </para>
 <simplelist>
-<member>The library should be named as <filename>libksplash+lowercasethemename</filename>. For our
-theme, it will be <filename>libksplash2k</filename>.</member>
+<member>The library should be named as <filename>ksplash+lowercasethemename</filename>. For our
+theme, it will be <filename>ksplash2k</filename>.</member>
 <member>It should have a corresponding desktop file which is named as
 <filename>ksplash+lowercasethemename.desktop</filename>. For our theme, it will be
@@ -610,5 +618,5 @@
 toplevel folder which contains generic files such as AUTHORS, &etc;. We are most interested
 in the subfolder called <filename class="directory">2k</filename>. Go into that subfolder
-and delete all the files there. Now we have the skeleton we required.
+and delete all the files there. Now we have the skeleton we require.
 </para>
 <para>
@@ -627,5 +635,5 @@
 Name=KSplash2k
 ServiceTypes=KSplash/Plugin
-X-KDE-Library=libksplash2k
+X-KDE-Library=ksplash2k
 X-KSplash-Default=true
 X-KSplash-PluginName=2k
@@ -754,5 +762,5 @@
 <title>Library requirement</title>
 <programlisting>
-K_EXPORT_COMPONENT_FACTORY( libksplash2k, KGenericFactory&lt;Theme2k&gt; );
+K_EXPORT_COMPONENT_FACTORY( ksplash2k, KGenericFactory&lt;Theme2k&gt; );
 </programlisting>
 </example>
@@ -821,9 +829,9 @@
 INCLUDES = $(all_includes)
 
-kde_module_LTLIBRARIES = libksplash2k.la
+kde_module_LTLIBRARIES = ksplash2k.la
 
-libksplash2k_la_SOURCES = theme2k.cpp rotwidget.cpp
-libksplash2k_la_LDFLAGS = $(all_libraries) $(KDE_RPATH)
-libksplash2k_la_LIBADD = $(LIB_KDEUI) -lksplashthemes
+ksplash2k_la_SOURCES = theme2k.cpp rotwidget.cpp
+ksplash2k_la_LDFLAGS = $(all_libraries) $(KDE_RPATH)
+ksplash2k_la_LIBADD = $(LIB_KDEUI) -lksplashthemes
 
 METASOURCES = AUTO
@@ -942,5 +950,5 @@
 #include "theme2k.moc"
 
-K_EXPORT_COMPONENT_FACTORY( libksplash2k, KGenericFactory&lt;Theme2k&gt; );
+K_EXPORT_COMPONENT_FACTORY( ksplash2k, KGenericFactory&lt;Theme2k&gt; );
 
 Cfg2k::Cfg2k( KConfig * )