Bug 76423 - Location bar does not allow javascript, disabling blogging tools.
Summary: Location bar does not allow javascript, disabling blogging tools.
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: RedHat Enterprise Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-29 16:11 UTC by jeff pitman
Modified: 2004-04-07 17:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jeff pitman 2004-02-29 16:11:17 UTC
Version:            (using KDE KDE 3.2.0)
Installed from:    RedHat RPMs
OS:          Linux

I consider this function: stop ship.  Not, wishlist.  Popular blogging tools such as Blogger use a bookmarklet to bring up pop-ups.  Were it not the default search engine catching it in Web Shortcuts, the location bar passes the URI onto the kio handlers.  At this point, an error dialog will show saying "Protocol Not Supported".  If a separate kio were to be created--kio_javascript.so--then, it would have to use DCOP hand-waving to execute the script within the konqueror app.

The previous bug, which contains a whole thread of discussion at Bug #30302 is targeted at the incorrect product.  It is NOT keditbookmarks.  It's the Location bar and how it handles javascript URIs. 

Javascript as a URI is already well supported in other open source browsers, please give an ear to your users and see what can be done to integrate this into konqi.
Comment 1 Stephan Kulow 2004-02-29 16:28:50 UTC
I have no idea what you're talking about. If a site uses javascript:, then it's executed with javascript as it should be. Of course it doesn't make sense
to support this a "URI" as you name it. Because URIs follow strict restrictions
Comment 2 Maksim Orlovich 2004-02-29 17:53:56 UTC
To the submitter: use the minotools plugin in kdeaddons(?) for bookmarklets
Comment 3 jeff pitman 2004-03-01 01:53:51 UTC
Take this:

javascript:Q='';x=document;y=window;if(x.selection){Q=x.selection.createRange().text;}else if(y.getSelection){Q=y.getSelection();}else if(x.getSelection){Q=x.getSelection();}void(window.open('http://new.blogger.com/blog_this.pyra?t='+escape(Q)+'&u='+escape(location.href)+'&n='+escape(document.title),'bloggerForm','scrollbars=no,width=475,height=300,top=175,left=75,status=yes,resizable=yes'));

And put it in Konqueror's location bar.

Put it in Mozilla.

You'll see what I'm talking about.

A 3rd party tool such as minitools that you have to dig up because it's not in the default install of KDE isn't an effective method for providing this support.

BTW, there are plenty of "other" URIs in konqueror that probably don't follow the said "restrictions".  The one that comes to mind is "about:blank" or "about:konqueror".
Comment 4 Dirk Mueller 2004-03-01 04:12:21 UTC
bookmarklets have been implemented. there won't
be any support for javascript: in the location bar, since
konqueror is more than a plain webbrowser. 
Comment 5 jeff pitman 2004-04-07 12:33:03 UTC
I've started a preliminary project exploring the issues. You can get a pre-alpha version that is operational here: http://konqlets.berlios.de/. If you would like to help further its goals, let me know.  This project is a KIO that will allow for javascript: URIs.

Thanks,

Jeff
Comment 6 lypanov 2004-04-07 17:10:24 UTC
while i love the fact that someone has actually taken this on :)
i have to say, umm.. i'd advise not bothering with the kioslave 
route the security implications are pretty heavy. why not just
make the minitools plugin better? i have no problem with putting
it in kdebase and i don't that i'll get much resistance for this.
most distros install kdeaddons in any case, or they should, lots
of other very needed stuff is included in it.

Alex
Comment 7 lypanov 2004-04-07 17:13:50 UTC
oh and btw, the package is konqueror/bookmarks for the other bug,
its just that the bug displays a bit strange and u can see the
original posters idea of package therefore :)

Alex