Bug 75601 - Text shadow property not restored on document load
Summary: Text shadow property not restored on document load
Status: RESOLVED WORKSFORME
Alias: None
Product: kword
Classification: Miscellaneous
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-19 13:15 UTC by Wolfgang Westphal
Modified: 2004-02-24 09:21 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
shadowtest.kpr (3.01 KB, application/octet-stream)
2004-02-23 09:47 UTC, Wolfgang Westphal
Details
shadowtest.kwd (3.36 KB, application/octet-stream)
2004-02-23 09:47 UTC, Wolfgang Westphal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Westphal 2004-02-19 13:15:08 UTC
Version:           unknown (using KDE 3.2.0, Gentoo)
Compiler:          gcc version 3.3.2 20031218 (Gentoo Linux 3.3.2-r5, propolice-3.3-7)
OS:          Linux (i686) release 2.4.24

I tried this with kword and kpresenter in the latest stable version as well as with HEAD:

I created a text object (or enter some text in kword) and assign a shadow to it, saved the document and exited the application. When I reload the document next time the shadow is gone.
Comment 1 David Faure 2004-02-20 11:43:01 UTC
On Thursday 19 February 2004 13:15, Wolfgang Westphal wrote:
> I tried this with kword and kpresenter in the latest stable version as well as with HEAD:
> I created a text object (or enter some text in kword) and assign a shadow to it, saved the document and exited the application. 
> When I reload the document next time the shadow is gone. 

I fixed yesterday a bug in HEAD (libkotext) that was responsible for this.
* Are you really sure that this happens in koffice-1.3 as well?
* Can you update (at least lib+kword+kpresenter) and test that it works in HEAD?
Thanks.

Comment 2 Wolfgang Westphal 2004-02-22 00:13:13 UTC
Am Friday 20 February 2004 11:43 schrieb David Faure:
> On Thursday 19 February 2004 13:15, Wolfgang Westphal wrote:
> > I tried this with kword and kpresenter in the latest stable version
> > as well as with HEAD: I created a text object (or enter some text
> > in kword) and assign a shadow to it, saved the document and exited
> > the application. When I reload the document next time the shadow is
> > gone.
>
> I fixed yesterday a bug in HEAD (libkotext) that was responsible for
> this.
> * Are you really sure that this happens in koffice-1.3 as well? 

Yes, it was the motivation to give HEAD a try.

> * Can you update (at least lib+kword+kpresenter) and test that it
> works in HEAD? Thanks.

I'm afraid the problem still exists.

Comment 3 David Faure 2004-02-23 08:01:18 UTC
Very strange, since it works here in my test doc.
Can you send me a test document (set a shadow, then save)?
I'll be able to check if it's the saving or the loading that fails (you can check for <SHADOW> in maindoc.xml btw), and/or I'll be able to reproduce the problem by setting the shadow in your test doc at the right place...
Comment 4 Wolfgang Westphal 2004-02-23 09:47:45 UTC
------- Additional Comments From faure kde org  2004-02-23 08:01 -------
> Very strange, since it works here in my test doc.
>  Can you send me a test document (set a shadow, then save)?
>   I'll be able to check if it's the saving or the loading that fails
>   (you can check for <SHADOW> in maindoc.xml btw), and/or I'll be able
>   to reproduce the problem by setting the shadow in your test doc at
>   the right place...

I'll attach a sample kpresenter and a sample kword file. Both do contain
the shadow property I assigned to the text obects:

~ > zipgrep text-shadow shadowtest.kpr
maindoc.xml:     <TEXT VERTALIGN="0" family="Arial Black"
text-shadow="#a0a0a4 3pt 3pt" pointSize="20" language="en_US"
color="#000000" >Testtest</TEXT>

~ > zipgrep text-shadow shadowtest.kwd
maindoc.xml:      <SHADOW text-shadow="#a0a0a4 2pt 2pt" />
maindoc.xml:      <SHADOW text-shadow="none" />
maindoc.xml:      <SHADOW text-shadow="none" />
[...]

So the shadow disappears on document load.


Created an attachment (id=4849)
shadowtest.kpr

Created an attachment (id=4850)
shadowtest.kwd
Comment 5 David Faure 2004-02-23 11:25:09 UTC
OK it definitely works fine in HEAD and in branch for me.

I recommend updating lib/kotext in HEAD, I'm quite sure this will fix the bug.
Please check that you have lib/kotext/kotextformat.cc rev 1.82?

In branch, I'm puzzled. Are you _sure_ you're testing the branch? I changed
configure.in.in in HEAD so that it shows "1.3post", to differenciate with
branch's "1.3". Also check with   ldd $KDEDIR/lib/kde3/libkwordpart.so | grep kotext
that it's finding the libkotext for KOffice-1.3, not the one for HEAD. Hmm, it's BIC
so it would crash if it did, I think.

Comment 6 Wolfgang Westphal 2004-02-23 18:05:01 UTC
------- Additional Comment #5 From David Faure 2004-02-23 11:25 ------- 
>OK it definitely works fine in HEAD and in branch for me. 
>
>I recommend updating lib/kotext in HEAD, I'm quite sure this will fix
>the bug. 
>Please check that you have lib/kotext/kotextformat.cc rev 1.82? 

~/src/kde/koffice/lib/kotext > grep kotextformat.cc CVS/Entries
/kotextformat.cc/1.82/Fri Feb 20 19:52:23 2004//

Seems so.

>In branch, I'm puzzled. Are you _sure_ you're testing the branch?

At the moment I only have HEAD installed. But before that I had the
stable version, installed using the Gentoo package, not from CVS. That
version showed the same behaviour. Actually that was the reason to give
HEAD a try.

Comment 7 David Faure 2004-02-23 18:34:27 UTC
On Monday 23 February 2004 18:05, Wolfgang Westphal wrote:
> ~/src/kde/koffice/lib/kotext > grep kotextformat.cc CVS/Entries
> /kotextformat.cc/1.82/Fri Feb 20 19:52:23 2004//

Did you check that the libkotext installed by that directory, is the one
that libkwordpart.so links to, using ldd?

Did you check in the 'font properties' dialog, what were the shadow parameters
for that text? You'll see if some shadow was selected - maybe its gray is too light
for your screen? :)

Here's a hint that can be useful to debug this problem: press Ctrl+Shift+V in kword
outputs lots of info about the formats - paste me a bit of it and I'll see if the
formats are correct. But I still think it's your libkotext that is the problem.

Comment 8 Wolfgang Westphal 2004-02-24 09:21:23 UTC
OK, I'm convinced now that is indeed no koffice bug. I compiled and installed the very same sources on a different machine in a "non-gentoo-like" KDE environment and there it works as expected. So I suppose it's a Gentoo specific issue. I "only" have to find out now what the crucial difference between those two installations is.

Closing this report though, as it is probably no koffice bug. Sorry for stealing your time.