Bug 75517 - after applying ad-hoc filters the wrong message is shown
Summary: after applying ad-hoc filters the wrong message is shown
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: filtering (show other bugs)
Version: 1.6.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 72754 78909 82770 86064 86204 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-02-18 15:08 UTC by Robin Rosenberg
Modified: 2007-09-14 12:17 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Rosenberg 2004-02-18 15:08:12 UTC
Version:           1.6.1 (using KDE 3.2 BRANCH >= 20040204, Mandrake Linux Cooker i586 - Cooker)
Compiler:          gcc version 3.3.2 (Mandrake Linux 10.0 3.3.2-4mdk)
OS:          Linux (i686) release 2.4.22-26mdk

If I choose "Classify as SPAM" in a folder, the mail gets moved to the spam folder, but the text remains visible in the message pane. If only one mail remains in the folder it is impossible (AFAIK) to see the text of that mail without going to another folder and then back.
Comment 1 Amilcar do Carmo Lucas 2004-02-18 16:16:53 UTC
CVS commit by aclu: 

Fix a big configure bug.

CCMAIL: 75517-done@bugs.kde.org


  M +23 -4     configure.in.in   1.70
  M +68 -2     buildtools/Makefile.am   1.4



Comment 2 Amilcar do Carmo Lucas 2004-02-18 16:46:19 UTC
Oops I misstyped my commit. The commit fixes bug 75515
Comment 3 Ingo Klöcker 2004-02-18 17:00:33 UTC
This is a more general bug. Therefore I've changed the summary.

After applying an ad-hoc filter the next message will become the current message. But the message which the filter was applied to is still shown in the preview pane.
Comment 4 Justin Mason 2004-04-15 20:48:30 UTC
Yes, this is biting me too.

I'm one of the SpamAssassin developers, so maintaining a corpus of ham/spam mails is very important to me; to this end, I generally do not delete mails, instead moving them to "deleted-ham" and "spam" folders.  I do this in ExMH currently using 2 keyboard bindings, one for "refile message(s) as spam", one for "refile message(s) as deleted-ham".

To support this in KMail, I've been trying out filters bound to keys.  Here's one for this example:

Filter Name: delete as ham
Match all of following:
   Subject matches RE ".*"
   [ie. a "match anything" condition]
Filter actions:
   file into folder _deld
Apply this filter on manual filtering
If this filter matches, stop here
Add this filter to the Apply Filter Actions menu

I then have a keybinding from "s" to that Filter action.

Now, this is a great idea, credit to you guys for coming up with it.  A very nice way to script these things! ;)

However, there's a bug in how the UI reacts to this, as follows.

1. I select 1 message from my inbox
2. press 'S'
3. message is refiled as expected
4. the next message in the Message List pane is highlighted

however, this is the bug: it is an unfocused highlight -- the one with the dotted box only, instead of dotted box and highlight background colour.  The results are that the message text box still displays the refiled message's text (however I don't really care about this) and (more importantly, to read the next message, I must either (a) click again on that message to highlight it correctly, or (b) press "Down", "Up" cursor keys to do the same.

The same applies if multiple messages are selected and refiled using the filter, BTW.

Something wierd happens if I press "Delete", however; the message text pane updates, the current selection in the message list pane is set to highlight the unfocused-but-selected message, I can read the message, I can press 'S' or whatever and it'll work.  Everything is as it should be, in other words.   I don't know what else the "Delete" key might be doing in this case ;) but it does seem like a work-around.

My suggestion would be: either make whatever the 'Delete' key is doing, the default behaviour after a Filter is applied; or else add a checkbox to the Filters dialog to allow that behaviour to be chosen by the user for their Filter.

(thanks, BTW!  Apart from this, KMail might just be about to become my main mail UI -- which is saying something considering I live in my mailreader! ;)

Comment 5 Justin Mason 2004-04-15 21:05:21 UTC
BTW looks like bug 72754 may be a dupe of this (although already marked RESOLVED)
Comment 6 Andreas Gungl 2004-06-03 14:59:57 UTC
*** Bug 82770 has been marked as a duplicate of this bug. ***
Comment 7 Stephan Binner 2004-06-19 12:21:10 UTC
*** Bug 78909 has been marked as a duplicate of this bug. ***
Comment 8 Andreas Gungl 2004-07-27 09:22:41 UTC
*** Bug 86064 has been marked as a duplicate of this bug. ***
Comment 9 Andreas Gungl 2004-07-29 16:01:53 UTC
*** Bug 86204 has been marked as a duplicate of this bug. ***
Comment 10 Luis Miguel García 2004-07-29 17:09:00 UTC
Well... this bug seems to be present in current-cvs.

I think the same action as when I delete a message must be performed:

- Pointer moved to next message (already done)
- Display that "next message" on the preview pane (that don't happens).


Thanks.
Comment 11 Andreas Gungl 2004-07-29 22:34:59 UTC
*** Bug 72754 has been marked as a duplicate of this bug. ***
Comment 12 Andreas Gungl 2004-07-31 21:45:25 UTC
CVS commit by gungl: 

fix Bug 75517 - kmail virus scan not working
Thanks to Don Sanders.

CCMAIL: 75517-done@bugs.kde.org


  M +3 -0      kmcommands.cpp   1.163


--- kdepim/kmail/kmcommands.cpp  #1.162:1.163
@@ -1430,4 +1430,7 @@ void KMMetaFilterActionCommand::start()
   *mHeaders->selectedMsgs(), mFilter);
   filterCommand->start();
+  int contentX, contentY;
+  KMHeaderItem *item = mHeaders->prepareMove( &contentX, &contentY );
+  mHeaders->finalizeMove( item, contentX, contentY );
 #endif
 }


Comment 13 Luis Miguel García 2004-07-31 23:33:14 UTC
it's fixed now.

Thanks!!