Version: 3.0.0 (using KDE Devel) Installed from: Compiled sources Compiler: gcc (GCC) 3.3.1 (SuSE Linux) OS: Linux When debug a program and it ends normally, then the CPU-usage goes up although KDevelop shows me "Program exited normally" in the status bar. In the process-table KDevelop uses all the CPU. Gdb is still running but using 0 % CPU. I have to explicitely stop debugging from KDevelop to stop gdb and then KDevelop stops using the CPU. (It's annoying because: You loose CPU-power that would be needed for other things, or because the battery on notebooks won't last long, or because the CPU-fan goes on, etc.) (My gdb version is 5.3.92.)
Yes, I see the same behaviour. (GDB version 5.3) IIRC, John explained to me once why we don't stop the debugger when the debugged program finishes, but I'll be damned if I remember it...
I've seen this with gdb 6.0 too, but I don't see it often. The debugger should not be stopped in case the user wants to restart the program without having to free and reload all of the symbols, which can take time especially with computers which have limited ram. This doesn't excuse the cpu hogging though.
Here's where I caught kdevelop when it last did this to me... maybe gdb is continually outputting data? dunno, have to look next time. [New Thread 1109772864 (LWP 1777)] [New Thread 1132096432 (LWP 1783)] [New Thread 1109772864 (LWP 1777)] [New Thread 1132096432 (LWP 1783)] [New Thread 1109772864 (LWP 1777)] [New Thread 1132096432 (LWP 1783)] 0x41a28411 in __waitpid_nocancel () from /lib/tls/libpthread.so.0 #0 0x41a28411 in __waitpid_nocancel () from /lib/tls/libpthread.so.0 #1 0x40e3616e in KCrash::defaultCrashHandler(int) () from /opt/kde/lib/libkdecore.so.4 #2 <signal handler called> #3 0x41a274a1 in __read_nocancel () from /lib/tls/libpthread.so.0 #4 0x42d90f55 in GDBDebugger::STTY::OutReceived(int) (this=0xa42f470, f=10) at ../../kdevelop/languages/cpp/debugger/stty.cpp:260 #5 0x42d9179b in GDBDebugger::STTY::qt_invoke(int, QUObject*) ( this=0xa42f470, _id=2, _o=0xbffff080) at stty.moc:126 #6 0x412a15ce in QObject::activate_signal(QConnectionList*, QUObject*) ( this=0x8cb1288, clist=0xa0fab10, o=0xbffff080) at kernel/qobject.cpp:2333 #7 0x412a1988 in QObject::activate_signal(int, int) (this=0x8cb1288, signal=2, param=10) at kernel/qobject.cpp:2426 #8 0x41669265 in QSocketNotifier::activated(int) (this=0x8cb1288, t0=10) at .moc/debug-shared-mt/moc_qsocketnotifier.cpp:85 #9 0x412c5f21 in QSocketNotifier::event(QEvent*) (this=0x8cb1288, e=0xbffff380) at kernel/qsocketnotifier.cpp:271 #10 0x412310bb in QApplication::internalNotify(QObject*, QEvent*) ( this=0xbffff5e0, receiver=0x8cb1288, e=0xbffff380) at kernel/qapplication.cpp:2582 #11 0x41230542 in QApplication::notify(QObject*, QEvent*) (this=0xbffff5e0, receiver=0x8cb1288, e=0xbffff380) at kernel/qapplication.cpp:2305 #12 0x40d94964 in KApplication::notify(QObject*, QEvent*) () from /opt/kde/lib/libkdecore.so.4 #13 0x411bab88 in QApplication::sendEvent(QObject*, QEvent*) ( receiver=0x8cb1288, event=0xbffff380) at qapplication.h:492 #14 0x4121c7f3 in QEventLoop::activateSocketNotifiers() (this=0x80d5c78) at kernel/qeventloop_unix.cpp:579 #15 0x411ce21d in QEventLoop::processEvents(unsigned) (this=0x80d5c78, flags=4) at kernel/qeventloop_x11.cpp:340 #16 0x4124a5dd in QEventLoop::enterLoop() (this=0x80d5c78) at kernel/qeventloop.cpp:198 #17 0x4124a4f6 in QEventLoop::exec() (this=0x80d5c78) at kernel/qeventloop.cpp:145 #18 0x4123125d in QApplication::exec() (this=0xbffff5e0) at kernel/qapplication.cpp:2705 #19 0x080653bb in main (argc=1, argv=0xbffff794) at ../../kdevelop/src/main.cpp:128
I investigated a bit and found the following comment in languages/cpp/debugger/gdbcontroller.cpp before method GDBController::programNoApp() > // There is no app anymore. This can be caused by program exiting > // an invalid program specified or ... > // gdb is still running though, but only the run command (may) make sense > // all other commands are disabled. If run is the only command that makes sense, it's probably best to stop gdb completely when the program terminates. Joachim
If we can't at least fix the cpu hogging, we should make sure to stop gdb.
I got the same problem and i find it really annoying. If the cpu would be unburdened and running a new debug session works well without restarting the debugger, leaving the debugger running could be fine, but as long as it doesn't work well, gdb should really be stopped.
This has actually stopped happening for me in HEAD. Anyone else?
CVS commit by dagerbo: Looks like this is still a problem, and in this case a buggy feature is definitely worse than no feature at all. So.. stop gdb when the program exits and the debugging session ends. BUGS: 73946 M +2 -3 debuggerpart.cpp 1.107 --- kdevelop/languages/cpp/debugger/debuggerpart.cpp #1.106:1.107 @@ -891,10 +891,9 @@ void DebuggerPart::slotStatus(const QStr stateChanged( QString("stopped") ); KActionCollection *ac = actionCollection(); - ac->action("debug_run")->setText( i18n("Restart") ); -// ac->action("debug_run")->setIcon( "1rightarrow" ); + ac->action("debug_run")->setText( i18n("Start") ); ac->action("debug_run")->setToolTip( i18n("Restart the program in the debugger") ); ac->action("debug_run")->setWhatsThis( i18n("Restart in debugger\n\n" "Restarts the program in the debugger") ); -// slotStop(); + slotStop(); } else
In fact, fixing the original bug is as simple as adding: delete tty_; tty_ = 0; to GDBController::programNoApp. With that, I can revert the last change, and the debugger is not stopped after application is stopped, and KDevelop no longer eats 100% of CPU. Will commit the change soon.
SVN commit 450506 by vprus: Improve start/stop behaviour of the debugger. - When application exists, don't kill the debugger. So, we don't need to restart debugger again, and restarting can be very slow due to loading numerous symbols. Also, now the debugger windows don't disappear when applications exists, only when user explicitly stops the debugger, so - he can look at gdb output - the variables window is not constantly shown/hidden when restarting debugger - Add "Restart" action that runs the program from the beginning without restarting the debugger. * debuggerpart.cpp (DebuggerPart::slotStatus): Revert revision 377895 that introduced "stop debugger on application exit" behaviour in attempt to workaround bug 73946. (DebuggerPart::DebuggerPart): Create new action. It turns out we even have icon for it already. * gdbcontroller.cpp (GDBController::programNoApp): Really fix bug 73946. (GDBController::slotRestart): New slot. CCBUG: 73946 BUG: 108534 CCMAIL: kdevelop-devel@kdevelop.org M +1 -0 dbgcontroller.h M +24 -2 debuggerpart.cpp M +1 -0 debuggerpart.h M +19 -1 gdbcontroller.cpp M +1 -0 gdbcontroller.h M +2 -0 kdevdebugger.rc --- branches/KDE/3.5/kdevelop/languages/cpp/debugger/dbgcontroller.h #450505:450506 @@ -95,6 +95,7 @@ virtual void slotStopDebugger() = 0; virtual void slotRun() = 0; + virtual void slotRestart() = 0; virtual void slotRunUntil(const QString &fileName, int lineNum) = 0; virtual void slotJumpTo(const QString &fileName, int lineNum) = 0; virtual void slotStepInto() = 0; --- branches/KDE/3.5/kdevelop/languages/cpp/debugger/debuggerpart.cpp #450505:450506 @@ -176,6 +176,16 @@ "while it is running, in order to get information " "about variables, frame stack, and so on.") ); + action = new KAction(i18n("&Restart"), "dbgrestart", 0, + this, SLOT(slotRestart()), + actionCollection(), "debug_restart"); + action->setToolTip( i18n("Restart program") ); + action->setWhatsThis( i18n("<b>Restarts application</b><p>" + "Restarts applications from the beginning." + ) ); + action->setEnabled(false); + + action = new KAction(i18n("Sto&p"), "stop", 0, this, SLOT(slotStop()), actionCollection(), "debug_stop"); @@ -782,6 +792,14 @@ controller->slotRun(); } +void DebuggerPart::slotRestart() +{ + // We could have directly connect KAction to controller->slotRestart() + // but controller is created after actions, and I did not want to + // create unconnected action and connect it later, as it would make + // it harder to understand the code. + controller->slotRestart(); +} void DebuggerPart::slotExamineCore() { @@ -948,6 +966,7 @@ if (state & s_dbgNotStarted) { stateIndicator = " "; + mainWindow()->lowerView(variableWidget); } else if (state & s_appBusy) { @@ -964,8 +983,6 @@ ac->action("debug_run")->setToolTip( i18n("Restart the program in the debugger") ); ac->action("debug_run")->setWhatsThis( i18n("Restart in debugger\n\n" "Restarts the program in the debugger") ); - slotStop(); - mainWindow()->lowerView(variableWidget); } else { @@ -984,6 +1001,11 @@ } } + // If program is started, enable the 'restart' comand. + actionCollection()->action("debug_restart")->setEnabled( + !(state & s_programExited)); + + // As soon as debugger clears 's_appNotStarted' flag, we // set 'justRestarted' variable. // The other approach would be to set justRestarted in slotRun, slotCore --- branches/KDE/3.5/kdevelop/languages/cpp/debugger/debuggerpart.h #450505:450506 @@ -68,6 +68,7 @@ void slotActivePartChanged(KParts::Part*); void slotRun(); + void slotRestart(); void slotExamineCore(); void slotAttachProcess(); void slotStopDebugger(); --- branches/KDE/3.5/kdevelop/languages/cpp/debugger/gdbcontroller.cpp #450505:450506 @@ -438,6 +438,12 @@ viewedThread_ = -1; currentFrame_ = 0; + // Delete the tty that waits for application output. Without + // this, KDevelop will be hanging, eating 100% CPU. Don't know + // why and don't understand this TTY stuff either. + delete tty_; + tty_ = 0; + frameStack_->clear(); if (msgBox) @@ -1474,6 +1480,18 @@ } } + +void GDBController::slotRestart() +{ + if (stateIsOn(s_dbgNotStarted|s_shuttingDown)) + return; + + if (stateIsOn(s_appBusy)) + pauseApp(); + + queueCmd(new GDBCommand("run", RUNCMD, NOTINFOCMD, 0)); +} + // ************************************************************************** void GDBController::slotRunUntil(const QString &fileName, int lineNum) @@ -2006,7 +2024,7 @@ emit debuggerRunError(127); destroyCmds(); - state_ = s_appNotStarted|s_programExited|(state_&(s_viewLocals|s_shuttingDown)); + state_ = s_dbgNotStarted|s_appNotStarted|s_programExited|(state_&(s_viewLocals|s_shuttingDown)); emit dbgStatus (i18n("Process exited"), state_); emit gdbStdout("(gdb) Process exited\n"); --- branches/KDE/3.5/kdevelop/languages/cpp/debugger/gdbcontroller.h #450505:450506 @@ -96,6 +96,7 @@ void slotStopDebugger(); void slotRun(); + void slotRestart(); void slotRunUntil(const QString &filename, int lineNum); void slotJumpTo(const QString &filename, int lineNum); void slotStepInto(); --- branches/KDE/3.5/kdevelop/languages/cpp/debugger/kdevdebugger.rc #450505:450506 @@ -6,6 +6,7 @@ <Action name="debug_run" group="debug"/> <Action name="debug_stop" group="debug"/> <Action name="debug_pause" group="debug"/> + <Action name="debug_restart" group="debug"/> <Action name="debug_runtocursor" group="debug"/> <Action name="debug_jumptocursor" group="debug"/> <Separator group="debug"/> @@ -27,6 +28,7 @@ <ToolBar name="debugToolBar"> <text>Debugger Toolbar</text> <Action name="debug_run"/> + <Action name="debug_restart"/> <Action name="debug_stepover"/> <Action name="debug_stepinto"/> <Action name="debug_stepout"/>