Bug 73894 - When changing a value the 'Save' button is not activated
Summary: When changing a value the 'Save' button is not activated
Status: RESOLVED FIXED
Alias: None
Product: kwalletmanager
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-31 17:06 UTC by Stefanos Harhalakis
Modified: 2004-03-15 01:21 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefanos Harhalakis 2004-01-31 17:06:34 UTC
Version:           1.0 (using KDE 3.2.0 RC1, compiled sources)
Compiler:          gcc version 3.3.2
OS:          Linux (i686) release 2.6.1

You cannot change a value in kwalletmanager and save it unless you create and delete a new entry... This is required for the 'save/undo' buttons to be activated.

Just open kwallet manager and go to some form data. The double click on the value and change it. I believe that at this point the 'save' button should be activated.

Also, It would be nice if the right click on a name/value had the option 'Edit' too.

TIA

<<V13>>
Comment 1 George Staikos 2004-01-31 17:28:13 UTC
Subject: Re:  New: When changing a value the 'Save' button is not activated

On Saturday 31 January 2004 11:06, v13@priest.com wrote:
> You cannot change a value in kwalletmanager and save it unless you create
> and delete a new entry... This is required for the 'save/undo' buttons to
> be activated.
>
> Just open kwallet manager and go to some form data. The double click on the
> value and change it. I believe that at this point the 'save' button should
> be activated.
>
> Also, It would be nice if the right click on a name/value had the option
> 'Edit' too.

  Which Qt version are you using?  I had one other person report this, but I 
can't reproduce it and I think it's a Qt bug.

Comment 2 Stefanos Harhalakis 2004-01-31 23:45:04 UTC
Subject: Re:  When changing a value the 'Save' button is not activated

On Saturday 31 January 2004 18:28, George Staikos wrote:
> On Saturday 31 January 2004 11:06, v13@priest.com wrote:
> > You cannot change a value in kwalletmanager and save it unless you create
> > and delete a new entry... This is required for the 'save/undo' buttons to
> > be activated.
> >
> > Just open kwallet manager and go to some form data. The double click on
> > the value and change it. I believe that at this point the 'save' button
> > should be activated.
> >
> > Also, It would be nice if the right click on a name/value had the option
> > 'Edit' too.
>
>   Which Qt version are you using?  I had one other person report this, but
> I can't reproduce it and I think it's a Qt bug.

I'm using a qt from rsync (3.2.2-snapshot-20031023)... I'll try a newer 
version of qt and I'll send a  feedback...

<<V13>>
Comment 3 Stefanos Harhalakis 2004-02-15 17:12:59 UTC
Just tested this on a fresh install of kde 3.2 on another debian based machine using 3.2.3-snapshot-20040131 and it had the same behaviour.

(qt+kde were compiled by hand from sources)

<<V13>>
Comment 4 George Staikos 2004-02-15 17:18:18 UTC
On Sunday 15 February 2004 11:13, v13@priest.com wrote:
> Just tested this on a fresh install of kde 3.2 on another debian based
> machine using 3.2.3-snapshot-20040131 and it had the same behaviour.
>
> (qt+kde were compiled by hand from sources)

  Which Qt version (exactly, and where did you get it from)?

Comment 5 Stefanos Harhalakis 2004-02-15 21:04:11 UTC
$ kde-config --version
Qt: 3.2.3-snapshot-20040131
KDE: 3.2.0
kde-config: 1.0

I've got it using rsync from rsync://rsync.trolltech.com/qt32

As the version says, I've got it at 31 Jan 2004.

<<V13>>
Comment 6 George Staikos 2004-02-16 00:22:59 UTC
On Sunday 15 February 2004 15:04, v13@priest.com wrote:
> ------- Additional Comments From v13 priest com  2004-02-15 21:04 -------
> $ kde-config --version
> Qt: 3.2.3-snapshot-20040131
> KDE: 3.2.0
> kde-config: 1.0
>
> I've got it using rsync from rsync://rsync.trolltech.com/qt32
>
> As the version says, I've got it at 31 Jan 2004.

  Ok I need you to use a stable Qt 3.2 release and report back please.  No 
snapshots.

Comment 7 carl 2004-03-13 17:59:37 UTC
I observe the same behavior.  I am using the debian libqt3c102-mt version 3.2.3-2 package from the debian sarge (testing) distribution.

The save button remains grey when I change a value in a map.  I can get the save button to activate by modifying any key as well as inserting a new kv pair and then deleting it.  But modifying a value always leaves the save button grey for me.
Comment 8 George Staikos 2004-03-15 01:21:17 UTC
CVS commit by staikos: 

hack to make editting values work in all cases

CCMAIL: 73894-done@bugs.kde.org


  M +6 -1      kwmapeditor.cpp   1.6
  M +1 -0      kwmapeditor.h   1.4


--- kdeutils/kwallet/kwmapeditor.cpp  #1.5:1.6
@@ -104,4 +104,9 @@ void KWMapEditor::addEntry() {
 
 
+void KWMapEditor::emitDirty() {
+        emit dirty();
+}
+
+
 void KWMapEditor::contextMenu(int row, int col, const QPoint& pos) {
         Q_UNUSED(row)
@@ -117,5 +122,5 @@ class InlineEditor : public QTextEdit {
         public:
                 InlineEditor(KWMapEditor *p, int row, int col) : QTextEdit(), _p(p), row(row), col(col) { setWFlags(WStyle_NoBorder | WDestructiveClose); KWin::setType(winId(), NET::Override); }
-                virtual ~InlineEditor() { _p->setText(row, col, text()); }
+                virtual ~InlineEditor() { _p->setText(row, col, text()); _p->emitDirty(); }
 
         protected:

--- kdeutils/kwallet/kwmapeditor.h  #1.3:1.4
@@ -39,4 +39,5 @@ class KWMapEditor : public QTable {
                 void contextMenu(int row, int col, const QPoint& pos);
                 void addEntry();
+                void emitDirty();
 
         protected: