Bug 73750 - Wrongly handled underline/reverse effects
Summary: Wrongly handled underline/reverse effects
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-29 12:58 UTC by leo zhu
Modified: 2004-04-20 14:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description leo zhu 2004-01-29 12:58:20 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.3.1 
OS:          Linux

The problem is, when you try to display some words with underline or reverse effect, the konsole can't handle them correctly. 

Steps to repeat it:
1) modify /etc/DIR_COLORS

DIR 01;35;04;07

and run

eval `/bin/dircolors -b /etc/DIR_COLORS`

to make the change effective. In this way, the dir. would have an underline/reverse effect in "ls -l" mode.

2) make a new directory with a long name, for example
mkdir 'aaaaaaaaaa           bbbbbbbbbbb         ccccccccccc'

ls -l would show an underline extends to the end of the second line, which isn't correct.
Comment 1 Stephan Binner 2004-02-15 18:11:59 UTC
Second line? You mean "make directory long enough that it doesn't fit into one terminal line"? Works here with and without line break in the directory name.
Comment 2 leo zhu 2004-03-26 09:51:42 UTC
the bug still exists in kde 3.2.1

here is a screenshot
http://61.153.200.30/lucida/konsole-bug.png

This might not happen with the first "ls -l", but would appear in a 2nd or 3rd try.




Comment 3 leo zhu 2004-04-20 10:35:07 UTC
The bug still exists in kde 3.2.2(konsole 1.3.2) . A quick way to reproduce the bug is to run the below command in an 80x25 konsole terminal:

$ echo -e '\033[33;04maaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\033[00m'

The underline extends to the end of second line in this case, which isn't correct. The same problem exists for reverse property(\033[7m). 
Comment 4 Waldo Bastian 2004-04-20 14:46:31 UTC
CVS commit by waba: 

Default rendition should be used when clearing screen areas (BR73750)
CCMAIL: 73750-done@bugs.kde.org


  M +6 -3      TEScreen.cpp   1.79.2.3


--- kdebase/konsole/konsole/TEScreen.cpp  #1.79.2.2:1.79.2.3
@@ -918,10 +918,13 @@ void TEScreen::clearImage(int loca, int 
     clearSelection();
   }
+  
   for (i = loca; i <= loce; i++)
   {
+    // Use the current colors but the default rendition
+    // Check with: echo -e '\033[41;33;07m\033[2Khello world\033[00m'
     image[i].c = c;
-    image[i].f = ef_fg; //DEFAULT_FORE_COLOR; //FIXME: xterm and linux/ansi
-    image[i].b = ef_bg; //DEFAULT_BACK_COLOR; //       many have different
-    image[i].r = ef_re; //DEFAULT_RENDITION;  //       ideas here.
+    image[i].f = cu_fg;
+    image[i].b = cu_bg;
+    image[i].r = DEFAULT_RENDITION;
   }