Bug 72347 - Searching in PDF files
Summary: Searching in PDF files
Status: RESOLVED FIXED
Alias: None
Product: kpdf
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Slackware Linux
: NOR wishlist
Target Milestone: ---
Assignee: Albert Astals Cid
URL:
Keywords:
: 75584 81951 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-01-11 01:28 UTC by Jesper Juhl
Modified: 2005-01-02 17:42 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch for Removing the "Find" and "Find Next" Actions (1.03 KB, patch)
2004-01-12 03:46 UTC, Henrique Pinto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesper Juhl 2004-01-11 01:28:06 UTC
Version:            (using KDE KDE 3.1.94)
Installed from:    Slackware Packages
OS:          Linux

When opening a file in kpdf I see the option to Search in the Edit menu, but nothing happens when selecting this option. Neither does the CTRL+F shortcut produce any result. This is a real problem when you have a large PDF and need to find some specific bit of information. I often read large technical documents as PDF, and not being able to search them is a major annoyance.
When watching PDF's with konqueror (I'm assuming it's kpdf it embeds) searching does not work either.

Why is the search option there in the first place when it does not work?

If it's supposed to work, and I'm just unlucky that all my PDF's happen to be non functional, then I can attach non-searchable PDF's to this bugreport as test cases upon request.  Here's one that's available online that is un-searchable : http://webster.cs.ucr.edu/Page_TechDocs/pfmt11.pdf
Comment 1 Henrique Pinto 2004-01-12 03:40:16 UTC
The bug indeed exists. The method find() in kpdf_part.h is empty, and obviously won't do anything. Considering we're in very deep freeze for KDE 3.2, the most appropriate action would be removing the associated actions. I'm attaching a patch for doing that.
Comment 2 Henrique Pinto 2004-01-12 03:46:43 UTC
Created attachment 4111 [details]
Patch for Removing the "Find" and "Find Next" Actions

The attached patch prevents the creation of the find-related actions. As
they're not created, they (obviously) won't show in the menus. When the slots
are properly implemented, the modified lines can be uncommented.
Comment 3 Sander Devrieze 2004-02-08 10:39:47 UTC
Not fixed in KDE 3.2: I hope the search functionality is in KDE 3.2.1 or that the search entries in the menu are removed because this isn't user friendly now.
Comment 4 Philippe Fremy 2004-02-18 15:21:01 UTC
I confirm that the search action is still there but does nothing... That's embarassing.
Comment 5 Christian Loose 2004-02-19 10:51:54 UTC
*** Bug 75584 has been marked as a duplicate of this bug. ***
Comment 6 Jose Hernandez 2004-02-23 07:09:45 UTC
Adding some votes.
Comment 7 Jesper Juhl 2004-02-27 17:49:43 UTC
Wishlist item #28898 is related to this bug.
Comment 8 Jesper Juhl 2004-03-18 01:07:10 UTC
No change in KDE 3.2.1
Comment 9 Waldo Bastian 2004-03-30 17:02:14 UTC
Removed from UI for KDE 3.2.2.

Leaving bugreport open for CVS HEAD.
Comment 10 Paulo Fidalgo 2004-04-14 22:36:32 UTC
Removing this from the UI is not the solution, because this is a great feature. This is the main reason that I still have xpdf, because it's the only one that can do that. Without the find function we don't need kpdf in the main kde distribution, because Kghostview does the job, I'm sorry for dev's but that's the true (at least from the user's point of view).

I've seen that kpdf uses xpdf  2.02pl1 version, why don't upgrade for 3.0.0 version?
Comment 11 Leo Spalteholz 2004-04-15 04:12:28 UTC
Kanniball, since the bug report is still open I think the plan is to implement searching text in head.  In the short term, removing the option from the UI is the solution.  Only thing worse than no search is a menu item for it that doesn't do anything.
Comment 12 Diederik van der Boor 2004-04-15 10:33:52 UTC
> Without the find function we don't need kpdf in the main kde distribution

Slightly off topic, but why are there two tools that seam to do the same thing? (ie showing pdf files)
Comment 13 Christophe Devriese 2004-04-15 11:17:50 UTC
On Wednesday 14 April 2004 22:36, Kanniball wrote:
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>
> http://bugs.kde.org/show_bug.cgi?id=72347
> kanniball zmail pt changed:
>
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- CC|                            |kanniball zmail pt
>
>
>
> ------- Additional Comments From kanniball zmail pt  2004-04-14 22:36
> ------- Removing this from the UI is not the solution, because this is a
> great feature. This is the main reason that I still have xpdf, because it's
> the only one that can do that. Without the find function we don't need kpdf
> in the main kde distribution, because Kghostview does the job, I'm sorry
> for dev's but that's the true (at least from the user's point of view).
>
> I've seen that kpdf uses xpdf  2.02pl1 version, why don't upgrade for 3.0.0
> version?

I haven't had the time for that yet.

Oelewapperke

Comment 14 Andrew Somerville 2004-04-15 15:53:29 UTC
> > Without the find function we don't need kpdf in the main kde distribution 
 
> Slightly off topic, but why are there two tools that seam to do the same thing? (ie showing pdf files)

I would argue the same point. I mean shouldn't we be working on a search functionality for kghostview, which is the better (and the standard) viewer. 
Comment 15 Christian Loose 2004-05-21 15:39:53 UTC
*** Bug 81951 has been marked as a duplicate of this bug. ***
Comment 16 Christian Loose 2004-07-21 22:16:46 UTC
not a bug anymore
Comment 17 Chris Johnson 2004-08-23 01:56:48 UTC
I tried this in KDE 3.3 and it is still not implemented. What did you mean by "not a bug anymore" Christian?
Comment 18 Leo Spalteholz 2004-08-23 03:29:30 UTC
Chris:  Originally there was a menu item to search in the PDF even though it wasn't implemented.  That was fixed.  Searching still doesn't work, but now it is a wishlist, not a bug.
Comment 19 Christian Loose 2004-08-23 11:54:48 UTC
Chris is right. The menu items were only removed in the KDE_3_2_BRANCH not in the (back then) CVS HEAD version. So with KDE 3.3, the menu items are back again while still missing the implementation.

Waldo?
Comment 20 Albert Astals Cid 2004-09-29 00:32:03 UTC
I've removed the options from the rc in 3.3 branch, so 3.3.1 will not have that menu entries. CVS HEAD has search on it, please test and report any bug you find (you'll find because it relies on xpdf find engine and that is quite buggy)
Comment 21 Albert Astals Cid 2005-01-02 17:42:22 UTC
Works in head since some time, closing