Bug 71851 - "Launch wallet manager" in kwalletmanager prefs does not make sense
Summary: "Launch wallet manager" in kwalletmanager prefs does not make sense
Status: RESOLVED FIXED
Alias: None
Product: kwalletmanager
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: VLO wishlist
Target Milestone: ---
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-04 20:04 UTC by Sashmit Bhaduri
Modified: 2004-01-27 07:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sashmit Bhaduri 2004-01-04 20:04:31 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

In kwalletmanager's prefs (Settings->Configure Wallet), there is a button to Launch Wallet Manager. It does not make sense in this context since the prefs were shown by the wallet manager (and not kcontrol)

I would suggest hiding it if showing that dialog from kwalletmanager, and showing it otherwise.
Comment 1 George Staikos 2004-01-04 23:27:19 UTC
That's not an embedded config panel, it's actually kcmshell and adding or removing that button requires quite a bit of code.  It's not really worth it.  Actually it's supposed to raise the wallet manager if it's already loaded, which is a feature.  I'll consider it if you still think it should be removed, but it is very very low priority.
Comment 2 George Staikos 2004-01-27 07:13:08 UTC
Subject: kdeutils/kwallet/konfigurator

CVS commit by staikos: 

I think this is against my better judgement, but if users are confused by it
then maybe it's for the best.  Hide the Launch Manager button if it's already
launched.  Sure it could be closed while the kcm is open, but that's a risk
I'm willing to take. :-)
CCMAIL: 71851-done@bugs.kde.org


  M +5 -0      konfigurator.cpp   1.17


--- kdeutils/kwallet/konfigurator/konfigurator.cpp  #1.16:1.17
@@ -66,4 +66,9 @@ KWalletConfig::KWalletConfig(QWidget *pa
         updateWalletLists();
         load();
+
+        if (DCOPClient::mainClient()->isApplicationRegistered("kwalletmanager")) {
+                _wcw->_launch->hide();
+        }
+
 }