Bug 71464 - Naming consistency for "grep"
Summary: Naming consistency for "grep"
Status: RESOLVED FIXED
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: grepview (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: 1.3.0
Assignee: KDevelop Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-30 06:46 UTC by Jon Smirl
Modified: 2013-03-31 01:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Smirl 2003-12-30 06:46:54 UTC
Version:           CVS (using KDE Devel)
Installed from:    Compiled sources

Am I just too dumb to figure this out? But how do you assign a keyboard shortcut to the grep function? I see grep on the right click menu, but it doesn't appear on the main menu. Doesn't it need to be on the main menu in order to assign a shortcut? It's not in the shortcut dialog either.
Comment 1 Harald Fernengel 2003-12-30 14:38:54 UTC
It is called "find in files", is in the "Edit" menu and has the shortcut CTRL-ALT-F.

Harry
Comment 2 Jon Smirl 2003-12-30 16:44:11 UTC
We should get some naming consistency here:

Main menu is: Find in files
Dialog says: Search in files
Output views says: grep
Right click says: grep
Comment 3 Harald Fernengel 2003-12-30 17:38:00 UTC
okay, keeping it as wishlist item for KDevelop >3.0 since we are in a message freeze and cannot change any strings until the release.
Comment 4 Jens Dagerbo 2003-12-30 18:33:52 UTC
I kinda wonder why it's in the "edit" menu to begin with.. :)
Comment 5 John Birch 2003-12-30 20:28:41 UTC
Well, the nameing inconsistency looks more like a bug to me :-), and if we stick to "Find in files" throughout I'm not sure where we'll run into translating problems since this is already translated?
Comment 6 Harald Fernengel 2004-01-02 16:29:36 UTC
The strings are already translated, but in different locations and I don't want to do a "potentially annoying the translators"-thing before the release :)
Comment 7 Jon Smirl 2004-01-02 17:07:46 UTC
Why can't you just pick one and use it and ignore the other two?
Comment 8 Harald Fernengel 2004-01-02 17:53:16 UTC
This will happen after the release, at the moment we cannot change any strings (or do something that will mess up the translation files) since KDE is in a message-freeze so that the translators can translate KDE in time for the KDE 3.2 release.
Comment 9 Jon Smirl 2004-01-02 18:01:47 UTC
I don't know exactly how KDE translation works, but can't you just use the id from one of the existing strings is the other places? That wouldn't be creating/changing a string, you'd just be using an existing string in new places.
Comment 10 Jesse 2004-01-03 06:01:12 UTC
I think we're allowed to 'remove' strings.  It's the addition of them that causes problems.

So there's already 'Find in files' within kdevelop.  Remove the other three and just use 'Find in files'
Comment 11 Amilcar do Carmo Lucas 2004-01-06 17:22:54 UTC
I also vote for "Find in files".

PS: Happy new year everybody!
Comment 12 Jesse 2004-01-11 07:41:54 UTC
Too late because of deep freeze?
Comment 13 Amilcar do Carmo Lucas 2004-06-26 20:04:01 UTC
CVS commit by aclu: 

Make the naming of the "Find in files" dialogs/menus consistent thoughout KDevelop.
CCMAIL: 71464-done@bugs.kde.org


  M +1 -1      grepdlg.cpp   1.27
  M +4 -4      grepviewpart.cpp   1.39
  M +1 -1      grepviewwidget.cpp   1.34


--- kdevelop/parts/grepview/grepdlg.cpp  #1.26:1.27
@@ -73,5 +73,5 @@ GrepDialog::GrepDialog( GrepViewPart * p
     : QDialog(parent, name, false), m_part( part )
 {
-    setCaption(i18n("Search in Files"));
+    setCaption(i18n("Find in files"));
 
     config = GrepViewFactory::instance()->config();

--- kdevelop/parts/grepview/grepviewpart.cpp  #1.38:1.39
@@ -52,5 +52,5 @@ GrepViewPart::GrepViewPart( QObject *par
     m_widget->setIcon(SmallIcon("find"));
     m_widget->setCaption(i18n("Grep Output"));
-    QWhatsThis::add(m_widget, i18n("<b>Grep</b><p>"
+    QWhatsThis::add(m_widget, i18n("<b>Find in files</b><p>"
                                    "This window contains the output of a grep "
                                    "command. Clicking on an item in the list "
@@ -59,5 +59,5 @@ GrepViewPart::GrepViewPart( QObject *par
                                    "with the match."));
 
-    mainWindow()->embedOutputView(m_widget, i18n("Grep"), i18n("Output of the grep command"));
+    mainWindow()->embedOutputView(m_widget, i18n("Find in files"), i18n("Output of the grep command"));
 
     KAction *action;
@@ -68,5 +68,5 @@ GrepViewPart::GrepViewPart( QObject *par
     action->setToolTip( i18n("Search for expressions over several files") );
     action->setWhatsThis( i18n("<b>Find in files</b><p>"
-                               "Opens the 'Search in Files' dialog. There you "
+                               "Opens the 'Find in files' dialog. There you "
                                "can enter a regular expression which is then "
                                "searched for within all files in the directories "
@@ -119,5 +119,5 @@ void GrepViewPart::contextMenu(QPopupMen
         int id = popup->insertItem( i18n("Grep: %1").arg(squeezed),
                            this, SLOT(slotContextGrep()) );
-        popup->setWhatsThis(id, i18n("<b>Grep</b><p>Opens the search in files dialog "
+        popup->setWhatsThis(id, i18n("<b>Grep</b><p>Opens the find in files dialog "
                                "and sets the pattern to a text under the cursor."));
         popup->insertSeparator();

--- kdevelop/parts/grepview/grepviewwidget.cpp  #1.33:1.34
@@ -307,5 +307,5 @@ void GrepViewWidget::popupMenu(QListBoxI
     if(KAction *findAction = m_part->actionCollection()->action("edit_grep")) {
         KPopupMenu rmbMenu;
-        rmbMenu.insertTitle(i18n("Grep"));
+        rmbMenu.insertTitle(i18n("Find in files"));
         findAction->plug(&rmbMenu);
         rmbMenu.exec(p);