Bug 71445 - text comes over images but goes correclty after resizing
Summary: text comes over images but goes correclty after resizing
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-29 19:45 UTC by Albert Astals Cid
Modified: 2004-02-28 20:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Before resizing text goes over the image (70.53 KB, image/png)
2003-12-29 19:49 UTC, Albert Astals Cid
Details
After resizing all is fine (70.44 KB, image/png)
2003-12-29 19:51 UTC, Albert Astals Cid
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2003-12-29 19:45:58 UTC
Version:           3.1.94 (using KDE 3.1.94 (CVS >= 20031206), compiled sources)
Compiler:          gcc version 3.3.1 (Mandrake Linux 9.2 3.3.1-2mdk)
OS:          Linux (i686) release 2.4.22-21mdk

As said, if i load www.badopi.org i can see text over the images, but if i resize konqueror, text goes around them as intended. If i save the web at my hard disk and load it from there it always loads correclty, so maybe has something to do with rendering the pages before having its full code.
Comment 1 Albert Astals Cid 2003-12-29 19:49:01 UTC
Created attachment 3876 [details]
Before resizing text goes over the image
Comment 2 Albert Astals Cid 2003-12-29 19:51:16 UTC
Created attachment 3877 [details]
After resizing all is fine
Comment 3 Kai Lahmann 2003-12-29 23:11:35 UTC
same here (20031105)
Comment 4 Germain Garand 2004-02-28 20:34:33 UTC
CVS commit by ggarand: 

as discussed on kfm-devel,
- displace the check for new floats invalidating the layout of remaining children. It was outside of loop (#71445).
- remove check for floatBottom() > m_y that seems outdated.

CCMAIL: 71445-done@bugs.kde.org


  M +7 -0      ChangeLog   1.223
  M +5 -6      rendering/render_block.cpp   1.32


--- kdelibs/khtml/ChangeLog  #1.222:1.223
@@ -1,2 +1,9 @@
+2004-02-28  Germain Garand  <germain@ebooksfrance.org>
+
+        * rendering/render_block.cpp (layoutBlockChildren):
+        - displace the check for if we need to relayout our childs 
+        because of a float. It was outside of loop (#71445)
+        - remove check for floatBottom() > m_y has it seems outdated.
+
 2004-02-25  Dirk Mueller  <mueller@kde.org>
 

--- kdelibs/khtml/rendering/render_block.cpp  #1.31:1.32
@@ -638,8 +638,4 @@ void RenderBlock::layoutBlockChildren( b
     //kdDebug() << "RenderBlock::layoutBlockChildren " << prevMargin << endl;
 
-    // take care in case we inherited floats
-    if (child && floatBottom() > m_height)
-        child->setLayouted( false );
-
     //     QTime t;
     //     t.start();
@@ -660,6 +656,5 @@ void RenderBlock::layoutBlockChildren( b
 
         // make sure we relayout children if we need it.
-        if ( relayoutChildren || floatBottom() > m_y ||
-             (child->isReplaced() && (child->style()->width().isPercent() || child->style()->height().isPercent())))
+        if ( relayoutChildren || (child->isReplaced() && (child->style()->width().isPercent() || child->style()->height().isPercent())))
             child->setLayouted( false );
 
@@ -800,4 +795,8 @@ void RenderBlock::layoutBlockChildren( b
         }
 
+        // take care in case we inherited floats
+        if (floatBottom() > m_height)
+            child->setLayouted(false);
+
         child->calcVerticalMargins();