Bug 71367 - Impossible to uncheck an entry without playing it.
Summary: Impossible to uncheck an entry without playing it.
Status: RESOLVED WORKSFORME
Alias: None
Product: noatun
Classification: Miscellaneous
Component: split (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Multimedia Developers
URL:
Keywords:
: 71369 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-12-28 16:58 UTC by Thomas Zander
Modified: 2004-10-04 12:51 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander 2003-12-28 16:58:26 UTC
Version:           2.3.3 (using KDE 3.1.94 (CVS >= 20031206), compiled sources)
Compiler:          gcc version 3.3.2 (Debian)
OS:          Linux (i686) release 2.6.0dell-optiplex

In the 'split' playlist a checkbox is shown in from of each entry.

Unfortunately the file can not be unchecked without also selecting the entry so playback starts.

Furthermore the 'next'/'prev' entries on noatun cause the entries that are unchecked to be played so the checkboxes don't even work..
Comment 1 Allan Sandfeld 2003-12-28 17:29:36 UTC
*** Bug 71369 has been marked as a duplicate of this bug. ***
Comment 2 Allan Sandfeld 2003-12-28 17:33:46 UTC
Subject: kdemultimedia/noatun/modules/splitplaylist

CVS commit by carewolf: 

Make previous skip unchecked items (next already does).

CCMAIL:71367@bugs.kde.org


  M +4 -0      playlist.cpp   1.50


--- kdemultimedia/noatun/modules/splitplaylist/playlist.cpp  #1.49:1.50
@@ -145,4 +145,8 @@ PlaylistItem SplitPlaylist::previous()
         setCurrent(nextItem);
 
+        if (currentItem)
+                if (!static_cast<SafeListViewItem*>(currentItem.data())->isOn())
+                        return previous();
+
         return currentItem;
 }


Comment 3 Stefan Gehn 2003-12-28 18:44:39 UTC
I guess checklistitems and single-click-annoyan...errrr.behaviour don't play together very well.
Tell me if you can find an application with checklistitems which works and I'll check how to fix it in splitplaylist.
Comment 4 Allan Sandfeld 2003-12-28 19:45:20 UTC
The problem is that the checkbox is included in the filename, and KListView sends an executed()-signal on all clicks on that coloumn. It could be solved by giving the checkboxes their own coloumn, or overloading isExecuteArea().

Btw. A workaround is to press CTRL while clicking.
Comment 5 Thomas Zander 2003-12-28 19:52:28 UTC
Another thing that is kind of broken is how noatun starts to play an entry that is unselected when I click on it.
If that part is fixed (don't start playing an entry when its unchecked) AND you make sure the checkbox is updated on click, before the emit is done, then you solved the problem.
Comment 6 Charles Samuels 2004-10-04 12:51:00 UTC
also right clicking on the checkbox.

I want clicking on an unchecked item to cause it to play.  This just seems reasonable to me.