Bug 70937 - Erroneous play queue flow control
Summary: Erroneous play queue flow control
Status: RESOLVED FIXED
Alias: None
Product: noatun
Classification: Unmaintained
Component: split (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Charles Samuels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-20 21:57 UTC by Benedikt Gollatz
Modified: 2004-10-04 12:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benedikt Gollatz 2003-12-20 21:57:36 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc (GCC) 3.3.1 
OS:          Linux

Splitplaylist acts unexpected in a few cases.

First, when hitting "back" it jumps to the file above and plays it regardless of whether it isOn() or not. This can easily be corrected by adding three lines to playlist.cpp:

--- kdemultimedia/noatun/modules/splitplaylist/playlist.cpp	2003-11-16 21:42:37.000000000 +0100
+++ kdemultimedia/noatun/modules/splitplaylist/playlist.cpp	2003-12-20 21:44:41.000000000 +0100
@@ -144,4 +144,8 @@
 
 	setCurrent(nextItem);
+	
+	if (currentItem)
+		if (!static_cast<SafeListViewItem*>(currentItem.data())->isOn())
+			return previous();
 
 	return currentItem;

The problem with this is, that the playlist does not loop backwards.

Additionally, when leaving the last item of the playlist unchecked, Splitplaylist loops to the first checked file but plays the last (unchecked) file on the list.
Comment 1 Charles Samuels 2004-10-04 12:30:15 UTC
commited fix to this recently