Bug 70332 - Wallet manager startup wizard allows "next" on password dialog when password is empty
Summary: Wallet manager startup wizard allows "next" on password dialog when password ...
Status: RESOLVED FIXED
Alias: None
Product: kwalletmanager
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-13 18:25 UTC by Oded Arbel
Modified: 2005-10-20 14:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oded Arbel 2003-12-13 18:25:35 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc 3.3.1 
OS:          Linux

In the kdewallet startup wizard (the one being run when you first enter a password in an application that uses kdewallet), in advanced mode, when reaching the step where a password need to be entered, the "next" button is always enabled even when the password is empty or the two password inputs do not match. 
Of course, when pressing "next", in the next step "finish" is disabled until the password is not empty and both fields match, but this is very confusing and often people won't understand why the finish is disabled as usually buttons only pertain to the current step's information.

If there is a problem with any of the steps data, that would prevent the wizard from completing, that step's "next" button needs to be disabled, and not the wizard's "finish" button.
Comment 1 George Staikos 2003-12-17 11:24:33 UTC
Subject: kdelibs/kio/misc/kwalletd

CVS commit by staikos: 

Disable "Next" in the wizard in advanced mode when the passwords don't match.

CCMAIL: 70332-done@bugs.kde.org


  M +1 -0      kwalletwizard.ui   1.5
  M +2 -2      kwalletwizard.ui.h   1.5


--- kdelibs/kio/misc/kwalletd/kwalletwizard.ui  #1.4:1.5
@@ -520,4 +520,5 @@
 <includes>
     <include location="global" impldecl="in declaration">qcheckbox.h</include>
+    <include location="global" impldecl="in implementation">klocale.h</include>
     <include location="local" impldecl="in implementation">kwalletwizard.ui.h</include>
 </includes>

--- kdelibs/kio/misc/kwalletd/kwalletwizard.ui.h  #1.4:1.5
@@ -8,6 +8,4 @@
 *****************************************************************************/
 
-#include <klocale.h>
-
 void KWalletWizard::passwordPageUpdate()
 {
@@ -18,4 +16,5 @@ void KWalletWizard::passwordPageUpdate()
     } else {
         fe = !_useWallet->isChecked() || ((_pass1->text() == _pass2->text()) && !_pass1->text().isEmpty());
+        setNextEnabled(page2, fe);
         setFinishEnabled(page3, fe);
     }
@@ -56,4 +55,5 @@ void KWalletWizard::setAdvanced()
     bool fe = !_useWallet->isChecked() || ((_pass1->text() == _pass2->text()) && !_pass1->text().isEmpty());
     setFinishEnabled(page2, false);
+    setNextEnabled(page2, fe);
     setFinishEnabled(page3, fe);
 }


Comment 2 gazel 2005-10-20 14:14:10 UTC
merci merci mercy very  much ... ou   se trouve  la commande  LANGUAAGE ? qui devrait se trouver en 1ère ligne de toute aoplication ... et  eviter cet     epouvantable  embouteillage style tour de Babel ou l'anglais occupe toute la place ... ceci dit      je n'ai rien contre la langue de Shakespear  ... mais ce n'est pas une raison pour ... etc     etc