Bug 69445 - Location toolbar moves up and down when closing tabs
Summary: Location toolbar moves up and down when closing tabs
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-01 16:34 UTC by Karl Vogel
Modified: 2008-10-15 16:13 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Vogel 2003-12-01 16:34:06 UTC
Version:            (using KDE KDE 3.1.94)
Installed from:    Compiled From Sources
OS:          Linux

When closing a tab in tabbed browsing mode, I see the screen flash shortly. After a while it struck me that the location toolbar moves right of the main toolbar (on the same row) and then moves to the second row again.
I have had this problem for quite some time.

In the past it sometimes happened when viewing other URL types (gif, jpg, ...) that this caused the location bar to move next to the main toolbar. I could then re-arrange my toolbars and it would be remembered. So I think this bug is caused by the default konqueror view to have the location bar in another position than my preferences, causing konq. to relayout the toolbars when closing a tab and then causing another relayout when switching to the tab that is left over.

E.g.

- my default toolbar layout is:
== main toolbar ==
== location toolbar ==

- when closing a tab, it quickly becomes:
== main toolbar == location toolbar ==

- then konqueror switches to a remaining tab, where it becomes this again:
== main toolbar ==
== location toolbar ==


All this switching is rather distracting. (All my View Profiles are saved with the same toolbar layout)

NOTE: my KDE source is built from nov 30 sources (3.1.94).
Comment 1 Mikolaj Machowski 2004-05-31 14:24:04 UTC
Confirming this for CVS-HEAD. When closing toolbars or fast switching between them toolbars are often rearranged which is very disctracting.
Comment 2 Mikolaj Machowski 2004-08-14 21:55:22 UTC
[ REGRESSION ]

Confirming this for CVS-HEAD from 13th August morning (before fork)?

It is really awful.
Comment 3 Michael Jahn 2004-09-07 19:17:54 UTC
Can you still reproduce this? I can't.
Comment 4 Mikolaj Machowski 2004-09-08 11:14:32 UTC
Recently cannot reproduce (CVS-HEAD) but I am trying to avoid
experiments. My head hurts when all display is jumping :/

Comment 5 Matt Rogers 2004-12-19 08:22:03 UTC
do you have to have your toolbars set up a certain way? i.e. does the location toolbar need to be configured to be on the same row as the main toolbar (even though it'll wrap to the next line if the toolbar doesn't fit). I can't reproduce this either
Comment 6 Karl Vogel 2005-01-03 09:57:15 UTC
I currently don't have the problem anymore.. but I'm now using the default layout. I think it was caused by the fact that the different views can have different toolbar layouts. I fixed it back then by going through all views and putting the toolbars each on a seperate row.
Comment 7 Kyryll A Mirnenko aka Mirya 2005-04-06 23:18:18 UTC
Confirmed. Have slow enough machine to watch it cleanly in 3.4. The strange thing is the issue is raised ONLY WHEN USING [C-W], but not when using [popup menu]+[CLose the tab].
Comment 8 Kyryll A Mirnenko aka Mirya 2005-04-07 21:07:52 UTC
Seems i've found the reason: that's google qucksearcher, when changing the tab, it's removed for a moment (and then readded if current tab contains html part), so that causes toolbars packing.
Comment 9 Mikolaj Machowski 2005-05-17 14:50:03 UTC
This is also caused by trying to add all icons/buttons for loaded kparts (like kpdf). solution could be not showing this icons automatically but give some hint that more buttons are available and show them only on request.
Comment 10 kavol 2006-05-25 13:23:26 UTC
I have a problem related to this ...

I prefer layout with location bar right to the main toolbar, i.e.

--Window title--------------------------kwin buttons-
| Main menu                                         |
-----------------------------------------------------
| icons (back, fwd, refresh ...) | Location: ______ |
-----------------------------------------------------
| tab1 | tab2 |                           close_tab |
-----------------------------------------------------
|                                                   |
|              .... HTML contents ....              |
|                                                   |
-----------------------------------------------------
| status bar                                        |
-----------------------------------------------------

sometimes, Konqueror goes mad and it shifts the location bar below the main toolbar (and aligns it to the left), and there is no way to convice it that I want to have these two in one line - dragging the location bar with mouse results only in swapping the positions, location bar getting higher (below the menu), but both bars keep aligned to the left, each of them occupying its own line

with this setup, I have observed exactly the thing described above - when the bars are below each other, it often happens, when closing tabs, that the location bar jumps up and right to my desired layout (thus increasing the html viewport size causing the page content jump up too) but it (usually) immediately returns to the separate-line layout (causing the page content jump back down too)

this effect is clearly visible even on quite fast machine, and especially when using X over (slow) network
Comment 11 Joseph Kerian 2006-08-30 20:20:13 UTC
For kavol's issue... you should be able to fix that by actually adding the "Location Bar" item to the "Location Toolbar" under Settings->Configure Toolbars.

I have the google search-bar, and don't see any effect like is being described here. Is this still present in anyone else's copy of 3.5.2?
Comment 12 Stephan Sokolow 2006-08-31 01:26:25 UTC
It's present in my 3.5.2.
Comment 13 Jaime Torres 2008-07-14 20:01:05 UTC
Finally it works for me in svn trunk r828814 and later.
Comment 14 mario tuling 2008-10-15 16:13:08 UTC
if i close a tab, i only see the title bar flicker a very short time. but everything else seems ok, perhaps my machine is too fast but jamie torres has a slow one i think and so ill close this with worksforme. (r870xxx)