Bug 69429 - left button mouse click on Message-ID does not find article; middle button does
Summary: left button mouse click on Message-ID does not find article; middle button does
Status: RESOLVED FIXED
Alias: None
Product: knode
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: 0.7.6
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-01 12:20 UTC by Hajo Simons
Modified: 2005-10-01 16:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Fix for bugid=69429 (1.04 KB, patch)
2003-12-01 14:37 UTC, Hajo Simons
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hajo Simons 2003-12-01 12:20:18 UTC
Version:           0.7.6 (using KDE 3.1.94 (3.2 Beta 2), compiled sources)
Compiler:          gcc version 2.95.3 20010315 (SuSE)
OS:          Linux (i686) release 2.4.23

When reading an article you can click on 
Message-ID: XXX 
or
Reference: XXX
in the articles header where XXX is an ID of the form
RandomStuff@HostID.Host

Clicking on XXX gets the correct article when using the
middle button. ( OK )

Using the left button does the same, except that the
referring article is not found. ( not OK )
Response from newsserver: 403 no such article found
Comment 1 Hajo Simons 2003-12-01 12:55:13 UTC
KNArticleWidget::anchorClicked
should be the error location, but code seems ok, darn seems
to be a sophie thingie ;{
Comment 2 Hajo Simons 2003-12-01 13:07:55 UTC
getting closer:
left button:
knode: KNArticleWidget::anchorClicked() : message-id blabla/
middle button
knode: KNArticleWidget::anchorClicked() : message-id blabla

Comment 3 Hajo Simons 2003-12-01 13:58:15 UTC
preliminary fix would be:
RCS file: /home/kde/kdepim/knode/knarticlewidget.cpp,v
retrieving revision 1.162
diff -p -U3 -r1.162 knarticlewidget.cpp
--- knarticlewidget.cpp	24 Nov 2003 16:46:27 -0000	1.162
+++ knarticlewidget.cpp	1 Dec 2003 12:56:37 -0000
@@ -379,8 +379,8 @@ bool KNArticleWidget::eventFilter(QObjec
 void KNArticleWidget::viewportMousePressEvent(QMouseEvent *e)
 {
   QString a= anchorAt(viewportToContents(e->pos()));
-
-  if(!a.isEmpty() && (e->button()==RightButton || e->button()==MidButton))
+  
+  if(!a.isEmpty() && (e->button()!=NoButton))
     anchorClicked(a, e->button(), &e->globalPos());
   else
     if (e->button()==RightButton) {

Comment 4 Hajo Simons 2003-12-01 14:28:29 UTC
forget the fix I posted beforehand - that would leave the mouse in paste mode
better:
RCS file: /home/kde/kdepim/knode/knarticlewidget.cpp,v
retrieving revision 1.162
diff -p -U3 -r1.162 knarticlewidget.cpp
--- knarticlewidget.cpp	24 Nov 2003 16:46:27 -0000	1.162
+++ knarticlewidget.cpp	1 Dec 2003 13:27:14 -0000
@@ -379,10 +379,11 @@ bool KNArticleWidget::eventFilter(QObjec
 void KNArticleWidget::viewportMousePressEvent(QMouseEvent *e)
 {
   QString a= anchorAt(viewportToContents(e->pos()));
-
-  if(!a.isEmpty() && (e->button()==RightButton || e->button()==MidButton))
+  
+  if(!a.isEmpty() && (e->button()!=NoButton))
     anchorClicked(a, e->button(), &e->globalPos());
   else
+  {
     if (e->button()==RightButton) {
       QPopupMenu *popup = static_cast<QPopupMenu *>(knGlobals.guiClient->factory()->container("body_popup", 
 knGlobals.guiClient));
@@ -390,7 +391,8 @@ knGlobals.guiClient));
         popup->popup(e->globalPos());
     }
 
-  QTextBrowser::viewportMousePressEvent(e);
+    QTextBrowser::viewportMousePressEvent(e);
+  }
 }
 
Comment 5 Hajo Simons 2003-12-01 14:37:06 UTC
Created attachment 3493 [details]
Fix for bugid=69429
Comment 6 Robert 2004-02-07 16:03:55 UTC
Similar problem. Clicking on the message-id link in the article body using left mouse button does not work, usign middle does. I found it might be a problem with the message-id string conversion

Output from tcpdump.

------------------------
using left mouse button:

0x0000   4500 005b a4d0 4000 4006 7c57 0a01 0573        E..[..@.@.|W...s
0x0010   0a01 0001 0fc6 0077 4d9f 914f c39f 57dd        .......wM..O..W.
0x0020   5018 c1e8 c2f7 0000 4152 5449 434c 4520        P.......ARTICLE.
0x0030   3c62 766a 3374 3525 3234 6169 3225 3234        <bvj3t5%24ai2%24
0x0040   3140 6973 702e 616b 6164 656d 696b 2e70        1@isp.akademik.p
0x0050   772e 6564 752e 706c 3e0d 0a                    w.edu.pl>..

Retrieving article using menu item.

0x0000   4500 0057 a4d2 4000 4006 7c59 0a01 0573        E..W..@.@.|Y...s
0x0010   0a01 0001 0fc6 0077 4d9f 9182 c39f 57f2        .......wM.....W.
0x0020   5018 c1e8 271e 0000 4152 5449 434c 4520        P...'...ARTICLE.
0x0030   3c62 766a 3374 3524 6169 3224 3140 6973        <bvj3t5$ai2$1@is
0x0040   702e 616b 6164 656d 696b 2e70 772e 6564        p.akademik.pw.ed
0x0050   752e 706c 3e0d 0a                              u.pl>..
----------------

ARTICLE <bvj3t5%24ai2%241@isp.akademik.pw.edu.pl>

and

ARTICLE <bvj3t5$ai2$1@isp.akademik.pw.edu.pl>

knode: 0.7.6, KDE: 3.2.0, distro: PLD, gcc: 3.3.2
Comment 7 Volker Krause 2005-10-01 16:22:35 UTC
Probably the same issue as #101570 and #110077, anyway this has been fixed for KDE 3.5.