Version: 1.5.93 (using KDE 3.1.93 (CVS >= 20031111), compiled sources) Compiler: gcc version 3.2.2 (Mandrake Linux 9.1 3.2.2-3mdk) OS: Linux (i686) release 2.4.21-0.13mdk To reproduce: Make sure you have some items in your trash folder. Select (left click) any folder other then the trash folder i.e. inbox. Right click on the trash folder (the trash folder then becomes highlighted). Select Empty from the context menu. Nothing happens. If you select the trash folder with left mouse button first, then select Empty from context menu it will work. This may be related to bug 67725
More info: KMail has now started to ask me this: "Are you sure you want to move all messages from folder inbox to the deleted items folder?" When I select Empty trash without selecting it with the left mouse button first. That would mean that this bug is related or a duplicate of bug 49667 which has been closed. However I am using CVS updated yesterday. Could someone reopen bug 49667 and mark this as a duplicate.
Subject: kdepim/kmail CVS commit by kloecker: Fix bug 69176: Empty trash doesn't work when trash folder not selected and bug 69230: different problems regarding searching / virtual folders It's actually the same bug and it was introduced by a recent patch which was reviewed by two (!) persons. The next time you review something please actually test the patch and don't just say "Hmm, looks good.". Yes, I'm guilty of the same lazyness. Let's make sure it doesn't happen again. CCMAIL: kmail@kde.org CCMAIL: 69176-fixed@bugs.kde.org CCMAIL: 69230-fixed@bugs.kde.org M +8 -4 kmfoldertree.cpp 1.271 M +1 -2 kmfoldertree.h 1.76 --- kdepim/kmail/kmfoldertree.h #1.75:1.76 @@ -231,6 +231,5 @@ protected slots: void autoScroll(); - /** right mouse button */ - void rightButtonPressed( QListViewItem *, const QPoint &, int); + void slotContextMenuRequested( QListViewItem *, const QPoint & ); /** Fires a new-mail-check of the account that is accociated with currentItem */ --- kdepim/kmail/kmfoldertree.cpp #1.270:1.271 @@ -297,6 +297,6 @@ void KMFolderTree::connectSignals() this, SLOT( autoScroll() ) ); - connect( this, SIGNAL( rightButtonPressed( QListViewItem*, const QPoint &, int)), - this, SLOT( rightButtonPressed( QListViewItem*, const QPoint &, int))); + connect( this, SIGNAL( contextMenuRequested( QListViewItem*, const QPoint &, int ) ), + this, SLOT( slotContextMenuRequested( QListViewItem*, const QPoint & ) ) ); connect( this, SIGNAL( expanded( QListViewItem* ) ), @@ -932,6 +932,7 @@ QListViewItem* KMFolderTree::indexOfFold //----------------------------------------------------------------------------- -// Handle RMB press, show pop up menu -void KMFolderTree::rightButtonPressed(QListViewItem *lvi, const QPoint &p, int) +// show context menu +void KMFolderTree::slotContextMenuRequested( QListViewItem *lvi, + const QPoint &p ) { if (!lvi) @@ -943,4 +944,6 @@ void KMFolderTree::rightButtonPressed(QL KMFolderTreeItem* fti = static_cast<KMFolderTreeItem*>(lvi); + if ( fti != mLastItem ) + doFolderSelected( fti ); if (!fti ) @@ -1048,4 +1051,5 @@ void KMFolderTree::rightButtonPressed(QL triggerUpdate(); delete folderMenu; + folderMenu = 0; }
*** Bug 69309 has been marked as a duplicate of this bug. ***