Bug 69154 - notebook lcd screen brightness
Summary: notebook lcd screen brightness
Status: RESOLVED FIXED
Alias: None
Product: klaptopdaemon
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Paul Campbell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-27 15:48 UTC by Cristián González
Modified: 2004-04-12 18:07 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cristián González 2003-11-27 15:48:29 UTC
Version:           1.4 (using KDE KDE 3.1.93)
Installed from:    Unlisted Binary Package
OS:          Linux

I'm using Fedora Core 1, with KDE 3.1.93 (unstable RPMs).

I have problems with klaptop setting the screen bightness to maximun. To select max brightness i have to scroll down a little. The problems happens every time i log to KDE because klaptop tries to set the brightness to max.

My notebook is a Toshiba Satellite pro 6100.
Comment 1 Cristián González 2003-11-27 15:52:27 UTC
This is when Screen Brightness is setting to MAX

cat /proc/acpi/toshiba/lcd
brightness:              0
brightness_levels:       8

This is when i scroll down brightness a little

cat /proc/acpi/toshiba/lcd
brightness:              7
brightness_levels:       8
Comment 2 Alejandro Lorenzo 2004-02-11 18:37:46 UTC
I had the same problem here (Toshiba satellite 2450) and after looking at it i think i have found the problem exactly in the file 'portable.cpp' at line 1460.

The slider for brightness adjusment gives a vaule between 0 and 255 for bright, while the toshiba acpi driver only knows about 8 levels of bright (from 0 to 7) to solve this the >> bit operator is used moving the bits 5 positions, however, in the original file, the operation is done with:

val=(val+7)>>5

so, if we have a val>249 the thing goes a bit up with the +7 and when masking with val&7 to set the bright we are setting brightness 0 in the acpi. That's why if you set the TOP brightness in the slide in a toshiba computer you get a dark screen

so, i think it should read val=val>>5 (without the +7). It works nicely now. :-)

(sorry; i don't know how to use diff, yet... hope this helps...)
Comment 3 Volker Krause 2004-04-12 18:07:54 UTC
Fixed in CVS HEAD, thanks for the solution.