Bug 69050 - JJ: Taskbar blinking cannot be turned off
Summary: JJ: Taskbar blinking cannot be turned off
Status: RESOLVED FIXED
Alias: None
Product: kicker
Classification: Unmaintained
Component: taskbarapplet (other bugs)
Version First Reported In: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Aaron J. Seigo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-26 10:12 UTC by Russell Mull
Modified: 2006-01-21 18:44 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
disables notification (15.28 KB, patch)
2004-10-27 08:07 UTC, illogic-al
Details
Adds a new option to the taskbar configure panel for # of flashes or indefinite flashin. (30.59 KB, patch)
2004-11-16 18:26 UTC, Danny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Mull 2003-11-26 10:12:45 UTC
Version:            (using KDE KDE 3.1.93)
Installed from:    Unlisted Binary Package
OS:          Linux

Some applications (like gaim) will make the taskbar blink when they have new information.  That's great... but it makes me CRAZY.  I imagine it makes other people crazy too.  There should be a way to turn this off.  

I'm filing this as a bug because blinking lights that cannot be disabled are defects.
Comment 1 Lubos Lunak 2003-11-26 10:21:51 UTC
It only blinks few times (3, IIRC), and then it only stays highlighted ?! Is it really that bad?
And, actually, I think it can be disabled - go to kwin's advanced settings dialogs, and set focus stealing prevention level to none.
Comment 2 Russell Mull 2003-11-26 10:31:13 UTC
You're right, it does blink only a few times, but I do think it really is that bad.  I know I'm not the only one. 

You are correct that setting focus stealing prevention to low or none disables this - I didn't realize that it would affect the blinking.  Perhaps a refinement of the terminology is in order, or a simple switch that turns blinking on and off regardless of which prevention level is selected.  I do think that it's important to make this explicit because it's such an imposing visual cue.  
Comment 3 Lubos Lunak 2004-05-18 13:33:12 UTC
JJ: This just needs a configuration option in taskbar options (kdebase/kcontrol/taskbar) and disabling the blinking based on the option (in kdebase/kicker/taskbar/taskcontainer.cpp, look for 'attention').
Comment 4 S. Tringali 2004-08-16 21:32:05 UTC
I like the blinking to inform me of some sort of async notification, but it's happening at the wrong times.

Example: Gaim is sitting the tray with the buddy list closed.  I click on the gaim icon in order to see the buddy list.  The buddy list shows, but the icon blinks 3 times, which is annoying since I asked for it explicitly.
Comment 5 illogic-al 2004-10-27 08:07:46 UTC
Created attachment 8049 [details]
disables notification

This is a patch to disable taskbar notification. If it doesn't work blame
aseigo, he helped me do it :-p
Comment 6 Danny 2004-11-16 18:08:28 UTC
There is a patch here http://kdelook.org/content/show.php?content=17669 which I wrote that puts an option in the taskbar configure panel for indefinite flashing (which is what I use) or to edit the number of times it flashes. Change it to 1 for those that dont want it to flash three times. Maybe this could be incorporated into the next KDE release?

Also, in reply to S. Tringali:
The example you cited is a problem with gaim, not KDE. Gaim should not set the urgent flag for the buddylist window when it is explicitly requested.


-Cratos
Comment 7 Danny 2004-11-16 18:26:56 UTC
Created attachment 8299 [details]
Adds a new option to the taskbar configure panel for # of flashes or indefinite flashin.

Added patch from http://kdelook.org/content/show.php?content=17669

For those of you that don't like the flash notification, did you still want the
taskbar button to change color? Or did you just want to completely disable
notification all together? I should be able to modify this patch accordingly.

-Cratos
Comment 8 Danny 2004-11-16 21:57:26 UTC
It turns out that my reply to S. Tringali was wrong. This isnt just a Gaim issue. KDE puts the urgent notification on any new window that doesn't get focus.  ie Try opening a termnal and before it comes up click continually on another window until it is up. The terminal window will appear behind the other window and will be urgent. This seems to be due to focus stealing prevention. Currently in KDE 3.3.0 and focus stealing on low, I have the problem. With it on none, the problem is gone. 

I would agree that for certain dialogs this behavior is incorrect. If I have requested a dialog, I know it is comming and don't need an urgent message. However, as far as things like instant messages or warnings. This behavior is correct. If I am in the middle of typing something, the new window should come up behind and flash urgent (as it currently does). The problem is how KDE will decide if a window was explicitly requested or not. 

-Cratos
Comment 9 Lubos Lunak 2004-11-18 19:01:01 UTC
I like the patch in comment #7 better (well, except for some things like <<1 with a long comment instead of simply writting *2). However, it doesn't apply at all to current CVS :(.
I think the number of flashes == 0 should simply mark the taskbar entry without flashing, and checkbox turned off shouldn't mark at all.
Comment #8 is unrelated, and necessary support should be already implemented in Gtk I think.
Comment 10 Danny 2004-11-19 15:32:42 UTC
I agree with your comment (comment #9) as far as flashes == 0. I will probably end up rewriting this patch so that unchecking simply doesnt mark the taskbar at all and zero only marks it (no flash). For those of us that want indefinite flashing (me), putting something like 9999999 will allow it to flash for about 115 days.

As far as the bit shift thing (<< 1), I was just kind of being funny and never changed it back, not that it needs to be changed really.

I don't currently have the CVS code. Do you know why it doesn't apply to the current CVS? If it is because of some sort of change in code, I'll try to fix it.

-Cratos
Comment 11 Lubos Lunak 2004-11-30 14:31:49 UTC
There have been large changes in kicker sources recently. It however hadn't applied for me even before the changes.
Comment 12 Aaron J. Seigo 2005-06-02 23:41:53 UTC
i agree with lubos' comments. i'd also add that for the GUI option, it shouldn't be a negative statement ("checking this turns off blinking") but a positive one ("checking this turns on blinking").. so something like:

[ x ] Flash urgent windows [ 4 times ^]

the "4 times" box would be a QSpinBox and use the "suffix" and "special text" attributes for the "times" text
Comment 13 Lubos Lunak 2006-01-21 18:44:03 UTC
You can alter how windows demanding attention are represented in KControl->Sound->System notification - select KDE window manager in the top combo and configure actions for the two events about windows demanding attention.