Bug 68975 - konqueror listview rightclick always selects file
Summary: konqueror listview rightclick always selects file
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR grave
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 57645 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-11-24 23:17 UTC by D.L.C.Burggraaff
Modified: 2004-05-10 23:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
3.2b1 rightclick on directory.Name (107.27 KB, image/png)
2003-12-02 22:44 UTC, D.L.C.Burggraaff
Details
3.2b1 rightclick on directory.Modified (109.96 KB, image/png)
2003-12-02 22:45 UTC, D.L.C.Burggraaff
Details
3.2b1 rightclick on file.Name (108.70 KB, image/png)
2003-12-02 22:46 UTC, D.L.C.Burggraaff
Details
3.2b1 rightclick on file.Modified (109.31 KB, image/png)
2003-12-02 22:47 UTC, D.L.C.Burggraaff
Details
3.1.4 rightclick on directory.Name (120.53 KB, image/png)
2003-12-02 22:49 UTC, D.L.C.Burggraaff
Details
3.1.4 rightclick on directory.Modified (121.32 KB, image/png)
2003-12-02 22:49 UTC, D.L.C.Burggraaff
Details
3.1.4 rightclick on file.Name (119.73 KB, image/png)
2003-12-02 22:50 UTC, D.L.C.Burggraaff
Details
3.1.4 rightclick on file.Modified (121.54 KB, image/png)
2003-12-02 22:51 UTC, D.L.C.Burggraaff
Details

Note You need to log in before you can comment on or make changes to this bug.
Description D.L.C.Burggraaff 2003-11-24 23:17:59 UTC
Version:           3.1.93 (using KDE 3.1.93 (3.2 beta 1), compiled sources)
Compiler:          gcc version 3.2.3
OS:          Linux (i686) release 2.4.22

Konqueror File Manager in Tree View, Detailed List View or Text View.

In 3.1.x a rightclick in the Name column selected the file and gave the file context menu with a.o. Cut and Copy. A rightclick in any other column gave a context menu with a.o. Paste.

In 3.2b1 a rightclick in any column selects the file and gives the Cut and Cope context menu. So I can no longer Paste ...
Comment 1 Tom Collins 2003-11-25 04:57:19 UTC
Confirmed on CVS from 2003-11-24.  But I'm not sure whether this
is a bug or not.  Right-clicking (which selects a file), and then
Paste sort-of implies pasting onto that file, which doesn't make
sense.  BTW, you get the Paste action if you right-click on a 
directory or on a blank area of Konqueror.
Comment 2 D.L.C.Burggraaff 2003-11-25 23:05:51 UTC
The problem is that in Tree View for e.g. /bin there is no blank space ...

In 3.1.4 rightclick a Name of a directory - the directory is selected and a cut/copy/paste context menu is given.
In 3.1.4 rightclick a Size of a directory - the directory is NOT selected and a paste context menu is given.
In 3.1.4 rightclick a Name of a file - the file is selected and a cut/copy context menu is given.
In 3.1.4 rightclick a Size of a file - the file is NOT selected and a paste context menu is given.

In 3.2b1 rightclick a Name of a directory - the directory is selected and a cut/copy/paste context menu is given.
In 3.2b1 rightclick a Size of a directory - the directory is selected and a cut/copy/paste context menu is given.
In 3.2b1 rightclick a Name of a file - the file is selected and a cut/copy context menu is given.
In 3.2b1 rightclick a Size of a file - the file is selected and a cut/copy context menu is given.
Comment 3 D.L.C.Burggraaff 2003-11-25 23:29:11 UTC
The following related behavior is identical in 3.1.4 and 3.2b1.

Setup two treeviews and:
Drag a directory from 1) to a directory on 2): when dropping on Name the pointed to directory is selected and the copied directory ends up in the pointed to directory, when dropping on Size the pointed to directory is NOT selected and the copied directory ends up in the "parent" directory. 
Drag a directory from 1) to a file on 2): you can drop on any column BUT Name and the copied directory ends up in the "parent" directory.
Drag a file from 1) to a directory on 2): when dropping on Name the pointed to directory is selected and the copied file ends up in the pointed to directory, when dropping on Size the pointed to directory is NOT selected and the copied file ends up in the "parent" directory. 
Drag a file from 1) to a file on 2): you can drop on any column BUT Name  and the copied directory ends up in the "parent" directory.
Comment 4 D.L.C.Burggraaff 2003-11-25 23:32:34 UTC
I know the above two comments are difficult to read  ;^)
But the base line is that when there is no blank space in the Tree View the 3.1.4 behavior is workable, whereas the 3.2b1 behavior is not ...
Comment 5 D.L.C.Burggraaff 2003-12-02 22:44:31 UTC
Created attachment 3524 [details]
3.2b1 rightclick on directory.Name
Comment 6 D.L.C.Burggraaff 2003-12-02 22:45:38 UTC
Created attachment 3525 [details]
3.2b1 rightclick on directory.Modified
Comment 7 D.L.C.Burggraaff 2003-12-02 22:46:28 UTC
Created attachment 3526 [details]
3.2b1 rightclick on file.Name
Comment 8 D.L.C.Burggraaff 2003-12-02 22:47:14 UTC
Created attachment 3527 [details]
3.2b1 rightclick on file.Modified
Comment 9 D.L.C.Burggraaff 2003-12-02 22:49:00 UTC
Created attachment 3528 [details]
3.1.4 rightclick on directory.Name
Comment 10 D.L.C.Burggraaff 2003-12-02 22:49:54 UTC
Created attachment 3529 [details]
3.1.4 rightclick on directory.Modified
Comment 11 D.L.C.Burggraaff 2003-12-02 22:50:30 UTC
Created attachment 3530 [details]
3.1.4 rightclick on file.Name
Comment 12 D.L.C.Burggraaff 2003-12-02 22:51:07 UTC
Created attachment 3531 [details]
3.1.4 rightclick on file.Modified
Comment 13 D.L.C.Burggraaff 2003-12-02 23:04:20 UTC
I just found out that in 3.2b1 in a "full" tree view there is no way to create a new directory/file via rightclick :((
To be honest, one can create a new directory/file via Menu > Edit > Create New. 

This bug is becoming a showstopper for me - please set the priority to grave.
Comment 14 D.L.C.Burggraaff 2003-12-02 23:32:44 UTC
Summary
=======
In Icon, MultiColumn and Info List View when one rightclicks on an item (directory or file) a context menu for that item (highlighted) is shown. When one rightclicks on a blank space a context menu for the current directory (Create New, Paste) is shown.
In Tree, Detailed List and Text View for a big directory there is no blank space and any rightclick gives a context menu for that item (highlighted).
In 3.1.x this dilemma was resolved by treating any column other than Name as blank space.

Please treat this useability bug as grave.
Comment 15 D.L.C.Burggraaff 2003-12-28 15:55:32 UTC
3.2 Beta 2 - and this USABILITY bug is still not even confirmed ...
Comment 16 D.L.C.Burggraaff 2004-01-26 21:31:36 UTC
3.2 RC1 - and this USABILITY bug is still there - it is not even confirmed ...
It looks like I will have to stick to 3.1.5 for quite some time to come ...
Comment 17 Andres Kärner 2004-02-05 15:11:51 UTC
This same problem is in release!!!!!
This _is_ showstopper!!!
Comment 18 Alexander Neundorf 2004-02-08 18:42:27 UTC
I think I fixed it in HEAD. If it works, I'll backport to the 3_2_BRANCH

Alex
Comment 19 D.L.C.Burggraaff 2004-02-08 21:26:45 UTC
Dear Alexander,
Thank you for the update.
I am eagerly awaiting the 3.2 backport!
Kind regards, Dick
Comment 20 Jason W 2004-02-12 00:50:06 UTC
3.2 final still has this.. At the very least it is inconsistant.  You cannot only open a file with left click in the name column, but right click in ANY column gives you the file's right click menu with no possibility to paste or create a new directory.  

I'd call it a showstopper.  I won't use 3.2 on my everyday distro until this is fixed.  This bug is set to Resolved?  Hopefully without sounding like a jerk: where?  What do I need to do to get a version without this bug?
Comment 21 D.L.C.Burggraaff 2004-02-18 22:57:33 UTC
Dear Alexander,
I noted your commits for this bug in the KDE_CVS_Digest of Feb 13, 2004.

I downloaded the seven complete sources the diffs in the commit for the KDE_3_2_BRANCH point to, copied them to my kdebase-3.2.0 build directory and started a make. Alas that make failed on the first compile: konq_listviewitems.cc:254: no matching function for call to `KonqFMSettings:: caseSensitiveCompare(QString, QString)'.

I then downloaded the diff that looked the most promising:  konq_listviewwidget.cc -r1.226.2.2 -r1.226.2.3, applied this diff to my (restored) kdebase-3.2.0 build directory and did a make (no problems) and make install.

These are the results:
1) When *no* directory or file is selected a rightclick on a non-name column now indeed gives a paste context menu - choose paste and the file is copied to the current directory. Hurray!
2) When a directory or file *is* selected a rightclick on a non-name column still gives a cut/copy context menu for the selected item. One has to explicitely unselect (shift leftclick or via the Edit menu) the directory or file and then rightclick on a non-name column again to get a paste context menu.

The explicit unselect is stil awkward, but when compared to the switch to icon view to find some free space to rightclick on (and the switch back to listview) that was required before the patch things have improved significantly. For me the *showstopper* has become a mere *nuisance*.

In 3.1.x a rightclick unselected whatever was selected. It would be nice if this behavior were re-instated.
Kind regards, Dick
Comment 22 D.L.C.Burggraaff 2004-02-18 22:59:26 UTC
Reopened for the request to make a rightclick unselect whatever was selected.
Comment 23 Verdi March 2004-02-22 07:23:22 UTC
The context menu behavior in detail list view is indeed a bug.

Regarding right-click should deselect selection, I hope this
refers to right-click performed on place other than the "Name"
column.
Comment 24 Jason W 2004-04-20 07:19:26 UTC
right click with full list view lets you paste now, this has been fixed.  But there is still no possibility to create a new file or folder.

When first entering a full directory and no file is selected it is possible, but once a file is selected, right click on columns other than name no longer deselects a file, so one cannot create a new file or folder.  

using 3.2.2
Comment 25 Verdi March 2004-04-20 11:03:42 UTC
As a workaraound, press Esc to "unfocus" the filename. Then, when you right-click at other fields, you'll get the correct context menu.
Comment 26 Stephan Binner 2004-05-09 17:54:06 UTC
*** Bug 57645 has been marked as a duplicate of this bug. ***
Comment 27 Stephan Binner 2004-05-09 17:54:50 UTC
CVS commit by binner: 

Backport konq_listviewwidget.cc 1.239
CCMAIL: 68975-done@bugs.kde.org


  M +1 -1      konq_listviewwidget.cc   1.226.2.4


--- kdebase/konqueror/listview/konq_listviewwidget.cc  #1.226.2.3:1.226.2.4
@@ -798,5 +798,5 @@ void KonqBaseListViewWidget::slotPopupMe
 {
    kdDebug() << "KonqBaseListViewWidget::slotPopupMenu" << endl;
-   popupMenu( point,true );
+   popupMenu( point,false );
 }
 


Comment 28 D.L.C.Burggraaff 2004-05-10 23:20:17 UTC
Dear Stephan,
Your May 9 fix indeed resolves the remaining nuisance of having to unselect explicitely.
Thank you, Dick