Version: (using KDE KDE 3.1.93) Installed from: Gentoo Packages while importing classes a operation properties dialog opens - pressing cancel crashes umbrello
Created attachment 3310 [details] Patch to fix 68395 (crash on class import)
Umbrello crashes when the class has an overloaded operation, one of which takes no parameters. The most comon case would be a class having two or more constructors and one of them doesnt take any parameters The problem is: 1 - The doc always create the operation empty ( just with name ), so if the operation with no parameters has already been added to the classifier, the signature check will fail and the dialog to change the name and/or parameters pops up (first error) 2 - The user doesnt know why he gets the dialog, so just presses cancel and the doc returns 0L ( which is correct, since the user aborted the op creation) 3 - the class parser doesnt check for 0L and tries to set attributes and return type (second error) Someone please review the patch, and I will apply it.
Subject: Re: [Uml-devel] import of classes results in sig11 (with a little help) lparrab@gmx.net <lparrab@gmx.net> [031120 22:39]: > Umbrello crashes when the class has an overloaded operation, one of which > takes no parameters. > The most comon case would be a class having two or more constructors and > one of them doesnt take any parameters I think your patch works. I can't reproduce a crash. Ok, I can, but I think it is another problem I will open another bug report for it ;-9 Steinchen
Patch applied